From patchwork Wed Nov 15 10:13:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mingjin Ye X-Patchwork-Id: 134373 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC31343337; Wed, 15 Nov 2023 11:28:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D7FF402C0; Wed, 15 Nov 2023 11:28:04 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 7184C40285; Wed, 15 Nov 2023 11:28:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700044082; x=1731580082; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IZouvKfGeP0nYD6YhCgdadfgrWyNK//BDG3KhQtEzz8=; b=GnLW2tyH8I6hicFNd5RjJlhzS9gZTujUlhfQA9NlLwBUU9efM+F7GLbo UsEMjhGah1+XywK6KwGktMERzhZmK+DKMOqjyI8+HuF7F2f0xUoA3A2hv 1VUvETigP+gbPXm9oZoa9HtK8M/saLtAQN1Mv7eWqTwLFMHsszYv/T7wW m5OFd6XwFsILA4ZhDud4cMuLnRjWll12+M6elLtHWntB83dgjR5pz6Xx7 KzCtL4zyMh6JuaJm95Z5vkVuBLw7hEMaIBVW9y4I4U1U1Yzal0I+4Qiwl 2IqOr4g3V6d22vHlqN8WWf6xJeqKFIRMq8mpfRheZOArfKFKeYAtXo/PI w==; X-IronPort-AV: E=McAfee;i="6600,9927,10894"; a="457346990" X-IronPort-AV: E=Sophos;i="6.03,304,1694761200"; d="scan'208";a="457346990" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2023 02:28:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10894"; a="888544937" X-IronPort-AV: E=Sophos;i="6.03,304,1694761200"; d="scan'208";a="888544937" Received: from unknown (HELO localhost.localdomain) ([10.239.252.253]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2023 02:27:59 -0800 From: Mingjin Ye To: dev@dpdk.org Cc: qiming.yang@intel.com, Mingjin Ye , stable@dpdk.org, Jingjing Wu , Beilei Xing Subject: [PATCH v2] net/iavf: fix error devargs parsing Date: Wed, 15 Nov 2023 10:13:23 +0000 Message-Id: <20231115101323.545018-1-mingjinx.ye@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231113104436.86555-1-mingjinx.ye@intel.com> References: <20231113104436.86555-1-mingjinx.ye@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch fixes unknown parsing results in the absence of devarg "no-poll-on-link-down" and fixes the devarg variable type. Fixes: 5b3124a0a6ef ("net/iavf: support no polling when link down") Fixes: 3e6a5d2d310a ("net/iavf: add devargs to enable VF auto-reset") Cc: stable@dpdk.org Signed-off-by: Mingjin Ye Acked-by: Qi Zhang --- v2: fix devarg variable type. --- drivers/net/iavf/iavf.h | 4 ++-- drivers/net/iavf/iavf_ethdev.c | 7 +------ 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h index c115f3444e..10868f2c30 100644 --- a/drivers/net/iavf/iavf.h +++ b/drivers/net/iavf/iavf.h @@ -307,8 +307,8 @@ struct iavf_devargs { uint8_t proto_xtr[IAVF_MAX_QUEUE_NUM]; uint16_t quanta_size; uint32_t watchdog_period; - uint8_t auto_reset; - uint16_t no_poll_on_link_down; + int auto_reset; + int no_poll_on_link_down; }; struct iavf_security_ctx; diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 0c6ab4ac5a..d1edb0dd5c 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -2294,7 +2294,6 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev) struct rte_kvargs *kvlist; int ret; int watchdog_period = -1; - uint16_t no_poll_on_link_down; if (!devargs) return 0; @@ -2329,13 +2328,9 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev) ad->devargs.watchdog_period = watchdog_period; ret = rte_kvargs_process(kvlist, IAVF_NO_POLL_ON_LINK_DOWN_ARG, - &parse_u16, &no_poll_on_link_down); + &parse_bool, &ad->devargs.no_poll_on_link_down); if (ret) goto bail; - if (no_poll_on_link_down == 0) - ad->devargs.no_poll_on_link_down = 0; - else - ad->devargs.no_poll_on_link_down = 1; if (ad->devargs.quanta_size != 0 && (ad->devargs.quanta_size < 256 || ad->devargs.quanta_size > 4096 ||