From patchwork Wed Nov 15 03:23:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 134368 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BD8543332; Wed, 15 Nov 2023 04:23:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1011740648; Wed, 15 Nov 2023 04:23:40 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2127.outbound.protection.outlook.com [40.107.223.127]) by mails.dpdk.org (Postfix) with ESMTP id 19C2F402E4; Wed, 15 Nov 2023 04:23:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KqVKgSrqobS6bDwz4LYVgkwDtRqcHVm+WQqtevNhbPKw8ThhO64NsXG7oyUjmwAmFwIixhdSW8pQT36QOayF4fRdxGbH/BrrX8Cudvs6a8xPXN43sMk+eJ4OZnrWpSf2oAA7IXkF9xmhQ2jKCZnnRaG1QxRXZsfCUqjCSuBhMwqED9hLBI3iv0JXoq3wE7uJsmoLTXAjACD++OXC6IHhg6N0fTmdIEEPcUtgmAimhZKLA+JyybrTzAYUz1x1Q9yHKCdIhwNDWcJ5CNsGV379KdAh2Yd/09iOEVm42hVOuH7ObZ5wG/BXBJkSt5HVt0AzIwlBWCQdMB2fIh6PrxUbLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EawV/gPecj1heWN8y308GF+yr/8oInUXYwvwhUvsTZA=; b=cog1f/pxn4VmbMvRbfqPEe4Xp+jcmOvqGyRwuMx5b8iuxCnPaBHS71sRc2gLJVhFMyksy1wPRt6VI1jrXq2vMCOPL5bjeHKcdT7FwLPA6ZHK/rvlcPQEcoYmcWmC+MZ04QLGPYgnPSCT+4yviH5GrxTi2YhUTTv6J0SbcvfeO72hnzlFqZwjMhuuNB6uF+GMcjRvHt51KQOjC0O6dsQFJsd3KbPCG3toY98hM/fjTLG5TpV/n697tJ3FgulgthVY8xwvtLvyto7d8xJXHUnhth7VtFBHh0HtKzb4xWY0xhaWOva2AznYgWKe9YdUITt1y50P3iRG5rP8vzgVSwA4ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EawV/gPecj1heWN8y308GF+yr/8oInUXYwvwhUvsTZA=; b=cP3XVmSx6JI0qhcZG19DSXUY6MN28+G5FYPoejixQjsPEYIGxp5EwZgSf3gdlTjca5QOuwhGz6Tuo9U5x7fut3x70QM3ASY4u1vMe27E/VjMVXxVDnmQ92KGJLps10ZX6yE/JaDbuv5c1LA/ck0pD+bLg+6uixCyzbAQB5dQQuU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CO3PR13MB5719.namprd13.prod.outlook.com (2603:10b6:303:171::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Wed, 15 Nov 2023 03:23:36 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6977.029; Wed, 15 Nov 2023 03:23:36 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH 2/5] vdpa/nfp: fix integer handling issues Date: Wed, 15 Nov 2023 11:23:07 +0800 Message-Id: <20231115032310.756221-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231115032310.756221-1-chaoyong.he@corigine.com> References: <20231115032310.756221-1-chaoyong.he@corigine.com> X-ClientProxiedBy: PH7PR10CA0023.namprd10.prod.outlook.com (2603:10b6:510:23d::21) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|CO3PR13MB5719:EE_ X-MS-Office365-Filtering-Correlation-Id: 8138cc26-1dbe-4c2f-b7e8-08dbe58a4116 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5tmLIZSejjntX7+PMY+p00t9bRb/2fhVRRyiK2iPIg6eixrhl+gD9RtcYfam8rEeGHE0oJTYMo9a1BJqt8pUFh8kduIvZmbawZ8WYG8IcKxVV7tf2Jm3RtvEiBg07PDWOCwzZUEhGMtc0G2a2Lb6U7YvfOQ2AvbgJHIzYDRig+FYVMBLeH4DPESo3eOiAlumQ8QUP7Mvfc05DiwUuPMFZbnttE7kXAWYaGpw+g2BfO/pp8Mzjz4lVUPTzkU2pGk6KAkcS5fI0h9ZhDbUA+L8NO/HpvRFzxVntABtOWe+FgpG9mpZUERg8HuOH68GYpThBiX66XUelzdKfAgDIP6QBQxILctjht78vYTUfvIrEUAj3gDUwxaFnxByxPAfUF2OTcCDRs+LdvzrCivNRBksAmy9EfzSgYNc86Pi80ffkjQpZXSY8q3TFo5xTFIbNstjRWOhzyz+FEOoemKbTdzljXlErxbDeL0ZCXw4nAgPu55q+lIcdfBbXqFYECvqQFVpeyD9c0pdLD7hNOZ2QKImfNlDiaBVRVNkQU2Kc04YZBoW13kf+yb964694DPogUoj9757QFo68RYJD03CCrMTCc7RbHuC+h8dgIPrUbwPXIT0b6K7XvMH4bLefqfLbozZnD0xgCUQvWKJW2XFZcMwJqoerabAyFdOmns9udWiXy0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(39830400003)(366004)(346002)(376002)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(2616005)(6512007)(1076003)(107886003)(26005)(6486002)(478600001)(36756003)(44832011)(450100002)(8936002)(86362001)(4326008)(8676002)(5660300002)(41300700001)(4744005)(2906002)(66556008)(54906003)(66476007)(66946007)(6916009)(316002)(38350700005)(6506007)(52116002)(6666004)(38100700002)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qz+wrckqC3RcGzF4mEkOlYqAnTXgRombYfkPTm9XVX/99PL40dD3BNib/XlFBW3jaFHYF27hBdslWdqpq8LgPynsN0Jz+fnQAArFciEHfMwsyOHqa378q2AmZMciuhFet9TmFnOQqGBUOskEpkhtPN/s28lkWCXrtqUd23vVtGOtsNileH99eF7S30tcTWkcBoaMkxOtSlgpZo4r/aHdHxZPadgD14omofc2FMorJQXlRwGAjRrz8+Y8vLwkVxDA8LsetMLXKP8RMLGllo/3dNfHJEzPFXmHQ1a2hUACFdZRJYatLaV59wIg4u8iy5KPqNgh2KP3+x26MMQ78FSXuc8Sdbkm5KfQKUQ/kMXv7w49ZdAvgMIA3XX+l/tI8DmrmyhVfva4nEyBRsSFccRfl0xmIG5xFqwp5+QZbFOTdJPDq2TQPiapFxqwy8izXuGfgvFQScgg9Z8xGOp6KKC9pxDUpFGBtf2PpHPMe3gMAjqHfAmzsVU82YVEpJDp2DciNq2W6hfefdIAmrM+G+6g3FrEv6QGp1LZdwlS2hyEzPptXmXbiRZZ4SHRzutxG9wxkKwdSyF06oS8c788Y0OkMP4xMCGTIESILL/kHlHMfS2hjcN4zAosOtNuIW2+S2IoVVrPdKuSAUa1xPrNd7EDh+hjWBxoVSZtW5qGlKrYlFCR0SvN6ynI829Tqjj7OggjXSYp610Bfmq5naTQQbwMHBSK30b7AlqdKCiiRYw1GB52+3I/HJcP97O6w0kAC1RnIhejhVbe3dmqlIh0N0iSKwsuLyaO8fVgDDaXDSyud19daDnGgPHZW83Xn836zI2KTHJEvW7tu3cPy6D3gUO+1YCuK52hqRbBifAbnVyWFpk3W76f7C4eusBY75mZpEKVKOoBhHvUE6unB+nRT2L7xWh78O7y5jn1/v30koIEBz1lNwyc/4TJwPnI7Rzn9cNqwqaxlBjLG0gdIhBGeONO3CdMcYp8KWoa3Np+Fot5JhGhnpSVXn3chmVyuMfzxVYfQqFNOCfi5ZEqjBwQSHqToafyvuoxdUq6NOn/crH77JIKJiesITJ25KkEAmbKcLo0lEafEudPQWDwLg6daR6cuuDOWDX7MF9yicZn4deDZCkBmTfNQW0hDHDOhVT6Sg4gIYlB1Oi49MN9oVQxr32cqqGYqX2NmHr1UEHWBkF9HaYhrZ29BElWaZi7Tkv4ES+eOshYrnDbXe2GhD9vid6DuNr4jIPPgrTfEo7uX1cRxX0U7W1hHwIkuXDuwG+GV1ryx5RyAr+B6bzU4c1AJYfrs5GyXgBgVM4S8UcM7gFuqtlkhBPwrBMixBS8Cz59Ifq34Ga1mRyIwGDW6Amobk082lpai4NziVWmCQ/G/CUEfm6L4gpXk5czlpdx8LTKKhdUr8vP1oswrUTTSKdJUTu34bop6j43bQ25MAeMiDn4VLVYHtCkDbSB+H4d4JjFOZdXdlV0y920dtNgpColi0uaAdrEe+BIY7bzG3VtfDlc8Ae/L5q8GIhp9jT14iNVROzzu8bROCh4uWdu/Fx3SfSsDRro9bXTSFcuW+dlJrStX5iAw3GgNwK5dVVMbtQNj+bQgMWRzZiNh6QrSDt0VFAzJw== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8138cc26-1dbe-4c2f-b7e8-08dbe58a4116 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 03:23:36.6929 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LEJDVhtDAB30mZ5IhIw1UJ5410vdVSwxHlhTj1N+PSF9kvnMzLyswryI7Ai83VdICeGg3XeoTsL9488Lv+h7bQpNRRfIT87tFbzeOGBZP2o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR13MB5719 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found integer handling issues, overflow before widen. Coverity issue: 405352 Fixes: 76ea5ebef08e ("vdpa/nfp: add notify related logic") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vdpa/nfp/nfp_vdpa_core.c b/drivers/vdpa/nfp/nfp_vdpa_core.c index e2a6253ae5..7b877605e4 100644 --- a/drivers/vdpa/nfp/nfp_vdpa_core.c +++ b/drivers/vdpa/nfp/nfp_vdpa_core.c @@ -176,7 +176,7 @@ uint64_t nfp_vdpa_get_queue_notify_offset(struct nfp_vdpa_hw *vdpa_hw __rte_unused, int qid) { - return NFP_VDPA_NOTIFY_ADDR_BASE + (qid * NFP_VDPA_NOTIFY_ADDR_INTERVAL); + return NFP_VDPA_NOTIFY_ADDR_BASE + ((uint64_t)qid * NFP_VDPA_NOTIFY_ADDR_INTERVAL); } /*