From patchwork Tue Nov 14 12:35:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dengdui Huang X-Patchwork-Id: 134342 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA43343329; Tue, 14 Nov 2023 13:38:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0232140E6E; Tue, 14 Nov 2023 13:36:21 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id AE1C1402B7 for ; Tue, 14 Nov 2023 13:35:57 +0100 (CET) Received: from dggpeml500011.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SV5Kd2s3jzmXGg; Tue, 14 Nov 2023 20:32:37 +0800 (CST) Received: from localhost.huawei.com (10.50.165.33) by dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 14 Nov 2023 20:35:56 +0800 From: Dengdui Huang To: CC: , , , , Subject: [PATCH v3 22/42] net/af_xdp: use rte strerror Date: Tue, 14 Nov 2023 20:35:32 +0800 Message-ID: <20231114123552.398072-23-huangdengdui@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20231114123552.398072-1-huangdengdui@huawei.com> References: <20231114082539.1858594-44-huangdengdui@huawei.com> <20231114123552.398072-1-huangdengdui@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500011.china.huawei.com (7.185.36.84) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: stable@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/af_xdp/rte_eth_af_xdp.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 353c8688ec..087b6e33db 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -1165,7 +1165,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals, &rxq->fq, &rxq->cq, &usr_config); if (ret) { AF_XDP_LOG(ERR, "Failed to create umem [%d]: [%s]\n", - errno, strerror(errno)); + errno, rte_strerror(errno)); goto err; } umem->buffer = base_addr; @@ -1367,7 +1367,7 @@ init_uds_sock(struct sockaddr_un *server) if (connect(sock, (struct sockaddr *)server, sizeof(struct sockaddr_un)) < 0) { close(sock); AF_XDP_LOG(ERR, "Error connecting stream socket errno = [%d]: [%s]\n", - errno, strerror(errno)); + errno, rte_strerror(errno)); return -1; } @@ -1451,7 +1451,7 @@ read_msg(int sock, char *response, struct sockaddr_un *s, int *fd) return 0; if (msglen < 0) { - AF_XDP_LOG(ERR, "recvmsg failed, %s\n", strerror(errno)); + AF_XDP_LOG(ERR, "recvmsg failed, %s\n", rte_strerror(errno)); return -1; } @@ -1486,7 +1486,7 @@ make_request_cni(int sock, struct sockaddr_un *server, char *request, rval = send_msg(sock, request, req_fd); if (rval < 0) { - AF_XDP_LOG(ERR, "Write error %s\n", strerror(errno)); + AF_XDP_LOG(ERR, "Write error %s\n", rte_strerror(errno)); return -1; } @@ -1970,7 +1970,7 @@ parse_prog_arg(const char *key __rte_unused, if (access(value, F_OK) != 0) { AF_XDP_LOG(ERR, "Error accessing %s: %s\n", - value, strerror(errno)); + value, rte_strerror(errno)); return -EINVAL; } @@ -2421,7 +2421,7 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev) ret = rte_mp_action_register(ETH_AF_XDP_MP_KEY, afxdp_mp_send_fds); if (ret < 0 && rte_errno != ENOTSUP) { AF_XDP_LOG(ERR, "%s: Failed to register multi-process IPC callback: %s\n", - name, strerror(rte_errno)); + name, rte_strerror(rte_errno)); return -1; } }