diff mbox series

[v2,06/43] pdump: use rte strerror

Message ID	20231114112407.3496460-7-huangdengdui@huawei.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Dengdui Huang <huangdengdui@huawei.com> To: <dev@dpdk.org> CC: <ferruh.yigit@amd.com>, <stephen@networkplumber.org>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com> Subject: [PATCH v2 06/43] pdump: use rte strerror Date: Tue, 14 Nov 2023 19:23:30 +0800 Message-ID: <20231114112407.3496460-7-huangdengdui@huawei.com> In-Reply-To: <20231114112407.3496460-1-huangdengdui@huawei.com> References: <20231114082539.1858594-44-huangdengdui@huawei.com> <20231114112407.3496460-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace strerror \| [v2,00/43] replace strerror [v2,01/43] devtools: forbid use of strerror [v2,02/43] eal: use rte strerror [v2,03/43] eventdev: use rte strerror [v2,04/43] latency: use rte strerror [v2,05/43] node: use rte strerror [v2,06/43] pdump: use rte strerror [v2,07/43] power: use rte strerror [v2,08/43] telemetry: replace strerror [v2,09/43] vhost: use rte strerror [v2,10/43] bpf: use rte strerror [v2,11/43] bus/cdx: use rte strerror [v2,12/43] bus/dpaa: use rte strerror [v2,13/43] bus/fslmc: use rte strerror [v2,14/43] bus/pci: use rte strerror [v2,15/43] bus/vdev: use rte strerror [v2,16/43] bus/vmbus: use rte strerror [v2,17/43] common/cnxk: use rte strerror [v2,18/43] common/mlx5: use rte strerror [v2,19/43] crypto/caam_jr: use rte strerror [v2,20/43] dma/idxd: use rte strerror [v2,21/43] net/af_packet: use rte strerror [v2,22/43] net/bnxt: use rte strerror [v2,23/43] net/af_xdp: use rte strerror [v2,24/43] net/bonding: use rte strerror [v2,25/43] net/dpaa: use rte strerror [v2,26/43] net/dpaa2: use rte strerror [v2,27/43] net/enetfec: use rte strerror [v2,28/43] net/failsafe: use rte strerror [v2,29/43] net/i40e: use rte strerror [v2,30/43] net/ice: use rte strerror [v2,31/43] net/ixgbe: use rte strerror [v2,32/43] net/memif: use rte strerror [v2,33/43] net/mlx4: use rte strerror [v2,34/43] net/mlx5: use rte strerror [v2,35/43] net/qede: use rte strerror [v2,36/43] net/sfc: use rte strerror [v2,37/43] net/tap: use rte strerror [v2,38/43] net/vhost: use rte strerror [v2,39/43] net/virtio: use rte strerror [v2,40/43] raw/ifpga: use rte strerror [v2,41/43] vdpa/ifc: use rte strerror [v2,42/43] vdpa/mlx5: use rte strerror [v2,43/43] vdpa/sfc: use rte strerror

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

huangdengdui Nov. 14, 2023, 11:23 a.m. UTC

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: stable@dpdk.org

Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
---
 lib/pdump/rte_pdump.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff mbox series

Patch

diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c
index 80b90c6f7d..7b7b87bbd1 100644
--- a/lib/pdump/rte_pdump.c
+++ b/lib/pdump/rte_pdump.c
@@ -340,7 +340,7 @@  set_pdump_rxtx_cbs(const struct pdump_request *p)
 		if (ret != 0) {
 			PDUMP_LOG(ERR,
 				"Error during getting device (port %u) info: %s\n",
-				port, strerror(-ret));
+				port, rte_strerror(-ret));
 			return ret;
 		}
 
@@ -410,7 +410,7 @@  pdump_server(const struct rte_mp_msg *mp_msg, const void *peer)
 	mp_resp.num_fds = 0;
 	if (rte_mp_reply(&mp_resp, peer) < 0) {
 		PDUMP_LOG(ERR, "failed to send to client:%s\n",
-			  strerror(rte_errno));
+			  rte_strerror(rte_errno));
 		return -1;
 	}
 
@@ -741,7 +741,7 @@  rte_pdump_stats(uint16_t port, struct rte_pdump_stats *stats)
 	if (ret != 0) {
 		PDUMP_LOG(ERR,
 			  "Error during getting device (port %u) info: %s\n",
-			  port, strerror(-ret));
+			  port, rte_strerror(-ret));
 		return ret;
 	}