diff mbox series

[20/43] dma/idxd: use rte strerror

Message ID	20231114082539.1858594-21-huangdengdui@huawei.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Dengdui Huang <huangdengdui@huawei.com> To: <dev@dpdk.org> CC: <ferruh.yigit@amd.com>, <stephen@networkplumber.org>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com> Subject: [PATCH 20/43] dma/idxd: use rte strerror Date: Tue, 14 Nov 2023 16:25:16 +0800 Message-ID: <20231114082539.1858594-21-huangdengdui@huawei.com> In-Reply-To: <20231114082539.1858594-1-huangdengdui@huawei.com> References: <20231114082539.1858594-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace strerror \| [00/43] replace strerror [01/43] devtools: forbid use of strerror [02/43] eal: use rte strerror [03/43] eventdev: use rte strerror [04/43] latency: use rte strerror [05/43] node: use rte strerror [06/43] pdump: use rte strerror [07/43] power: use rte strerror [08/43] telemetry: replace strerror [09/43] vhost: use rte strerror [10/43] bpf: use rte strerror [11/43] bus/cdx: use rte strerror [12/43] bus/dpaa: use rte strerror [13/43] bus/fslmc: use rte strerror [14/43] bus/pci: use rte strerror [15/43] bus/vdev: use rte strerror [16/43] bus/vmbus: use rte strerror [17/43] common/cnxk: use rte strerror [18/43] common/mlx5: use rte strerror [19/43] crypto/caam_jr: use rte strerror [20/43] dma/idxd: use rte strerror [21/43] net/af_packet: use rte strerror [22/43] net/bnxt: use rte strerror [23/43] net/af_xdp: use rte strerror [24/43] net/bonding: use rte strerror [25/43] net/dpaa: use rte strerror [26/43] net/dpaa2: use rte strerror [27/43] net/enetfec: use rte strerror [28/43] net/failsafe: use rte strerror [29/43] net/i40e: use rte strerror [30/43] net/ice: use rte strerror [31/43] net/ixgbe: use rte strerror [32/43] net/memif: use rte strerror [33/43] net/mlx4: use rte strerror [34/43] net/mlx5: use rte strerror [35/43] net/qede: use rte strerror [36/43] net/sfc: use rte strerror [37/43] net/tap: use rte strerror [38/43] net/vhost: use rte strerror [39/43] net/virtio: use rte strerror [40/43] raw/ifpga: use rte strerror [41/43] vdpa/ifc: use rte strerror [42/43] vdpa/mlx5: use rte strerror [43/43] vdpa/sfc: use rte strerror

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

huangdengdui Nov. 14, 2023, 8:25 a.m. UTC

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: stable@dpdk.org

Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
---
 drivers/dma/idxd/idxd_bus.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff mbox series

Patch

diff --git a/drivers/dma/idxd/idxd_bus.c b/drivers/dma/idxd/idxd_bus.c
index 3b2d4c2b65..a230976c98 100644
--- a/drivers/dma/idxd/idxd_bus.c
+++ b/drivers/dma/idxd/idxd_bus.c
@@ -145,7 +145,7 @@  read_wq_string(struct rte_dsa_device *dev, const char *filename,
 	fd = open(sysfs_node, O_RDONLY);
 	if (fd < 0) {
 		IDXD_PMD_ERR("%s(): opening file '%s' failed: %s",
-				__func__, sysfs_node, strerror(errno));
+				__func__, sysfs_node, rte_strerror(errno));
 		return -1;
 	}
 
@@ -153,7 +153,7 @@  read_wq_string(struct rte_dsa_device *dev, const char *filename,
 	close(fd);
 	if (len < 0) {
 		IDXD_PMD_ERR("%s(): error reading file '%s': %s",
-				__func__, sysfs_node, strerror(errno));
+				__func__, sysfs_node, rte_strerror(errno));
 		return -1;
 	}
 	value[len] = '\0';
@@ -173,13 +173,13 @@  read_wq_int(struct rte_dsa_device *dev, const char *filename,
 	f = fopen(sysfs_node, "r");
 	if (f == NULL) {
 		IDXD_PMD_ERR("%s(): opening file '%s' failed: %s",
-				__func__, sysfs_node, strerror(errno));
+				__func__, sysfs_node, rte_strerror(errno));
 		return -1;
 	}
 
 	if (fscanf(f, "%d", value) != 1) {
 		IDXD_PMD_ERR("%s(): error reading file '%s': %s",
-				__func__, sysfs_node, strerror(errno));
+				__func__, sysfs_node, rte_strerror(errno));
 		ret = -1;
 	}
 
@@ -200,13 +200,13 @@  read_device_int(struct rte_dsa_device *dev, const char *filename,
 	f = fopen(sysfs_node, "r");
 	if (f == NULL) {
 		IDXD_PMD_ERR("%s(): opening file '%s' failed: %s",
-				__func__, sysfs_node, strerror(errno));
+				__func__, sysfs_node, rte_strerror(errno));
 		return -1;
 	}
 
 	if (fscanf(f, "%d", value) != 1) {
 		IDXD_PMD_ERR("%s(): error reading file '%s': %s",
-				__func__, sysfs_node, strerror(errno));
+				__func__, sysfs_node, rte_strerror(errno));
 		ret = -1;
 	}
 
@@ -317,7 +317,7 @@  dsa_scan(void)
 		if (errno == ENOENT)
 			return 0; /* no bus, return without error */
 		IDXD_PMD_ERR("%s(): opendir '%s' failed: %s",
-				__func__, path, strerror(errno));
+				__func__, path, rte_strerror(errno));
 		return -1;
 	}