From patchwork Tue Nov 7 15:08:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiawei Wang X-Patchwork-Id: 133939 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28E79432C8; Tue, 7 Nov 2023 16:09:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF8B7402DD; Tue, 7 Nov 2023 16:09:10 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2049.outbound.protection.outlook.com [40.107.93.49]) by mails.dpdk.org (Postfix) with ESMTP id 5F98B402A1; Tue, 7 Nov 2023 16:09:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m0jAix5vcXgC4iitz0jjsQt+C6lpE18tVfSXB1uPgp8fslWnUnhnttgn76DKseYdy3Xtfkr6nS56PZpcKC/cdcZk+2MSpkt2TwS9UF+L5fPATdcwxEkEYx2hYQBblDzJzmFVu65XSKvjUz0xl1a9Cs0eQLf7f3lUgghW1H6wK2HUqRO9lx91QXObSn4/+vlrCxxcU4ygdpyYe1aRQH3jZrXCbw0ecFNin5g9jFH2z3nbh5OmvjLelAILU8tmlS9ygZmYUyyrPIgghMaw6XIVvNsg8PIzbjvkeF+L1B2CUYRz4I8A4Jde9CkZ4ymPILKpi8yOSBfjvUZDQwIwDbV5Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RDSsNNJmC1yy0VZf7cFDs7uHlYSNIHrSv6yrn9HP3iY=; b=esbcLGZY+q1736+JwyfRnfQZJ/VRpTgeRuPr6nC3kX+EFghFhPzYGH7MafvY9wjs2jCd5EqJuwkqTk5IE68JWWE/h5SgobBeLSVk6bNh44N+eB2kNPNPZwY2PvTSNEf41H7Iy1u3tD3pCiAhGAsycGIreVZ51QGs6v62JbtxkHoIdpC+ge0xVZiyEtjgTt1v4qRXZh6tFMMVKMV1drXaqZ8WaZYh+HTZ2le1cIJ/j8bns19mcj25MK+Zze+0JAEN5jR1cX6eWPuAqoH94eymf5AEmjcpoRp5Y4+V1ft2bG3B30dYAg9rw46Yvbd9uxPEP7eq/o/Di3UbJpbQfqWB5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RDSsNNJmC1yy0VZf7cFDs7uHlYSNIHrSv6yrn9HP3iY=; b=IDVBoAUahut2zUgiG5A590zdlS/dHAaeydjQrl/32bzODcyN1+aJE3J+J5noYcK1qBBeIB7an3DCwJcoZPsPX17WyJQHZbolhLj1bHROStAKb2mblIWz3NhMqjFKZPrUJ1fAFpX9Uhn+TXkkDV90i97YPdWmmkzOhezmOqwJU+AyhCRRXGU8jyWfz1tyEw48g2xpANv6eYt6FYWYJX1tsHPSwc6Oa+Ih9m4G7lq0R0oHO+qwvt0fl6EnZO3SPuoY/HPJUjqfExRcYE/DyQrYfiALEDgajyZfSqXg71JZ3GDNq9hrzwOQbmm6cIlSb3Q26RqYIf+DQRUfjA/CYoeODQ== Received: from CYZPR14CA0003.namprd14.prod.outlook.com (2603:10b6:930:8f::16) by BN9PR12MB5180.namprd12.prod.outlook.com (2603:10b6:408:11d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.29; Tue, 7 Nov 2023 15:09:05 +0000 Received: from CY4PEPF0000EE35.namprd05.prod.outlook.com (2603:10b6:930:8f:cafe::5b) by CYZPR14CA0003.outlook.office365.com (2603:10b6:930:8f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.29 via Frontend Transport; Tue, 7 Nov 2023 15:09:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EE35.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.16 via Frontend Transport; Tue, 7 Nov 2023 15:09:04 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 7 Nov 2023 07:08:54 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 7 Nov 2023 07:08:51 -0800 From: Jiawei Wang To: , , Matan Azrad , Ori Kam CC: , , Subject: [PATCH] net/mlx5: fix the validation of the sample encap action Date: Tue, 7 Nov 2023 17:08:20 +0200 Message-ID: <20231107150820.30805-1-jiaweiw@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE35:EE_|BN9PR12MB5180:EE_ X-MS-Office365-Filtering-Correlation-Id: 94caa53e-1c29-4ac3-875b-08dbdfa37b9b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6QqenCqB5VS8D7j6XTelNSL7nAi19YI1nfz2uUsVlYyUfzfIGHCc38vLYLVOAiJTilnvUGTSWSFLVM81YQsx4u1sps3xDpFx1oXeJL1q0rI9ttwN9g46NvWV4smO/Vq6GdgvtkNDv7pxlTX2b2n/n1mnnyUIK8n61E88wsfyxR3/IFt8SxXACnz8WXR2ZlFVji7RHWgx71ssxRixmKXHXHALqKG5/z1ZGwVtPiIdvaxIUmFeduyyRlgTySspUHoG/hF+DMRaAWhAQ8S9rU7DsM5gQuyxPKedCbUSgwDvoUGTeNkqx2jslbGzm6tivfKO0KvPiktz+Z5ng5f3bKZ4h03xiiV876YzVGH/hjTYVNYNHhg9QQ0WfNJRYrmNx5gus0STB4uHxIcVOt2sTG37pjDhkdl6rha0uVqxctfYtwldHvp3fSQPxdhA0ibI+7lVCxZg+Ln10bZiRrU0Ylx0hSGDK+YdEjfi+ddSVQavrIpFXGHgaR2z8XG6P0TNnnkVAtxlBxrn9oHt/hxJm5nSxq4nH2oxQLeO/AUIswa2zjpBlxyglvUyzL6TmtUQ88yrxTo+CKcDs5+9i2nzEdQgitTYG8mc9JmWK/lC/+5PvQX6/rlam9dWPwe7twRgkxl+MIK8QibTmgvY36L4bBniUnPq7QSTUBR4buyxLevHxoEa+OFn+OyFhxulQj06Bw9hkMGUZgJXOhQ8xOr7w+GSzT0AfmjfLBPLxG6+Kld3m30eb6X4tp8BBnWjrG6lx/OF X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(376002)(396003)(39860400002)(136003)(230922051799003)(64100799003)(82310400011)(186009)(451199024)(1800799009)(46966006)(36840700001)(40470700004)(55016003)(40480700001)(1076003)(2616005)(40460700003)(47076005)(7696005)(6666004)(36860700001)(36756003)(478600001)(86362001)(2906002)(336012)(426003)(41300700001)(8936002)(8676002)(4326008)(450100002)(5660300002)(6636002)(316002)(356005)(54906003)(7636003)(83380400001)(26005)(16526019)(6286002)(110136005)(70206006)(70586007)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2023 15:09:04.8416 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94caa53e-1c29-4ac3-875b-08dbdfa37b9b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE35.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5180 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The flow sample/mirror action includes sub-actions for the duplicated packet. In SW steering case, dv_flow_en=1, there is a FW limitation that forces configuring also encap action when port action for the wire port is configured in the duplicated packet's sub-actions. The driver did a wrong validation for the above limitation and forced other actions instead of encap for the wire port. Force only encap action in case of wire port. This patch fixes the wrongly checking for the sample encap action. Fixes: a8697f50f50f ("net/mlx5: fix E-Switch mirror flow rule validation") Cc: stable@dpdk.org Signed-off-by: Jiawei Wang Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 154e509707..9753af2cb1 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -8721,7 +8721,7 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr, RTE_FLOW_ERROR_TYPE_ACTION, NULL, "mirror to rep port with encap is not supported"); } else { - if ((sub_action_flags & ~MLX5_FLOW_ACTION_ENCAP) && + if (!(sub_action_flags & MLX5_FLOW_ACTION_ENCAP) && (action_flags & MLX5_FLOW_ACTION_JUMP)) return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, NULL,