From patchwork Thu Nov 2 04:43:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kaiwen Deng X-Patchwork-Id: 133765 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0173B43269; Thu, 2 Nov 2023 06:22:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9309402C6; Thu, 2 Nov 2023 06:22:50 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id EF8A6402C3; Thu, 2 Nov 2023 06:22:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698902569; x=1730438569; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=95skBtWuodgZDgezIabssm1IxysSZlma/JVFxL2s6rA=; b=RgPjR03P6om5KTt3qJfq+XewdhcvBqoEo2o/PYVeYSFmPTxdpV/Y0x0L lnPVYYHWmAB7Wweaho6k2IbqOmgJq6ZTPqZfy4SsvO1hax3ByeTmQZ3Cm 8AZ/X3N7+IW2HX8d5WTXlu270cmzLIe/Zg7rUwV4dCndEbARQJz2cl4+h RShpVBpplDJ9a/aSagv8gRwHCq4pzJ2NEN2jgbxA+zNG8hWm0Gm0hsHQ5 y9xXxb/Wem4MQ1oZ1++Iz5nBQ4032CG+XcHlaaRgW7Ula2PaP2rvkfDyF vjkqRNaLhDFrUUEOS8UWLzRCInZ8B6G1Fz9sLA6BlhixfixudLNNoAm/1 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="7277028" X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="7277028" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 22:22:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="8879135" Received: from shwdenpg561.ccr.corp.intel.com (HELO dpdk..) ([10.239.252.3]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 22:22:45 -0700 From: Kaiwen Deng To: dev@dpdk.org Cc: stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, Kaiwen Deng , Jingjing Wu , Beilei Xing , Zhichao Zeng Subject: [PATCH v3] net/iavf: fix mbuf release API selection Date: Thu, 2 Nov 2023 12:43:16 +0800 Message-Id: <20231102044316.541458-1-kaiwenx.deng@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231101013433.534399-1-kaiwenx.deng@intel.com> References: <20231101013433.534399-1-kaiwenx.deng@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When AVX2 is forcibly selected and outer checksum offload is configured, the basic Tx path will be selected. Also, the txq mbuf release API is incorrectly set to iavf_tx_queue_release_mbufs_sse. This causes coredump. This commit selects release_txq_mbufs to releasing txq mbufs when selecting the basic Tx path. Fixes: 22f1e7608ebc ("net/iavf: fix AVX2 Tx selection") Cc: stable@dpdk.org Signed-off-by: Kaiwen Deng --- drivers/net/iavf/iavf_rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 610912f635..a16e03d88c 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -4022,6 +4022,7 @@ iavf_set_tx_function(struct rte_eth_dev *dev) PMD_DRV_LOG(DEBUG, "AVX2 does not support outer checksum offload, using Basic Tx (port %d).", dev->data->port_id); + return; } else { dev->tx_pkt_burst = iavf_xmit_pkts_vec_avx2_offload; dev->tx_pkt_prepare = iavf_prep_pkts;