From patchwork Thu Nov 2 02:23:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 133750 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5296343267; Thu, 2 Nov 2023 03:24:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BCCF42E64; Thu, 2 Nov 2023 03:23:52 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2104.outbound.protection.outlook.com [40.107.96.104]) by mails.dpdk.org (Postfix) with ESMTP id D470442E56; Thu, 2 Nov 2023 03:23:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jsK9Va+hYkiHLbUSVpDbDfwQ/RgZLS4yrFw/TDbFGG8DAAW8Kz5eOr9z0Sqc1i3UYb3d7NLr0GdrJ05AUOQXxGZ/lE7R4dAS20iM8XUKgOJx4YsEqTgKHm4/q/b+PKvEMHMJKNjTSk4Nu+8j9rwQBpQ6ww5HYD/AZ9wipwIx0GplcUZI50IbwpnT6WXDPc9XoNcpcqtjJEtPkuY2tII8Bkj3xB/c6K7CHkQEAr+N864tTPfA0fpst2SYQ9IrTfmd0MdEQgiq1ZxEvkY0o7LlqH31iiu9et2ydGKDYVFA7zxYTP50/+lCSnwSDV2WMn/wMsR3Wbv0FvWdhjUTK5VY3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8YA8uvoCckGeZRn1hFw8JgisRq29i5SAV2Q43A2IwfY=; b=WovqybHcdYzmX3lBQrQcdmLmqtcc+uyhNebODbPP+mJjZwcDc5wSsbE/8f+faJIwfwr7fuCiV/RETn+eZr+usOnkw+SUby4N0xWKFlUqevzfxFKM5dDDJxX6iqz8hLKAVD12c8r+Eep5/e76lmUkT1tq/wXQWp2rtofV/Tr4btkJkOfup/Jf/lQzw1mV7MI9SIymmXRKcXexui18/xqOxgjijhuPRhBaaoMUda9bSb5v2HDIm/osbnhp3bOkeJWAJZLc+lEiu/brUsjQ9ibqWOjeph5La+aQnYOGDC9zUZMQg037W5O1jH49Igw4D2XPmaesVhfU8bnXVmATU/EERA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8YA8uvoCckGeZRn1hFw8JgisRq29i5SAV2Q43A2IwfY=; b=oEb7xpSNs1TAgvJXp4WEfdYkJFFzRri4sE2S7JHT6hVx5wREBTYMeIA2CnSwNhfzxcP/U6OzFE2d2ChrTnHX4GezmLJauNbgkhg6y2rIKV3wzW/vFR4HAevZFHbw9321NQ2w2N4X8CCUta48JRhcKsGStYUhyGVRg/2yyBrFqhE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB4455.namprd13.prod.outlook.com (2603:10b6:a03:1d4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Thu, 2 Nov 2023 02:23:49 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6933.027; Thu, 2 Nov 2023 02:23:49 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Shihong Wang , stable@dpdk.org, Peng Zhang , Chaoyong He Subject: [PATCH 03/11] net/nfp: fix the DMA error caused by app exit abnormally Date: Thu, 2 Nov 2023 10:23:13 +0800 Message-Id: <20231102022321.2254224-4-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231102022321.2254224-1-chaoyong.he@corigine.com> References: <20231102022321.2254224-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BY5PR20CA0030.namprd20.prod.outlook.com (2603:10b6:a03:1f4::43) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BY5PR13MB4455:EE_ X-MS-Office365-Filtering-Correlation-Id: 3cdc69ea-9fde-4d78-8303-08dbdb4abf72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xNL7WQ8TlIQWxdoco8JJ7RCWmTLYoiYt0sjUg1Utx95z4yhuuNfHLBD+hB1BYbcsjNebucki6Rfj78wI9fwUWqchwdgt0u0bpqr/Ss3M5BdzoU19yZxhz+/8KsWpgEc4fYZjyTFOADT/wHwjBfVzxLTBzQVy/RLz9BTIrV8JZ8zaqO9U5tY58lPZfkCT6SWKudjYyvuxzysUs/wuRC5ET2bDX1TD0TGpqq+BD4q9jPrXGXXlfUBTIx1bUh2mJStqyVsqytUKNgLu/nHfMDA6UeVUWTFraAqggawm35lwPxqI/COhjDXxDtXxl9vxAa+skHon2UMBYhv9VB6gxXejQBbfYUYvI7SfwPwEfs+1lwCdgCfHfHTfPaCJCn9Y/bcCkJBZG2eiG+tndK2/wQEFaZAwX8cEZh3eqsogZ3JFZkxnJ+gUvcpqMrl4vcgHi3w0VOCAyclCqblManTVgwZx2b3jTIWxkV0yYKEhpDeISKpR7hPZYayFMwvp2NUZWOP5zpbz+D9/rrcIX8YPuYGm4jtlJb8yQQtnWTBaMDeavJsnSmxSfQ3gMv1CFdzfzKMmgrrh738Xa1WJktvQBsUCyX/7ckqzCyAkL/sfUUxuWwCCJSEt0LwdcSCNZNsv/H363zWRwG+ayUmYfDGspNNZ3XT5eLMAea/l/z490DovGlk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(136003)(39830400003)(376002)(366004)(230922051799003)(451199024)(1800799009)(64100799003)(186009)(2906002)(8936002)(4326008)(8676002)(44832011)(450100002)(6666004)(41300700001)(6486002)(478600001)(66556008)(316002)(66476007)(6916009)(54906003)(5660300002)(66946007)(6506007)(52116002)(107886003)(1076003)(26005)(2616005)(38350700005)(6512007)(36756003)(86362001)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wrvYfvueiUqnWl1HWwVYcnh3vYeDPNbJnQA7vab+Q9aiZy4myJhmV/Q04fIm82awhkvrN5Tsqi7YKiDnxDaB7A0WqcdQEmRvxGRJvEqYCxpj+A4xlLZGl1ZNG7QKtolZ3lZHVkasPTY3srKrKjAw8vO1rAIimOb8S5M8NrqIOTHwnTWXs7S1U6zbyT8h/MrkjhZQ7rf1Qsdbivgda4hui5jhWlDoJX+hk1Ab2cW5etlcnzE5bSUeIXXJTzfxGiHPweOWS3c2U4DppqTsbiGhcQGudXbYBGgOBulfCGu5FgvC9JJvz0oshVtde0OVXGcEp4pEqTfoAT0x5I9cdLMd3Wa8X1W653sU52ln1eQpod+h52mRRRPcIlmLOYuaQ8EHMbk1nPTNQWc1B9nvr7S/icLQ30LKN9cLLje2q5kwP45Zy6OxzmAkO5duYsuyYdejGIvDC9WiXRwT1jR8ezlVxSXBshTIo51dDwAWkDUO2TkDoGF2gHGOpUpJAYeWCfOeENPvB+/aRrXjVIvOHz9qRbqdrj85hD0ZrnJGxF6uS/s5JPC1XSvRbjE4jWho3KKjTsITuhf7VirsWl5GJJoGurSty9v6+AuZhrgqPSrEcEj3yTPoFeaBG+trbByV8njlqnm+fambFY+kGUmldr7ZR9bT7hcnT7w69hrJbY+w3ZbPFtfklwTEBWVOzwOpU8J8ezc2vIaDvCEtjFCgQ9G+PuHBJFXI5VzDPHn/WE4fSY4u0UflvtJHu8d9CMxUUOtyf3TEj4SmhnuFHqLHwWzCzGkPEEJg2IEaFGq5MDGTRkghpHs+cZcpJcoUG5J5+A4XqDys81fTbE3lGAMRQ2jTVbjpmJ4OWO/v+hckcrsV2mTRMW+iGCnl1Al0lWcWvOqHz0jnX4KhkEVeSKEArJk7Cozs4NuP+gBetAu4YxRiqntdCvjNvCcbQjbsxQ/oYq3oSu7N8EOJgd5ge6nOWwPr6MZx7CJ7YTiIrUUQrMMtpKqo0f5n1uK6bMtt02K+CT6nGBTT6i7o3GccejNNs663vLsRMGJQQrAbgEWzjMxT98UaTYIPEMJGENFf9ATqJnqlNeYhQE9u2dUs1AUSB+kPy/3bsRnEF1gOBD/LNSz2WYb+/59oROze7pIskBL1dlkcWiT4QCJjV4/rgflTLRe2z2GcZg0M20YLjx6dJ/8g9Dg2TnRbpSd7DujoGctJmdCvvAaHRLVUhF2uenX+0DJIUUdotb82anTl84+8cpYma0BJbZ556BdgpnIoezmD1KjBK8w0cA3fRqP0zYJJEfPGcEvQOEtcic5TRR7Hc+stDaESfxswweThpxTBhZYkn4q6aEA7/yGFt8DVp8YZgZKayZK8cDE2yT20EdlwrnSNDlwHSyPCDdhDgChWDoumATjPL9gkCRmHUtEKhLaDn3KEGOKAj/oh5g1murwh1f6ONPTTp7gYuIQQpWCrii4/g29y06zeQS/NIb0348FAcThhns2lVWvo/i6cvrny/hFHFJFuory69HgvGg/T85b0TeHlYV2ki7twiIfp5OFiDPKJv4TNGd/10cxV/9vgEVFAJom6v1oaCNUi16423T8AMFOJq3vIS6/h6h16Fo6briMfKw== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3cdc69ea-9fde-4d78-8303-08dbdb4abf72 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 02:23:49.2163 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t8FZ36DN1U2XMv3FXyR+BBLMjOCxg1/JASzFw5A6Zk2Ejhq0T8MvOQWz0JbdGmI6GctElzdt0wkHB52kkh0kK/WMF7Qs87VagF4/jddb034= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB4455 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Shihong Wang When DPDK application exit abnormally, there might have DMA error, and which will cause the load of firmware failed. Fix this by force the physical port down to clear the possible DMA error. Fixes: 896c265ef954 ("net/nfp: use new CPP interface") Cc: stable@dpdk.org Signed-off-by: Shihong Wang Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index abaf31e27b..aa2b59af32 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -847,6 +847,7 @@ nfp_init_app_fw_nic(struct nfp_pf_dev *pf_dev, static int nfp_pf_init(struct rte_pci_device *pci_dev) { + uint32_t i; int ret = 0; uint64_t addr; uint32_t cpp_id; @@ -905,6 +906,10 @@ nfp_pf_init(struct rte_pci_device *pci_dev) goto hwinfo_cleanup; } + /* Force the physical port down to clear the possible DMA error */ + for (i = 0; i < nfp_eth_table->count; i++) + nfp_eth_set_configured(cpp, nfp_eth_table->ports[i].index, 0); + if (nfp_fw_setup(pci_dev, cpp, nfp_eth_table, hwinfo) != 0) { PMD_INIT_LOG(ERR, "Error when uploading firmware"); ret = -EIO;