From patchwork Mon Oct 30 02:28:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suanming Mou X-Patchwork-Id: 133620 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B1374322C; Mon, 30 Oct 2023 03:29:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4278B40698; Mon, 30 Oct 2023 03:29:17 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2084.outbound.protection.outlook.com [40.107.94.84]) by mails.dpdk.org (Postfix) with ESMTP id BF1454067C for ; Mon, 30 Oct 2023 03:29:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NGozT1jVy5sASE5Ch+dovx748jMdfhnEg6HZliSxGQtyvUqvgu7065vlC7oOMjlf2u1XooEzZYW/5xNaupU+xM/aAKsRix2ZP0Xk4QDl5KVPz267Jb/Ciq/w3lNrjxocjARkzlYWqN5oJKlfb0aGvW1SjMFRDIOuyU5udlibMB+DchGubsoc3GKIjVkdHSWBXLm2vgAaTKxnPWHXcYGz6pCnCLdgJsoUd14lT8Rog6c18Mbqnj8b/f3ZoooUupAppRMo60tmEHul+ywzhXqMTS4zYn/snzIbzHIOP35opw5gAbuXfiOZoWxcJjgcPWsj2/BEhN+xs6BDAyImbbm4nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+yRr1FDSygXjQbHcmTae+ySjXb23EDDEiT44JPanNYQ=; b=azFoRlNdUCZtNDihmDUF4Sx0p4OflPeBdGbpxnyeiLe7p3EnhOYsyBgSGPMF2GeMtduFGew7nE8ZODEyWofswchmVdz07EP7tj9ZXsL7CHYDJXogvZOkF2VEgMau59NJ2PI/xOB+cfyBdB07YMAw0nh65FVQZ2ZFwFCjbqnLCEMCb7AC77xaysdjpwY/jsPTc9hK0a6SQ1FsKYcS9zWrwWFydQymJQCs4YeQVFRNTcO0G1nA+rvigPuiht8SaWN5eAt/w7n/tC9Cl9U2BmL388QRUO2aFeQwhMm9W2VmL+8nGTHXgk2tO/lAuR8zxgNF0FgRmfQCrW9XE4YLB00NiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+yRr1FDSygXjQbHcmTae+ySjXb23EDDEiT44JPanNYQ=; b=beflcRChKk7YSe0yQmfjaNcn+nR1czSEdwpIrEKxG3kdZcim10+576TCuq3DMzt+m+aFTNnzKfl1cQ385PwiBUgzE/E399PfKPWcZOEDL2js8BgqEO2l6mUM8UWzN81KypUJ77iMTkikNLOfngcxU/44f8dbcCMy1Cs7zl7yA+NGNRqmlzu43eBP9EqCnZHh7g4zdU6+zJFwhyJcikA/kgd33Ply6nmB53AfbqZj8y5t9tO0UJGcvKff2eMAdsNUtYXwpUO5yLYlEQvQOsevCdwga1mllytcS8ihX0DkGcjY1bPnkxHxh7D6Ijgu0Ny/4nCZQ2a1NvRaoH9b1jMYJA== Received: from SA9PR13CA0162.namprd13.prod.outlook.com (2603:10b6:806:28::17) by DM6PR12MB5008.namprd12.prod.outlook.com (2603:10b6:5:1b7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.26; Mon, 30 Oct 2023 02:29:12 +0000 Received: from SN1PEPF0002529E.namprd05.prod.outlook.com (2603:10b6:806:28:cafe::a) by SA9PR13CA0162.outlook.office365.com (2603:10b6:806:28::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.15 via Frontend Transport; Mon, 30 Oct 2023 02:29:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF0002529E.mail.protection.outlook.com (10.167.242.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22 via Frontend Transport; Mon, 30 Oct 2023 02:29:12 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 29 Oct 2023 19:28:51 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 29 Oct 2023 19:28:49 -0700 From: Suanming Mou To: Matan Azrad , Viacheslav Ovsiienko , Ori Kam CC: , Subject: [PATCH v2 2/3] net/mlx5: add port representor destination to mirror Date: Mon, 30 Oct 2023 10:28:27 +0800 Message-ID: <20231030022828.973851-3-suanmingm@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231030022828.973851-1-suanmingm@nvidia.com> References: <20231017004401.698745-1-suanmingm@nvidia.com> <20231030022828.973851-1-suanmingm@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002529E:EE_|DM6PR12MB5008:EE_ X-MS-Office365-Filtering-Correlation-Id: 907be84e-3247-4920-a992-08dbd8f000f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OExk4LOvH47gUu7zMqmzurwwyR7CnBrLECqh9ixI8i2fUqZztfofU4jLZyBPGBjQf90aTI9Xfdg2xdCL7mVs3GVowGUCqZ2UolUkogB81izKoB3R93O5iPBRYGWGRtn2PNrYHIh9tUuEmk/QfQmaMYiZnw9uEl6yblrHyijPtTS9q6hMX71ucFWapDlp9lop2jVsKwuyvSdOBO2xjn2G7+uEWOM3cEoqOR6DrPueqDucTAkqsliQrlrCvGwyML9HF0yOsKLGyYkIHP/WPatRhQ3rpV5vnDBTDx1ybpWc+ACy2+tindVuNz5xhbzetLGS0dFLnWkq6cBh1JfZKdxwfqajzJg4QI7Y2mLKatkTjZ91KpjNy257V+p10RzI748CJuKXxM3rAlztoIDkreq+va4Kcy7Bf3KtAFnmaB5A7dDWIYnXwusBgm+VUmOY2Byw6Mm6H2G2SJG3rhTky+eAdy4xa4p6dGSCBF1S2W3/amLigJzVIqWRAOdChUTnhUTDKLGotbI9Yv2mdT5jWWRNxs+jryAUybg5KdmZcp8hCBdfVZxEKNR7xR6+RVklwwpHr58Q96QINu9UK0YyWsSaHXEONXXdvTLKFDZ+WQyMOc5OhOgQZ/exFEiGiPl+rHoGJKIG+Px18//ssWi8Oi465Iix08bCyWf+kgRRe0zRrwnWs007FWQVsh9y0eheA3mAqNN5SWsbX/MkFJ+hwxQwasLNrzVh52NeMJKaYO44bc0= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(396003)(39860400002)(136003)(346002)(230922051799003)(64100799003)(82310400011)(186009)(1800799009)(451199024)(46966006)(36840700001)(40470700004)(7696005)(6666004)(478600001)(83380400001)(47076005)(26005)(6286002)(16526019)(2616005)(107886003)(1076003)(336012)(426003)(2906002)(5660300002)(54906003)(41300700001)(6636002)(316002)(70206006)(110136005)(8936002)(8676002)(4326008)(70586007)(36860700001)(86362001)(36756003)(356005)(7636003)(82740400003)(40480700001)(40460700003)(55016003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 02:29:12.1501 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 907be84e-3247-4920-a992-08dbd8f000f5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002529E.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5008 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In order to clone the traffic from FDB to NIC TIR, user can set port representor action as mirror clone destination. In that case cloned traffic will be moved to E-Switch manager root table, and goes to software TIR. This commit adds the port representor support to mirror action. Signed-off-by: Suanming Mou Acked-by: Ori Kam --- doc/guides/rel_notes/release_23_11.rst | 1 + drivers/net/mlx5/mlx5_flow_hw.c | 19 ++++++++++++++++++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst index a895c6b45e..322d8b1e0e 100644 --- a/doc/guides/rel_notes/release_23_11.rst +++ b/doc/guides/rel_notes/release_23_11.rst @@ -149,6 +149,7 @@ New Features * Added support for Network Service Header (NSH) flow matching. * Added support for ``RTE_FLOW_ACTION_TYPE_INDIRECT_LIST`` flow action. * Added support for ``RTE_FLOW_ITEM_TYPE_PTYPE`` flow item. + * Added support for ``RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR`` flow action and mirror. * **Updated Solarflare net driver.** diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 813a035e77..77f0e4f977 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -9739,6 +9739,7 @@ mlx5_mirror_destroy_clone(struct rte_eth_dev *dev, flow_hw_jump_release(dev, clone->action_ctx); break; case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT: + case RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR: case RTE_FLOW_ACTION_TYPE_RAW_ENCAP: case RTE_FLOW_ACTION_TYPE_RAW_DECAP: case RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP: @@ -9783,6 +9784,7 @@ mlx5_mirror_terminal_action(const struct rte_flow_action *action) case RTE_FLOW_ACTION_TYPE_RSS: case RTE_FLOW_ACTION_TYPE_QUEUE: case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT: + case RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR: return true; default: break; @@ -9796,19 +9798,30 @@ mlx5_mirror_validate_sample_action(struct rte_eth_dev *dev, const struct rte_flow_action *action) { struct mlx5_priv *priv = dev->data->dev_private; + const struct rte_flow_action_ethdev *port = NULL; + bool is_proxy = MLX5_HW_PORT_IS_PROXY(priv); + if (!action) + return false; switch (action->type) { case RTE_FLOW_ACTION_TYPE_QUEUE: case RTE_FLOW_ACTION_TYPE_RSS: if (flow_attr->transfer) return false; break; + case RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR: + if (!is_proxy || !flow_attr->transfer) + return false; + port = action->conf; + if (!port || port->port_id != MLX5_REPRESENTED_PORT_ESW_MGR) + return false; + break; case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT: case RTE_FLOW_ACTION_TYPE_RAW_ENCAP: case RTE_FLOW_ACTION_TYPE_RAW_DECAP: case RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP: case RTE_FLOW_ACTION_TYPE_NVGRE_ENCAP: - if (!priv->sh->esw_mode && !flow_attr->transfer) + if (!is_proxy || !flow_attr->transfer) return false; if (action[0].type == RTE_FLOW_ACTION_TYPE_RAW_DECAP && action[1].type != RTE_FLOW_ACTION_TYPE_RAW_ENCAP) @@ -9966,6 +9979,7 @@ hw_mirror_format_clone(struct rte_eth_dev *dev, struct mlx5dr_action_dest_attr *dest_attr, uint8_t *reformat_buf, struct rte_flow_error *error) { + struct mlx5_priv *priv = dev->data->dev_private; int ret; uint32_t i; bool decap_seen = false; @@ -9992,6 +10006,9 @@ hw_mirror_format_clone(struct rte_eth_dev *dev, if (ret) return ret; break; + case RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR: + dest_attr->dest = priv->hw_def_miss; + break; case RTE_FLOW_ACTION_TYPE_RAW_DECAP: decap_seen = true; break;