From patchwork Sun Oct 8 07:08:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 132401 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B36F41B7C; Sun, 8 Oct 2023 09:08:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 429CA402A8; Sun, 8 Oct 2023 09:08:51 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2137.outbound.protection.outlook.com [40.107.94.137]) by mails.dpdk.org (Postfix) with ESMTP id 7B1DF40263 for ; Sun, 8 Oct 2023 09:08:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XHyuJqjPdCTKwgY57hPaQot00PmL+xSWnk7UmvCQizbKqtw5UVC4CjUN1/EQjzzowW19C8xCwvKJLlRQ4GWWlvOAJgIRIUPnTRoNnPHhzzj3B9jSQ/YH+HbQCfcNn5I3MUltMtCdCQLc+WKZIrYzRO07qxaafJtPuahHmlaltBpOwXU2/chI2O5NryBT9xSAdnfIsJx9jerBFKp7SpwTvzkfyDAr4fQ+PkW1SHjKARiBqLXVK2EN9Hue8nCWGrtFVNTZQCfr7JWHoo9VxcASxnjbQMrMaTxqDAJrocePdSVReZ2XiRdID6OZ9eh57rGGE8iq9LJr3TL+RI4QmoUMMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/8nDg+btPKrdkR1m6cn1A0PYVPIlGi+6GVrYtJiT0Ew=; b=N7BQc+yweG3q2BMISV54GuMuuEKwkUIi+TH+6xVA1n/MMEIg7gv6FUcWYMUOJKZZuepoXmcgoWkScy6dF6dNew/CbOftuIn/G3h7aQOK5jLwUtUs9DgZkXSYYvpdyZG94NGTTkScLNTmyMt1d+F6Wlv7nJEtoWAzhUVCjwQ3txAwokBM4ppurQglu3tuaQEcITxAIoQvgBOkplNctgkV9CfnP9bDT3J7kVAh0P3A4TzELavyZKyaBHvg7w4JNWKUQMyxOjsjJdAv3lV7yzBX28TzD9AW07Qio0mrCAVjHF1jKZA7HqE8IP+bD9I5u9wIT0TuF1lPLb95VDVJcCHQtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/8nDg+btPKrdkR1m6cn1A0PYVPIlGi+6GVrYtJiT0Ew=; b=EwNv1mWl/SEX1zDln739WscBgBrOQKhsWOJSg8bkYMP8Gm4BAJ4a2xlKLBYjHeT/QHGS5Q44VQKTvww9p62vWjxAO/oxV/VIsZlmzsxk2rvbIunkXKx/SUztEduEmPZIlMhGdrbr2WfmCPVCTUcSaxHbPu2jHuiPmDH86XAwX8U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DM8PR13MB5094.namprd13.prod.outlook.com (2603:10b6:8:21::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.43; Sun, 8 Oct 2023 07:08:47 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::28c0:63e2:ecd1:9314]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::28c0:63e2:ecd1:9314%4]) with mapi id 15.20.6813.027; Sun, 8 Oct 2023 07:08:46 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He Subject: [PATCH] net/nfp: fix one memory access problem Date: Sun, 8 Oct 2023 15:08:09 +0800 Message-Id: <20231008070809.1582669-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 X-ClientProxiedBy: SJ0PR03CA0039.namprd03.prod.outlook.com (2603:10b6:a03:33e::14) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|DM8PR13MB5094:EE_ X-MS-Office365-Filtering-Correlation-Id: 47608938-aa44-4dab-ce2c-08dbc7cd69e5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IBlObV5rGhnOf3toTNrALwzJVmNbi9CRPImocpUuvlpZLMe7awzs9yAU4IhAMyq6SbXHaNWjFQI/YeQ1Z+poUbqPFT3wRLD5mjrze+5XVNzmY0cq41eKWta04gjVxoIKUBJBxOWlpo0Qhw8c0avXvSftFRHkK6G6wcD6Zg0zJNzqaRuCzPtnaAH9/EJUaRLeyEp+1UGf+keIqZMXytop+WEoWas0zqMBR2zSYHO/YSBEXLeA5LZlypBsQjytympK5M54HaqunqwtHHhUyJ8TUqZCEQDLp5Mu1CRtY9IjGbNOF5aJc92moar6Qb2aX3ssQLeVYHoC3cOIfUXfCYx9fGnekQybsxyWCbkL+U36uQ5bVcnOm3RRXjpap/e/TgWcNXzk1Dce/YB9X9GhtEs0r0RDskDj0oqeQaxjvxiXGyzztMDPzBi8yexIr6IX3kanoWMFcyWWygOnwr67Irm48s/9VR7VrHfOL8t2AOQzFfYd4OqSr55a7Ylc4KEDzSOrhW4G9L+OaBmysQrLkNQoLUK4oiuxbe4Hkxfa4XT/RCx9EEv2oJbZFnlRU6GIleerknk403jQP6mzYpyOM8TT4/lzw0RMO0qpbkqpP+/WFhBcb4TjTNcu/jKJmTd0IThpYaD7t+BiJ1vmwcbP1MKRQasHF35mSWlailGhomFRDe8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(366004)(39830400003)(136003)(376002)(230922051799003)(64100799003)(186009)(1800799009)(451199024)(38350700002)(38100700002)(52116002)(6666004)(6512007)(6506007)(6486002)(36756003)(8676002)(8936002)(5660300002)(478600001)(107886003)(26005)(1076003)(2616005)(83380400001)(86362001)(2906002)(66556008)(66946007)(66476007)(44832011)(6916009)(4326008)(316002)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VLqdkTsVTYblJYkfvye7nFCyEACKN+3lGJ6mSK9nPwBBpHusBTC9kyOMq+oacUr1aPUgzvHHBIAW1UV8D6tNLSW0MFaBVOyjCs5x7uTyUVNKkf8ZwP2MC/GxOL+YxJwyavMwTO7u62kQxwzdNCnPe+0s+ziqpTigH6BbkSjeCghzADDMMph6Ojf7ztXl8/w+o0zyZfOdPCPIzvm3/SguCqCJlUezhKKdbmZTkM/Pff9q8UKPq1NnkP7y/y1co71ypWaFcHOy2IaU0mp+8LC0hrO41WduJO1Dqf1uRDzJrEkFFSTnAV+ngjx3nu6l98hTnUaL989uk/3l95tUbIXCE554vx22L1JdMIm8Tg0RQAyheFz/QYDk0ryj0LLasLjH0WUn45ZagwtNEssIVwpvqavB+a3myfbBfRVUoqav2CrQem6o0aWFP6IjAAA8da3u30Novwt/DDapPV2vjamFDi9i+2zhwjHOlPvD6bNyePefqHp4uywXBT+NLAFOsYpKcPVb33LrIbLcOEYhsEYcDMn2GeQxutEZk6me8FBxj+/puJdNz293/wDVasKj79yhRHaa7IPguPxKS0Qw44XHErzQDli0FRKxATJ1+WxuaD+2hp/jxM2UM1k2Yv23yMUIwQ9x5yOcFdsPJPDVQmwJ8OvE4wxLvUYsisiZ+313bFZzqlwDMaoO9ab2fFGsXHl9voOLdqOTPxNrsR64wiK9pmV7dLA/uIOjvR9yKASj1cWT1xxBsQCiZXk/9yVjmV5u8QsiI5xX8yr/jnqUPRaTz8QG0HAiCxL6U/I7aVCkzlRllumrq1phdVLcXNGC4wI2qGdXQGo3dZ18N5lKNUL7xAuzM7UBHUWahRqF66+DT+F4mT+XAT7EvnnSIkf33nLAmxWuB9PrkyqlTu2SCs3q1tvtxu1K6fRGefb9S0/GwT7QzsYlia/P317WfGI6a49FQ2mjjUANTLAoS2XAIPMjUNF4/JqSapf1UdhqLkrACZXFbfEo930QhHZnG9XJ9xsiUfWl9uMoT8Eb3TKwZv3b/4GxLeWlnrPMufKLOQMInJEMIdUyDpLe2vF7AUi4cNx9Ooz2w+Urdpa1oUxl90L3XTfDJ/M75tHqZ/SuxOrk9MOCNbSqFztIqK4ayqeUdrIf8eeyXwy5wQkCkX8zeQ+iJfe10A+nrwQVd9nGbBEJcENYoCaKlixduvi6B9S10znvDIngKtTMJstnVIEZgb1SG9eXDoyl2QuG7IXe2V1jLcuyxSW0r43zcfvGd3/M53FE1WfxQycy2t2U4IskZBY0/YbvnBfFRkz4G756Myzcn3V2NhRbsOokX3mw5LCs3wU3rp3Q1RkrPvGdResiEM0EtB7ldR7yM9TMTRA/Hx8QmG/r8qnb9LxGveKgRcK+/kN3WrAxqgIIGiom17863H6GO9xgtjLGAecc8srOQWgxWbW6HUlsJYZJQFzEOkXKOsJTMh5idBktaddXQnGLLpPG0Z11bBrK+cM6jJauSmIvLBWsiQ+MhHWPI5tP9GrDq65Viw8rCypbz2NmmxKW5tqcqPDuXhXBf533VlaiX8KBdcjqThFQrx3uEbhxMZjAZeF3sG/jU5qVsU0KqiaLgUuvFQ== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47608938-aa44-4dab-ce2c-08dbc7cd69e5 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2023 07:08:46.4949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WmFnA5eEA/xleoU9egevoSaoUd3I5m7WBTSoiQQmpVOep1pTTt7ZwZIAFYxT2OrN9sIJjz3bnT3JFPWC2lz42S/E9ztWQCHCsMAhZyqSHy4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR13MB5094 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The initial logic do not give a value to the out parameter in the abnormal logic, which cause an local variable uninitialized problem. Fixes: 3d6811281392 ("net/nfp: add infrastructure for conntrack flow merge") Cc: chaoyong.he@corigine.com Signed-off-by: Chaoyong He Acked-by: Ferruh Yigit --- drivers/net/nfp/flower/nfp_conntrack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/flower/nfp_conntrack.c b/drivers/net/nfp/flower/nfp_conntrack.c index aacd4d7dd3..7b84b12546 100644 --- a/drivers/net/nfp/flower/nfp_conntrack.c +++ b/drivers/net/nfp/flower/nfp_conntrack.c @@ -332,6 +332,7 @@ nfp_flow_item_conf_size_get(enum rte_flow_item_type type, break; default: PMD_DRV_LOG(ERR, "Unsupported item type: %d", type); + *size = 0; return false; } @@ -1265,9 +1266,9 @@ nfp_ct_merge_item_real(const struct rte_flow_item *item_src, struct rte_flow_item *item_dst) { uint32_t i; - size_t size; char *key_dst; char *mask_dst; + size_t size = 0; const char *key_src; const char *mask_src;