From patchwork Tue Oct 3 20:41:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Duszynski X-Patchwork-Id: 132291 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B50EF426B2; Tue, 3 Oct 2023 22:41:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F60B40297; Tue, 3 Oct 2023 22:41:28 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 9337740262 for ; Tue, 3 Oct 2023 22:41:26 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 393FW7t3022328; Tue, 3 Oct 2023 13:41:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=m1fjgfeFH1pTSraXTeIoDjw/Xk5a4Z1erJWeV/KEO6Q=; b=SPkqNCqw9JcDiyLiArv7NBC2k1V7sF7ZnYRk007bBcYRLXCiHUVoR9eR+5Lg/g5cKUsP gbK0Y9JqaUTkst2ykX0SeA1OWGQYeKJW5QwAsqIGy4BOdBAyyFfC3a6a2CJj4y8qEdD3 cWqG7+kbruHhm30OahP1HevuoyNFf0VY18eOCcjMz06EJxFnEty6WCP1MiwgD8tqdNA/ +u/dhOqiTCbXZSO/0cFcgKceKIeS0Rh7HUhaVTzumjDpTfC4QKLwiPtwYHbbzafPWvZY i1i/RkG2DcmlHhMti3sBghirMJgWiSEApDiDFneypLnI6x9I5X+T3C8Nj4GzK/e9pkwV NQ== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3tgbasbjey-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 03 Oct 2023 13:41:25 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 3 Oct 2023 13:41:24 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 3 Oct 2023 13:41:24 -0700 Received: from cavium-DT10.. (unknown [10.28.34.39]) by maili.marvell.com (Postfix) with ESMTP id 451C53F7052; Tue, 3 Oct 2023 13:41:18 -0700 (PDT) From: Tomasz Duszynski To: , Jakub Palider , Tomasz Duszynski , Anatoly Burakov CC: , Subject: [PATCH] raw/cnxk_bphy: support multi-process mode Date: Tue, 3 Oct 2023 22:41:09 +0200 Message-ID: <20231003204110.3344703-1-tduszynski@marvell.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: HKpUdaBllLzBe-trtlocxp8VWrekJIMj X-Proofpoint-GUID: HKpUdaBllLzBe-trtlocxp8VWrekJIMj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-03_18,2023-10-02_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add support for sharing BPHY PMD across multiple running processes. In scenarios where resources need to be shared across processes user-space need to ensure serialization. Signed-off-by: Tomasz Duszynski Reviewed-by: Jerin Jacob Kollanukkaran Tested-by: Jerin Jacob Kollanukkaran --- doc/guides/rawdevs/cnxk_bphy.rst | 8 ++++++++ drivers/raw/cnxk_bphy/cnxk_bphy.c | 16 ++++++++++------ 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/doc/guides/rawdevs/cnxk_bphy.rst b/doc/guides/rawdevs/cnxk_bphy.rst index 2490912534..b544b543a3 100644 --- a/doc/guides/rawdevs/cnxk_bphy.rst +++ b/doc/guides/rawdevs/cnxk_bphy.rst @@ -19,6 +19,14 @@ The BPHY CGX/RPM implements following features in the rawdev API: - Access to BPHY CGX/RPM via a set of predefined messages - Access to BPHY memory - Custom interrupt handlers +- Multiprocess aware + +Limitations +----------- + +In multiprocess mode user-space application must ensure no resources +sharing takes place. Otherwise, user-space application should ensure +synchronization. Device Setup ------------ diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c index d42cca649c..15dbc4c1a6 100644 --- a/drivers/raw/cnxk_bphy/cnxk_bphy.c +++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c @@ -359,10 +359,12 @@ bphy_rawdev_probe(struct rte_pci_driver *pci_drv, bphy_dev->mem.res2 = pci_dev->mem_resource[2]; bphy_dev->bphy.pci_dev = pci_dev; - ret = roc_bphy_dev_init(&bphy_dev->bphy); - if (ret) { - rte_rawdev_pmd_release(bphy_rawdev); - return ret; + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { + ret = roc_bphy_dev_init(&bphy_dev->bphy); + if (ret) { + rte_rawdev_pmd_release(bphy_rawdev); + return ret; + } } return 0; @@ -390,8 +392,10 @@ bphy_rawdev_remove(struct rte_pci_device *pci_dev) return -EINVAL; } - bphy_dev = (struct bphy_device *)rawdev->dev_private; - roc_bphy_dev_fini(&bphy_dev->bphy); + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { + bphy_dev = (struct bphy_device *)rawdev->dev_private; + roc_bphy_dev_fini(&bphy_dev->bphy); + } return rte_rawdev_pmd_release(rawdev); }