From patchwork Wed Sep 20 13:33:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 131734 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 209DE425EA; Wed, 20 Sep 2023 15:35:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8E8142DB0; Wed, 20 Sep 2023 15:34:33 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2049.outbound.protection.outlook.com [40.107.104.49]) by mails.dpdk.org (Postfix) with ESMTP id 8513E42DA3 for ; Wed, 20 Sep 2023 15:34:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SV67yvCa6lyGQmmv6BiNMLtmuauDzHNqbYy5Jlkmig471gVCY1kjkIoL3Tnv33Jy/iOR14pAwt85nIO5CTrGhxHIwTY0qEG7FnES3ekLd6Apts3pl8yJ0xxeGQs/TSnlTkkyIpAT0becDQV9NC046PFnjqTP6It4OSWEOwbN8ZVV1VpCSCWYHLzfPMpu7b9Y3epaIUwKMDv5b9A9FFiVJ5PlXYoXwaFsFq+mWK9UmQ2BCTAtRaD5ihoxCVCV3sJKBP4T2hqVVp6ItRAJ+eB9PpmP7QmdCbDXtfG/wDf6/ZcGR/y7DsdqC1rNT29OEHodPQx3ax+lS08nzRxvS7CTQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B36xNyvXbkZGEYliOP7+MXeBqZ0FnAsviCM7OZ2u0Rs=; b=APZGaCEcs6BdGUWTeLEFjk9waDlXtGQ9K9yJh5sbTaKYVJt7uRCKhBbY/MM9rlNrIL59EIEjCgnP2lAIgMFqoonQ+LVwocC8JqhOpRbnu3WT5/3ETvvx2ZY1874axulkaVmWilcKIhPpHDTQCTKy0fQn81AZYq3fbZzXFA5CGmhezGKxbueFmhweUln2WX2aytyyvv0OvE6EN9MsBmDTRjNOMwFUglrL9VuuYgUNdqIHHtE/yaSvsimJcpOVft5RlHhraBf2JBKZUpEOuCKKxbrB2rfH7crTYRn05nCWcqlBPscAPwjM+iQ+tFZX1UaWRFgx1ovBBbwcYmBgCKg2ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B36xNyvXbkZGEYliOP7+MXeBqZ0FnAsviCM7OZ2u0Rs=; b=H41vItDDyBd7+rmpUpJ33ieqwO9bIRLP0AF2hA7NJfGz/3BajIGoUYs9pRkYMp8IICstpqIIhBTQtRmlaOsvDtbkOx+tcizf680yzONlT/tQSU3JygT+rL1uj52eM6p1gTxF/DZ2FKTV3LJi1C7ERoU/Dy37L5QYy0U3PKAVggg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by AS8PR04MB7606.eurprd04.prod.outlook.com (2603:10a6:20b:23e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Wed, 20 Sep 2023 13:34:29 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::450d:89ac:4f6a:6ae2]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::450d:89ac:4f6a:6ae2%4]) with mapi id 15.20.6792.021; Wed, 20 Sep 2023 13:34:29 +0000 From: Hemant Agrawal To: gakhil@marvell.com Cc: dev@dpdk.org, Gagandeep Singh Subject: [PATCH v2 06/13] crypto/dpaax_sec: set the authdata in non-auth case Date: Wed, 20 Sep 2023 19:03:56 +0530 Message-Id: <20230920133403.6420-7-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230920133403.6420-1-hemant.agrawal@nxp.com> References: <20230823070855.27532-1-hemant.agrawal@nxp.com> <20230920133403.6420-1-hemant.agrawal@nxp.com> X-ClientProxiedBy: SI2PR01CA0015.apcprd01.prod.exchangelabs.com (2603:1096:4:191::15) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|AS8PR04MB7606:EE_ X-MS-Office365-Filtering-Correlation-Id: d555aa60-afcd-47a8-6f29-08dbb9de50df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gR1Z4PQf2HX1TyO42E3EsdeVZycBcX73lFgcBX5TZGdidlZ2IvlakAlNvCNzS4FuWL1f5R25qNWQnOoGhiQIFau/OWm9enG++sZrsaVF+8L3s5R6vm061QT2p6J94DKFDnV3qLjwf4In0N+fzlu339S78GRCxVJ5lEWilZNHrhg8iGmXI57W/X0B94LMQjVbB3KQG7PP+yf5ZMZOgUbqqsruStJirI1YV6vhI4hnu+qkww67qShd8Dzel+nKKFXLRwodJ+RS/edCQAZSuH3w1WiPqwmTiFjsDTDvPYmwX3jSvNI46kSlnJHuk9WjV1EzGtWFZtEYoz6VHKL8LU+z9M4tE6giSo3EhVv1ipkn28iD00YipFM9AyMp1DRI1wxPxlnd8Wa3yeTe8oOgNMVbhYBLqOvIvLu/9D9JgyiNnwqGyMrRsrzAk8a22a/xILIZxFv41yNj8ZgICCeCCbsgB4JGvxichepY0hqyUG4rFah0XFJcI5AxfYL5/NuLDeIWeQ7akZGwW/++b6wlqD2+i4Oezjt4uCCjGrW6v61AaQuKwciPb77MyfB0HVUnBhPZZbVW5ksjpogG5XtN1N+KMC37p17wBTe+x0VrYwHl0PvDsXtgjADLLu/u2sTG0Zt2 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(136003)(376002)(346002)(39860400002)(451199024)(186009)(1800799009)(6506007)(52116002)(6666004)(6512007)(478600001)(26005)(6486002)(4326008)(2616005)(41300700001)(5660300002)(2906002)(66946007)(66476007)(66556008)(8676002)(83380400001)(8936002)(6916009)(44832011)(316002)(1076003)(86362001)(36756003)(38100700002)(38350700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: FLsJ5qZJyGHyhHU4LnJX5xu2mV/P59iyq36rGz/oJlUILNpXFN5pLKE89+/ig1jlnT1LE6e8jOaU8XM6qMDzi0v0Buwv0hVhoz1P4aaDpacIR3+j5lkweIFWHzT2T0ZmivqR8+Lxl+fpDjoC1BRH+ipR4RuFaejMWouBvEU0Z1ICYG4hviEwL/5VHI6igBQaHCjheFVshgJGSeVMN+gZeEw/e5+obBFbsVMWb2Pcll1Cj72+QlMUgCOeOGE9fKjaqr16lxe1OG/SV7MG/JnZDnl+JBj3S8Jub+CwhKXThc8fCbfqiQ+ROruCA9/pTPxkOOPzNlsX6/e2axroBYImRVZo7/PVxIscwRTuBepFt458vRwRKFan3grJvYRnx+fb+FGZv2C0yLGYoP6k5Os9zv2XxhlVBVDTE3PLrncdcg7WaIirx3gsfKpmgaTw8emedUHhaCcW53NjoTsPAo3pq8YsSBVtf0S4GQBmohRVmh0ZJI99viSdiazQbwH7hn21IPTJ34mH7IofmJZ+tTD7Brkt+FmtpAsr/EigugM9iSrltspkAhVL8XcgMEt05q26/+YnX2JsSoPEp4S9EwJuF33EnUnZrjAprguSFlr/GO+R8qbH1X/dFkcnogUUb59V713AtFrYpCKUutZiVeXkMLNnJu5zqV+r6xCGOcUtn6/Oi0IYALBJLoAgzUM28URsJruEkw6Nc7POcgivdJe0sdhZ7fne0nNZSKnXhCdZS5TSXRdFhx62zoQsxbv+LEqnXJdWthKsvIv/xI2mM7wbeRgLyvhqM8WTqItQMaXIchKqDscpK2Iho9EB7zg+BahNiQdJtHzAo6XjqCjZMnblWBGzvBL4VxUHGY/vqWAgZi26O8QDCrCHhBHtHTvrRx/10JpYwmXTuhNMOcpaLCDV/uoYHQDDBkrdqoxX8fVXWQnNEiF3T7V2ambbsDQnceDJPmV3Q7cTSRX3fLyMthBMO7YEtDOTyxxgpDVIys0AdHywqeBDl6k71mZ96vthacNh+0tLHq4jPpQc9BrMxkytPzd3Zjx7UFAJueTrXNc2kAOi6gLSPzMXOuDF27KivK8zmtfnm8dJGFsITP/nPUvEvhT3SwXPRPPFoz+Pa4QBmkZGFcFcJ4fhJRb4k4imC2pR4cXDesg24KTPon0VYwKyZtW1Z7KT2lmm9lbybro0ED4J92+XeeO4zZUU5+3WEDszoztqf+qjMA/E/dLj3YIcE0Wm+WY0mHtJQtsAWuNY0FbS1GdaMrCO8AyzLGL+gNkTz1jKvTtUlXrwZNMJhC1WXgVejD/xyL+hGh8ItJOpi7Bs5otOJcRs4tKvExdRVOzAUep/3mukA4oP1oTMBS5ajtoxVqmmtxnr8Lr4DwXMGe9cniPYEG8uxizr57DUHtSrp8NfGAi5EmHTSeetWB0HPDqK5l6UfqIGCBlU1Y299VAdk54I2XDocND1M2jmRjKlh7byaERPkIC78EXZHnIgprL5+xRNZwVCaRSlEjLf6lM2l+HscbcBXo23QULxbI3FcS/6WLOtY6zZj2SUjC8eNPgeqXMab0kyb9c3zR+IAMV8JYveUIV+vuXaK5+ZijmjOXtHmSbFBOabxji4FHvBfg== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d555aa60-afcd-47a8-6f29-08dbb9de50df X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 13:34:29.5200 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eA+iS1g205CeY+XUAMbXW91tmhunJcdPIJqfTcSIv/TXG3ezWBm30sj+hCABvIHC+ztThRnO9cyhk10VoPav9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7606 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Gagandeep Singh The descriptors refers to auth data as well, so initializing it properly for the non-auth cases. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 16 ++++++++++++---- drivers/crypto/dpaa_sec/dpaa_sec.c | 5 +++++ 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 3ceb886ddb..1fc0d2e7cc 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -3538,12 +3538,20 @@ dpaa2_sec_set_pdcp_session(struct rte_cryptodev *dev, session->auth_alg); goto out; } - p_authdata = &authdata; - } else if (pdcp_xform->domain == RTE_SECURITY_PDCP_MODE_CONTROL) { - DPAA2_SEC_ERR("Crypto: Integrity must for c-plane"); - goto out; + } else { + if (pdcp_xform->domain == RTE_SECURITY_PDCP_MODE_CONTROL) { + DPAA2_SEC_ERR("Crypto: Integrity must for c-plane"); + goto out; + } + session->auth_key.data = NULL; + session->auth_key.length = 0; + session->auth_alg = 0; } + authdata.key = (size_t)session->auth_key.data; + authdata.keylen = session->auth_key.length; + authdata.key_enc_flags = 0; + authdata.key_type = RTA_DATA_IMM; if (pdcp_xform->sdap_enabled) { int nb_keys_to_inline = diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index f3f565826f..0fcba95916 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -3188,6 +3188,11 @@ dpaa_sec_set_pdcp_session(struct rte_cryptodev *dev, auth_xform->key.length); session->auth_alg = auth_xform->algo; } else { + if (pdcp_xform->domain == RTE_SECURITY_PDCP_MODE_CONTROL) { + DPAA_SEC_ERR("Crypto: Integrity must for c-plane"); + ret = -EINVAL; + goto out; + } session->auth_key.data = NULL; session->auth_key.length = 0; session->auth_alg = 0;