app/test: add telemetry tests to fast test suite

Message ID 20230914152442.281979-1-bruce.richardson@intel.com (mailing list archive)
State Rejected, archived
Delegated to: David Marchand
Headers
Series app/test: add telemetry tests to fast test suite |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

Bruce Richardson Sept. 14, 2023, 3:24 p.m. UTC
  The telemetry data tests, and the telemetry json tests execute very
quickly, so can be added to the fast-test suite.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 app/test/test_telemetry_data.c | 2 +-
 app/test/test_telemetry_json.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
  

Comments

Power, Ciara Sept. 14, 2023, 3:34 p.m. UTC | #1
> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Thursday, September 14, 2023 4:25 PM
> To: dev@dpdk.org
> Cc: aconole@redhat.com; Richardson, Bruce <bruce.richardson@intel.com>;
> Power, Ciara <ciara.power@intel.com>
> Subject: [PATCH] app/test: add telemetry tests to fast test suite
> 
> The telemetry data tests, and the telemetry json tests execute very quickly, so
> can be added to the fast-test suite.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  app/test/test_telemetry_data.c | 2 +-
>  app/test/test_telemetry_json.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Acked-by: Ciara Power <ciara.power@intel.com>
  
David Marchand Sept. 15, 2023, 12:47 p.m. UTC | #2
On Thu, Sep 14, 2023 at 5:31 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The telemetry data tests, and the telemetry json tests execute very
> quickly, so can be added to the fast-test suite.

Indeed, they are really quick, and already part of the (fixed)
fast-tests suite :-).
Marking as rejected.

>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
  

Patch

diff --git a/app/test/test_telemetry_data.c b/app/test/test_telemetry_data.c
index 31629a001b..59898ff5e9 100644
--- a/app/test/test_telemetry_data.c
+++ b/app/test/test_telemetry_data.c
@@ -615,4 +615,4 @@  telemetry_data_autotest(void)
 }
 #endif /* !RTE_EXEC_ENV_WINDOWS */
 
-REGISTER_TEST_COMMAND(telemetry_data_autotest, telemetry_data_autotest);
+REGISTER_FAST_TEST(telemetry_data_autotest, true, true, telemetry_data_autotest);
diff --git a/app/test/test_telemetry_json.c b/app/test/test_telemetry_json.c
index 5617eac540..758e89303f 100644
--- a/app/test/test_telemetry_json.c
+++ b/app/test/test_telemetry_json.c
@@ -213,4 +213,4 @@  test_telemetry_json(void)
 	return 0;
 }
 
-REGISTER_TEST_COMMAND(telemetry_json_autotest, test_telemetry_json);
+REGISTER_FAST_TEST(telemetry_json_autotest, true, true, test_telemetry_json);