From patchwork Tue Sep 5 16:39:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 131181 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C60E5424F4; Tue, 5 Sep 2023 18:39:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AD19427E7; Tue, 5 Sep 2023 18:39:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 7A03A4161A for ; Tue, 5 Sep 2023 18:39:30 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 385DdcLT004704 for ; Tue, 5 Sep 2023 09:39:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=vQ2NoCEd/0yPg4KvitW1d7ibHPkqvZiKOE+7ms/A/XY=; b=kCuOYHPITAPyQe0UpGplaaf9R9TB+zspSjxuwIDMH/Ouki0tQ+NX4mz0JlD+2sU4LGgw WO77mXYzlnhacaiy4Vthk6usKrh9VZFRyr6/epv+ObK2AbGekRwwz5vwtDqO69CPmerp /XRN6LT5JKYEGGJY65h4ToPmhwxhc7JIKDBTe5k5yckr7VU6UXdCvLSbxsXXY6wHKTA7 DShrOQNylxZHb2lwrtP8QMEVdwmsPpRHJQuMCS0pBb0w3tNAJnq4aDLt/dwJRU7Q3UvJ wjleItYGhlpsVjJ9w99sMKHrPG+BvsFSI9tAGdkSzVS6K/XqXwaFUsh9j+kv5/SqLANN 4g== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3sv4jkajdu-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 05 Sep 2023 09:39:29 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 5 Sep 2023 09:39:19 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 5 Sep 2023 09:39:19 -0700 Received: from MININT-80QBFE8.corp.innovium.com (MININT-80QBFE8.marvell.com [10.28.164.106]) by maili.marvell.com (Postfix) with ESMTP id E8FDE3F7081; Tue, 5 Sep 2023 09:39:15 -0700 (PDT) From: To: , Nithin Dabilpuram , "Kiran Kumar K" , Sunil Kumar Kori , Satha Rao CC: , Pavan Nikhilesh Subject: [PATCH 3/3] common/cnxk: use local labels in asm intrinsic Date: Tue, 5 Sep 2023 22:09:08 +0530 Message-ID: <20230905163908.19946-3-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230905163908.19946-1-pbhagavatula@marvell.com> References: <20230905163908.19946-1-pbhagavatula@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: c8GTV5a4ZBMmSo56lOEQ4DI1MlZ54nPD X-Proofpoint-ORIG-GUID: c8GTV5a4ZBMmSo56lOEQ4DI1MlZ54nPD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-05_10,2023-09-05_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Pavan Nikhilesh Using labels in asm generates them as regular function and shades callstack in tools like gdb or perf. Use local label instead for better visibility. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_sso_dp.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/common/cnxk/roc_sso_dp.h b/drivers/common/cnxk/roc_sso_dp.h index 9d30286d2f..03c5bdf7ee 100644 --- a/drivers/common/cnxk/roc_sso_dp.h +++ b/drivers/common/cnxk/roc_sso_dp.h @@ -13,13 +13,13 @@ roc_sso_hws_head_wait(uintptr_t base) #if defined(__aarch64__) asm volatile(PLT_CPU_FEATURE_PREAMBLE - " ldr %[tag], [%[tag_op]] \n" - " tbnz %[tag], 35, done%= \n" + " ldr %[tag], [%[tag_op]] \n" + " tbnz %[tag], 35, .Ldone%= \n" " sevl \n" - "rty%=: wfe \n" - " ldr %[tag], [%[tag_op]] \n" - " tbz %[tag], 35, rty%= \n" - "done%=: \n" + ".Lrty%=: wfe \n" + " ldr %[tag], [%[tag_op]] \n" + " tbz %[tag], 35, .Lrty%= \n" + ".Ldone%=: \n" : [tag] "=&r"(tag) : [tag_op] "r"(tag_op)); #else