net/ice: fix tm configuration cannot be clear
Checks
Commit Message
When the device is stopped, DPDK resets the commit flag so that
we can update the hierarchy configuration. The commit flag is also
used to determine if the hierarchy configuration needs to be cleared.
When DPDK exits, it always stops the device first and also resets
the commit flag result in the hierarchy configuration is not cleared.
This patch adds a new flag "need_clear" to determine if the
hierarchy configuration needs to be cleared.
Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF")
Cc: stable@dpdk.org
Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
drivers/net/ice/ice_dcf.c | 2 +-
drivers/net/ice/ice_dcf.h | 1 +
drivers/net/ice/ice_dcf_sched.c | 3 +++
3 files changed, 5 insertions(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> Sent: Tuesday, August 29, 2023 2:24 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Deng, KaiwenX <kaiwenx.deng@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>; Xu, Ting <ting.xu@intel.com>
> Subject: [PATCH] net/ice: fix tm configuration cannot be clear
>
> When the device is stopped, DPDK resets the commit flag so that we can
> update the hierarchy configuration.
Why we need to reset commit flag when device is stopped?
If the commit flag indicate all tm configure has been committed, stop device does not change the status, its confusing to reset it.
Can we simply prevent additional commit when device is running by only checking the stop flag? And why we reject a commit if its already committed?
> The commit flag is also used to determine
> if the hierarchy configuration needs to be cleared.
> When DPDK exits, it always stops the device first and also resets the commit
> flag result in the hierarchy configuration is not cleared.
>
> This patch adds a new flag "need_clear" to determine if the hierarchy
> configuration needs to be cleared.
>
> Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Friday, September 1, 2023 1:39 PM
> To: Deng, KaiwenX <kaiwenx.deng@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Xu, Ting <ting.xu@intel.com>
> Subject: RE: [PATCH] net/ice: fix tm configuration cannot be clear
>
>
>
> > -----Original Message-----
> > From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> > Sent: Tuesday, August 29, 2023 2:24 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhou,
> > YidingX <yidingx.zhou@intel.com>; Deng, KaiwenX
> > <kaiwenx.deng@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Xu, Ting
> > <ting.xu@intel.com>
> > Subject: [PATCH] net/ice: fix tm configuration cannot be clear
> >
> > When the device is stopped, DPDK resets the commit flag so that we can
> > update the hierarchy configuration.
>
> Why we need to reset commit flag when device is stopped?
> If the commit flag indicate all tm configure has been committed, stop device
> does not change the status, its confusing to reset it.
>
> Can we simply prevent additional commit when device is running by only
> checking the stop flag? And why we reject a commit if its already committed?
>>Thanks for your review, I submitted a new patch that changes DPDK to not
>>reset the commit flag when the device is stopped. And we prevent additional
>>commit when device is running by only checking the stop flag.
>
> > The commit flag is also used to determine if the hierarchy
> > configuration needs to be cleared.
> > When DPDK exits, it always stops the device first and also resets the
> > commit flag result in the hierarchy configuration is not cleared.
> >
> > This patch adds a new flag "need_clear" to determine if the hierarchy
> > configuration needs to be cleared.
> >
> > Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in
> > DCF")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> > ---
@@ -877,7 +877,7 @@ ice_dcf_uninit_hw(struct rte_eth_dev *eth_dev, struct ice_dcf_hw *hw)
struct rte_intr_handle *intr_handle = pci_dev->intr_handle;
if (hw->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_QOS)
- if (hw->tm_conf.committed) {
+ if (hw->tm_conf.need_clear) {
ice_dcf_clear_bw(hw);
ice_dcf_tm_conf_uninit(eth_dev);
}
@@ -78,6 +78,7 @@ struct ice_dcf_tm_conf {
uint32_t nb_tc_node;
uint32_t nb_vsi_node;
bool committed;
+ bool need_clear;
};
struct ice_dcf_eth_stats {
@@ -51,6 +51,7 @@ ice_dcf_tm_conf_init(struct rte_eth_dev *dev)
hw->tm_conf.nb_tc_node = 0;
hw->tm_conf.nb_vsi_node = 0;
hw->tm_conf.committed = false;
+ hw->tm_conf.need_clear = false;
}
void
@@ -870,6 +871,8 @@ static int ice_dcf_hierarchy_commit(struct rte_eth_dev *dev,
ICE_NONDMA_TO_NONDMA);
hw->tm_conf.committed = true;
+ hw->tm_conf.need_clear = true;
+
return ret_val;
fail_clear: