[v8,2/6] reorder: use a dynamic logtype
Checks
Commit Message
Libraries should not be reusing RTE_LOGTYPE_USER1 instead
of doing proper logtype registration.
Fixes: b70b56032bff ("reorder: new library")
Cc: sergio.gonzalez.monroy@intel.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/reorder/rte_reorder.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, August 14, 2023 6:31 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; sergio.gonzalez.monroy@intel.com;
> Volodymyr Fialko <vfialko@marvell.com>; Reshma Pattan <reshma.pattan@intel.com>; Neil Horman
> <nhorman@tuxdriver.com>; Richardson Bruce <bruce.richardson@intel.com>; Declan Doherty
> <declan.doherty@intel.com>
> Subject: [EXT] [PATCH v8 2/6] reorder: use a dynamic logtype
>
> Libraries should not be reusing RTE_LOGTYPE_USER1 instead of doing proper logtype registration.
>
> Fixes: b70b56032bff ("reorder: new library")
> Cc: sergio.gonzalez.monroy@intel.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Volodymyr Fialko <vfialko@marvell.com>
@@ -16,6 +16,9 @@
#include "rte_reorder.h"
+RTE_LOG_REGISTER_DEFAULT(reorder_logtype, INFO);
+#define RTE_LOGTYPE_REORDER reorder_logtype
+
TAILQ_HEAD(rte_reorder_list, rte_tailq_entry);
static struct rte_tailq_elem rte_reorder_tailq = {
@@ -27,9 +30,6 @@ EAL_REGISTER_TAILQ(rte_reorder_tailq)
#define RTE_REORDER_PREFIX "RO_"
#define RTE_REORDER_NAMESIZE 32
-/* Macros for printing using RTE_LOG */
-#define RTE_LOGTYPE_REORDER RTE_LOGTYPE_USER1
-
#define RTE_REORDER_SEQN_DYNFIELD_NAME "rte_reorder_seqn_dynfield"
int rte_reorder_seqn_dynfield_offset = -1;