app: fix silent enqueue fail in test_mbuf test_refcnt_iter
Checks
Commit Message
From: Julien Hascoet <ju.hascoet@gmail.com>
In case of ring full state, we retry the enqueue
operation in order to avoid mbuf loss.
Fixes: af75078fece ("first public release")
Signed-off-by: Julien Hascoet <ju.hascoet@gmail.com>
---
app/test/test_mbuf.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
Comments
On Thu, 10 Aug 2023 08:00:30 +0200
jhascoet <ju.hascoet@gmail.com> wrote:
> diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
> index efac01806b..be114e3302 100644
> --- a/app/test/test_mbuf.c
> +++ b/app/test/test_mbuf.c
> @@ -1033,12 +1033,17 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter,
> tref += ref;
> if ((ref & 1) != 0) {
> rte_pktmbuf_refcnt_update(m, ref);
> - while (ref-- != 0)
> - rte_ring_enqueue(refcnt_mbuf_ring, m);
> + while (ref-- != 0) {
> + /* retry in case of failure */
> + while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)
> + ;
Since other side needs to consume these and might be on same lcore,
it might be good place to add rte_pause or sched_yield here?
Yes, just did it.
Thanks !
@@ -1033,12 +1033,17 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter,
tref += ref;
if ((ref & 1) != 0) {
rte_pktmbuf_refcnt_update(m, ref);
- while (ref-- != 0)
- rte_ring_enqueue(refcnt_mbuf_ring, m);
+ while (ref-- != 0) {
+ /* retry in case of failure */
+ while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)
+ ;
+ }
} else {
while (ref-- != 0) {
rte_pktmbuf_refcnt_update(m, 1);
- rte_ring_enqueue(refcnt_mbuf_ring, m);
+ /* retry in case of failure */
+ while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)
+ ;
}
}
rte_pktmbuf_free(m);