diff mbox series

test: eal: update base-virtaddr parameter test

Message ID 20230720130900.357876-1-aconole@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series test: eal: update base-virtaddr parameter test |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Functional success Functional PASS
ci/iol-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Aaron Conole July 20, 2023, 1:09 p.m. UTC 
  When 97435d7906 ("net/bnxt: update Truflow core") was applied, it introduced
a number of static variables.  These ended up filling the lower address space
enough that on some platforms, the min addr for heap address to start was
not within the range specified by base-virtaddr.  This is dependent on both
build and link time options.

The simplest resolution is to just update the base virtaddr parameter to
move the rte config location.

Reported-by: Patrick Robb <probb@iol.unh.edu>
Suggested-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
 app/test/test_eal_flags.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ajit Khaparde July 20, 2023, 2:07 p.m. UTC | #1 
On Thu, Jul 20, 2023 at 6:09 AM Aaron Conole <aconole@redhat.com> wrote:
>
> When 97435d7906 ("net/bnxt: update Truflow core") was applied, it introduced
> a number of static variables.  These ended up filling the lower address space
> enough that on some platforms, the min addr for heap address to start was
> not within the range specified by base-virtaddr.  This is dependent on both
> build and link time options.
>
> The simplest resolution is to just update the base virtaddr parameter to
> move the rte config location.
>
> Reported-by: Patrick Robb <probb@iol.unh.edu>
> Suggested-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
ACK.
I tested again and the test passed with this change. Thanks.

> ---
>  app/test/test_eal_flags.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
> index d2b91e2075..148e9098e8 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -1017,7 +1017,7 @@ test_misc_flags(void)
>
>         /* try running with base-virtaddr param */
>         const char *argv13[] = {prgname, "--file-prefix=virtaddr",
> -                       "--base-virtaddr=0x12345678"};
> +                       "--base-virtaddr=0x23456789"};
>
>         /* try running with --vfio-intr INTx flag */
>         const char *argv14[] = {prgname, "--file-prefix=intr",
> --
> 2.40.1
>
Thomas Monjalon July 22, 2023, 1:32 p.m. UTC | #2 
20/07/2023 16:07, Ajit Khaparde:
> On Thu, Jul 20, 2023 at 6:09 AM Aaron Conole <aconole@redhat.com> wrote:
> >
> > When 97435d7906 ("net/bnxt: update Truflow core") was applied, it introduced
> > a number of static variables.  These ended up filling the lower address space
> > enough that on some platforms, the min addr for heap address to start was
> > not within the range specified by base-virtaddr.  This is dependent on both
> > build and link time options.
> >
> > The simplest resolution is to just update the base virtaddr parameter to
> > move the rte config location.
> >
> > Reported-by: Patrick Robb <probb@iol.unh.edu>
> > Suggested-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > Signed-off-by: Aaron Conole <aconole@redhat.com>
> ACK.
> I tested again and the test passed with this change. Thanks.

Applied, thanks.
diff mbox series

Patch

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index d2b91e2075..148e9098e8 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -1017,7 +1017,7 @@  test_misc_flags(void)
 
 	/* try running with base-virtaddr param */
 	const char *argv13[] = {prgname, "--file-prefix=virtaddr",
-			"--base-virtaddr=0x12345678"};
+			"--base-virtaddr=0x23456789"};
 
 	/* try running with --vfio-intr INTx flag */
 	const char *argv14[] = {prgname, "--file-prefix=intr",