[v2] net/iavf: fix Tunnel TSO path selecting.
Checks
Commit Message
IAVF currently supports TSO and Tunnel TSO. Both these two features
are implemented in scalar path. As there are missed flags for Tunnel
TSO, it selects vector paths wrongly when only Tunnel TSO is enabled
after introducing the patch "net/iavf: add offload path for Tx AVX512".
This patch added the missed flags to fix the Tunnel TSO path selecting.
Fixes: 059f18ae2aec ("net/iavf: add offload path for Tx AVX512")
Cc: stable@dpdk.org
Signed-off-by: Ke Xu <ke1.xu@intel.com>
---
v2: Add fixline, add CC, fix commit message.
---
drivers/net/iavf/iavf_rxtx.h | 4 ++++
1 file changed, 4 insertions(+)
Comments
> -----Original Message-----
> From: Xu, Ke1 <ke1.xu@intel.com>
> Sent: Thursday, July 6, 2023 10:45 AM
> To: dev@dpdk.org
> Cc: Xu, Ke1 <ke1.xu@intel.com>; Zeng, ZhichaoX
> <zhichaox.zeng@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/iavf: fix Tunnel TSO path selecting.
>
> IAVF currently supports TSO and Tunnel TSO. Both these two features are
> implemented in scalar path. As there are missed flags for Tunnel TSO, it
> selects vector paths wrongly when only Tunnel TSO is enabled after
> introducing the patch "net/iavf: add offload path for Tx AVX512".
>
> This patch added the missed flags to fix the Tunnel TSO path selecting.
>
> Fixes: 059f18ae2aec ("net/iavf: add offload path for Tx AVX512")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ke Xu <ke1.xu@intel.com>
> ---
> v2: Add fixline, add CC, fix commit message.
> ---
Acked-by: Zhichao Zeng <zhichaox.zeng@intel.com>
> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Sent: Thursday, July 6, 2023 2:08 PM
> To: Xu, Ke1 <ke1.xu@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH v2] net/iavf: fix Tunnel TSO path selecting.
>
> > -----Original Message-----
> > From: Xu, Ke1 <ke1.xu@intel.com>
> > Sent: Thursday, July 6, 2023 10:45 AM
> > To: dev@dpdk.org
> > Cc: Xu, Ke1 <ke1.xu@intel.com>; Zeng, ZhichaoX
> > <zhichaox.zeng@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH v2] net/iavf: fix Tunnel TSO path selecting.
net/iavf: fix Tunnel TSO path selection
> >
> > IAVF currently supports TSO and Tunnel TSO. Both these two features
> > are implemented in scalar path. As there are missed flags for Tunnel
> > TSO, it selects vector paths wrongly when only Tunnel TSO is enabled
> > after introducing the patch "net/iavf: add offload path for Tx AVX512".
> >
> > This patch added the missed flags to fix the Tunnel TSO path selecting.
> >
> > Fixes: 059f18ae2aec ("net/iavf: add offload path for Tx AVX512")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ke Xu <ke1.xu@intel.com>
> > ---
> > v2: Add fixline, add CC, fix commit message.
> > ---
>
> Acked-by: Zhichao Zeng <zhichaox.zeng@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -31,6 +31,10 @@
RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \
RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \
RTE_ETH_TX_OFFLOAD_TCP_TSO | \
+ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \
RTE_ETH_TX_OFFLOAD_SECURITY)
#define IAVF_TX_VECTOR_OFFLOAD ( \