crypto/qat: fix legacy sm4 ecb capability
Checks
Commit Message
Following the deprecation of insecure algorithms in QAT,
SM4-ECB should be included as legacy, to be disabled by default.
Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
Acked-by: Kai Ji <kai.ji@intel.com<mailto:kai.ji@intel.com>>
Hi Ciara,
> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Wednesday 5 July 2023 14:23
> To: dev@dpdk.org
> Cc: Ji, Kai <kai.ji@intel.com>; O'Donovan, Saoirse
> <saoirse.odonovan@intel.com>; Power, Ciara <ciara.power@intel.com>
> Subject: [PATCH] crypto/qat: fix legacy sm4 ecb capability
>
> Following the deprecation of insecure algorithms in QAT, SM4-ECB should be
> included as legacy, to be disabled by default.
>
> Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
> drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Tested-by: Saoirse O'Donovan <saoirse.odonovan@intel.com>
> > Subject: [PATCH] crypto/qat: fix legacy sm4 ecb capability
> >
> > Following the deprecation of insecure algorithms in QAT, SM4-ECB should be
> > included as legacy, to be disabled by default.
> >
> > Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
> > ---
> > drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Tested-by: Saoirse O'Donovan <saoirse.odonovan@intel.com>
Applied to dpdk-next-crypto
Thanks.
@@ -46,6 +46,9 @@ static struct rte_cryptodev_capabilities qat_sym_crypto_legacy_caps_gen3[] = {
QAT_SYM_PLAIN_AUTH_CAP(SHA3_224,
CAP_SET(block_size, 144),
CAP_RNG(digest_size, 28, 28, 0)),
+ QAT_SYM_CIPHER_CAP(SM4_ECB,
+ CAP_SET(block_size, 16),
+ CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0))
};
static struct rte_cryptodev_capabilities qat_sym_crypto_caps_gen3[] = {
@@ -147,9 +150,6 @@ static struct rte_cryptodev_capabilities qat_sym_crypto_caps_gen3[] = {
CAP_RNG(key_size, 32, 32, 0),
CAP_RNG(digest_size, 16, 16, 0),
CAP_RNG(aad_size, 0, 240, 1), CAP_RNG(iv_size, 12, 12, 0)),
- QAT_SYM_CIPHER_CAP(SM4_ECB,
- CAP_SET(block_size, 16),
- CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0)),
QAT_SYM_CIPHER_CAP(SM4_CBC,
CAP_SET(block_size, 16),
CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 16, 16, 0)),