diff mbox series

doc: fix missing release note for GVE PMD DQO

Message ID 20230703030023.2989092-1-junfeng.guo@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series doc: fix missing release note for GVE PMD DQO |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Junfeng Guo July 3, 2023, 3 a.m. UTC 
  Add missing release note for GVE PMD enabling for DQO queue format.

Fixes: a14d391c7d99 ("net/gve: add Tx queue setup for DQO")

Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
---
 doc/guides/rel_notes/release_23_07.rst | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rushil Gupta July 3, 2023, 5:34 p.m. UTC | #1 
On Sun, Jul 2, 2023 at 8:00 PM Junfeng Guo <junfeng.guo@intel.com> wrote:
>
> Add missing release note for GVE PMD enabling for DQO queue format.
>
> Fixes: a14d391c7d99 ("net/gve: add Tx queue setup for DQO")
>
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> ---
>  doc/guides/rel_notes/release_23_07.rst | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst
> index 4459144140..28c538acc9 100644
> --- a/doc/guides/rel_notes/release_23_07.rst
> +++ b/doc/guides/rel_notes/release_23_07.rst
> @@ -200,6 +200,9 @@ New Features
>
>    Enhanced the GRO library to support TCP packets over IPv6 network.
>
> +* **Added GVE PMD enabling for DQO.**
> +
> +  Added GVE PMD enabling for DQO queue format.
>
>  Removed Items
>  -------------
> --
> 2.34.1
>
Acked-by: Rushil Gupta <rushilg@google.com>
Ferruh Yigit July 4, 2023, 11:32 a.m. UTC | #2 
On 7/3/2023 6:34 PM, Rushil Gupta wrote:
> On Sun, Jul 2, 2023 at 8:00 PM Junfeng Guo <junfeng.guo@intel.com> wrote:
>>
>> Add missing release note for GVE PMD enabling for DQO queue format.
>>
>> Fixes: a14d391c7d99 ("net/gve: add Tx queue setup for DQO")
>>
>> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
>> ---
>>  doc/guides/rel_notes/release_23_07.rst | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst
>> index 4459144140..28c538acc9 100644
>> --- a/doc/guides/rel_notes/release_23_07.rst
>> +++ b/doc/guides/rel_notes/release_23_07.rst
>> @@ -200,6 +200,9 @@ New Features
>>
>>    Enhanced the GRO library to support TCP packets over IPv6 network.
>>
>> +* **Added GVE PMD enabling for DQO.**
>> +
>> +  Added GVE PMD enabling for DQO queue format.
>>

Updated as following while merging

 * **Updated Google GVE net driver.**

   Added DQO queue descriptor format support.


Also location was wrong, expected location of updates documented in
section comment, relocated according it.


Btw, what DQO stands for, I didn't able to find it?

>>  Removed Items
>>  -------------
>> --
>> 2.34.1
>>
> Acked-by: Rushil Gupta <rushilg@google.com>
>

Applied to dpdk-next-net/main, thanks.
Junfeng Guo July 5, 2023, 2:37 a.m. UTC | #3 
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Tuesday, July 4, 2023 19:33
> To: Rushil Gupta <rushilg@google.com>; Guo, Junfeng
> <junfeng.guo@intel.com>
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org;
> joshwash@google.com; jeroendb@google.com
> Subject: Re: [PATCH] doc: fix missing release note for GVE PMD DQO
> 
> On 7/3/2023 6:34 PM, Rushil Gupta wrote:
> > On Sun, Jul 2, 2023 at 8:00 PM Junfeng Guo <junfeng.guo@intel.com>
> wrote:
> >>
> >> Add missing release note for GVE PMD enabling for DQO queue format.
> >>
> >> Fixes: a14d391c7d99 ("net/gve: add Tx queue setup for DQO")
> >>
> >> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> >> ---
> >>  doc/guides/rel_notes/release_23_07.rst | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/doc/guides/rel_notes/release_23_07.rst
> b/doc/guides/rel_notes/release_23_07.rst
> >> index 4459144140..28c538acc9 100644
> >> --- a/doc/guides/rel_notes/release_23_07.rst
> >> +++ b/doc/guides/rel_notes/release_23_07.rst
> >> @@ -200,6 +200,9 @@ New Features
> >>
> >>    Enhanced the GRO library to support TCP packets over IPv6 network.
> >>
> >> +* **Added GVE PMD enabling for DQO.**
> >> +
> >> +  Added GVE PMD enabling for DQO queue format.
> >>
> 
> Updated as following while merging
> 
>  * **Updated Google GVE net driver.**
> 
>    Added DQO queue descriptor format support.
> 
> 
> Also location was wrong, expected location of updates documented in
> section comment, relocated according it.

Thanks for the efforts!
We'll be careful about this in the following releases.
And put the doc and release note update align with the feature upstream.

> 
> 
> Btw, what DQO stands for, I didn't able to find it?

Yes, I also tried to find out but no meaningful explain. Maybe just a label.
https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-linux/releases
"
v1.3.0
gve 1.3.0

This release adds support for gVNIC's Diorite queue format (DQO)
...
"
Thanks!

> 
> >>  Removed Items
> >>  -------------
> >> --
> >> 2.34.1
> >>
> > Acked-by: Rushil Gupta <rushilg@google.com>
> >
> 
> Applied to dpdk-next-net/main, thanks.
>
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst
index 4459144140..28c538acc9 100644
--- a/doc/guides/rel_notes/release_23_07.rst
+++ b/doc/guides/rel_notes/release_23_07.rst
@@ -200,6 +200,9 @@  New Features
 
   Enhanced the GRO library to support TCP packets over IPv6 network.
 
+* **Added GVE PMD enabling for DQO.**
+
+  Added GVE PMD enabling for DQO queue format.
 
 Removed Items
 -------------