From patchwork Wed Jun 28 16:29:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 129069 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A48842D82; Wed, 28 Jun 2023 18:33:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A91EE42D85; Wed, 28 Jun 2023 18:31:38 +0200 (CEST) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 273C942D85 for ; Wed, 28 Jun 2023 18:31:36 +0200 (CEST) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1b80ba9326bso796455ad.1 for ; Wed, 28 Jun 2023 09:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1687969895; x=1690561895; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=GQ/e49I73lrXEviJ0vZzS/k08BhSKOwhT1MwFkXmhXM=; b=aDsvtsvoNvA88kRBzl2FLAd6IwkV78wc8gxvF1N1eiL6rMgyX/BoPlC6e2jbPjMxu+ 31QVnNRFepILSpiU3nEw/N1Mw0En/NrLM3RVYqyqKtC91bq7hR0mIWmM6gfAYcD2n776 vwf+2m5aMMx4PbYWqutExn3ZH8K//8V1qG0xM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687969895; x=1690561895; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GQ/e49I73lrXEviJ0vZzS/k08BhSKOwhT1MwFkXmhXM=; b=jsSnO9Zi8l2shfGFD3SjEuCUm/0EC4HxJf+Mb0xVOSfnR8qw8wpgyM5doznQAnRnCv ydXi6HqIzohtb1tR2Ig/kIfGc21aE06KdmLROSx9PHHqRSz2StmwbKQb8ykEsWke/24b UOZ01nb8Xt7D2uAcS7S7Jqu+qYrmVmvcMLLAsk3upjT8CWWm4iF/wXiN64PtV55MoR0g PWwamuJLADGdSk8Z7T2NL7iBaORwRovxBMa7XKieqEd7/s2V9fdUtm0j7P04FonNihn2 p7LP2DNpwEci7oHaMSFgJAADZsBXKWDkCp3W4vjW/sPvRNfn9GoW5RvafhuB2eCVrGng yXYA== X-Gm-Message-State: AC+VfDxaxudWgfPdAL8odz57Llt2G4TRSqUdVjyjmJCBGG6iWP5pRKbc A2lXNO0sslBVXZk3pOrN3DEr1DJgJE3dVH6L+8HRlmV8U+i8vxCH7tvoP1BS/QLq2KqQHTqfxVy nGRegFbDxDo1NlxgbUYybraQJSnqa8C6pde0ipGy8VLHSpVHBFWFzVu60nT8Yq+wxcXvlJz4= X-Google-Smtp-Source: ACHHUZ4VhYh8wsHWhnJbiC5YkixI2ZkaKrmJLsqYliS2a2+eMZcJ92ayDoy1oUYmRAUkjTtxpGetrg== X-Received: by 2002:a17:902:ed41:b0:1b8:4129:e7dc with SMTP id y1-20020a170902ed4100b001b84129e7dcmr1791244plb.50.1687969895079; Wed, 28 Jun 2023 09:31:35 -0700 (PDT) Received: from localhost.localdomain ([192.19.252.250]) by smtp.gmail.com with ESMTPSA id h12-20020a170902f7cc00b001b8229942a0sm3092403plw.34.2023.06.28.09.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 09:31:34 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, thomas@monjalon.net, Shuanglin Wang , Kishore Padmanabha , Mike Baucom Subject: [PATCH v4 11/11] net/bnxt: set RSS config based on RSS mode Date: Wed, 28 Jun 2023 09:29:27 -0700 Message-Id: <20230628162927.92858-12-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230628162927.92858-1-ajit.khaparde@broadcom.com> References: <1826961.atdPhlSkOF@thomas> <20230628162927.92858-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Shuanglin Wang Avoid submitting hwrm RSS request when rss mode disabled. On WH+, if rss mode isn't enabled, then there is no rss context. Submitting HWRM_VNIC_RSS_CFG request to firmware would hit a failure. The fix is to check the rss context. If no rss context, then don't submit the hwrm request. Signed-off-by: Shuanglin Wang Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index b944547656..06f196760f 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -2405,6 +2405,9 @@ bnxt_hwrm_vnic_rss_cfg_non_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic) struct hwrm_vnic_rss_cfg_output *resp = bp->hwrm_cmd_resp_addr; int rc = 0; + if (vnic->num_lb_ctxts == 0) + return rc; + HWRM_PREP(&req, HWRM_VNIC_RSS_CFG, BNXT_USE_CHIMP_MB); req.hash_type = rte_cpu_to_le_32(vnic->hash_type);