From patchwork Thu Jun 8 03:19:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 128366 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A00542C57; Thu, 8 Jun 2023 05:20:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 959BE42D39; Thu, 8 Jun 2023 05:20:29 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2129.outbound.protection.outlook.com [40.107.100.129]) by mails.dpdk.org (Postfix) with ESMTP id 354C241153; Thu, 8 Jun 2023 05:20:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FefR1hARUrC6e8psMxtpC2cdu2uE5YfOBSBAsaUJYZyVozfcIQkbdoNwp6djVwCdoeA7ZBtYovQtl7PJMovXdboCtezjl2PEpTYhfbqzuLtNtH5wC/OFUWa52/CPonxYhGvdZfppFJoZpmGw7+GLO5xUmCWCUQ91Q/60F1qUvIZSTYjWt8K1gvY/twkblNNHZvOVwUIH0KKKgL4cUvNXYWCthInn85e36hp+u9IXfrkYkb+L90/VHANEQZCIyy0vuKn/1pqB8+kA983hdRSU/HU3P82BtCUyOhnT3R3EhmLZ5ma+NBmbwIPQ+UdCCyJLCFE6PzvQoT8OVGb0T5bDZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VK4hxWT45xBPsSrsRTtRg82OYpPzGDpPDeSTABHWyBc=; b=XwKxX6ltc0MsbzPR3Q2981/XX2Gwu6TEVkHFWQSQopqTgxoxc45BsMeFWaNpbpQEKdsfBF7VuxSei/c1c+r2FumC/8kuYe0z5DCfiBu3T8D6JohkfuMyn2qy1obUPUUiCn9E7SZlTuAWSB7k4qGAiMpsibUblDUfiqJfZwsPIpRpcJF8Jys1VHBf0HFWZOAmcR5ojykcDEoZ+h5AW7rEvtroSLfNyN8NsQYXu4AY7EwWmrSceBRCJ9yAbOu1CtbO2BUdzEZSQ+wARGE7h7gTXY8diL0EMbF/L92lnKnuqxP2FzxjpXw1wiZbTPQW+M0ff2vRwUlpSPHwXK8dAZXYTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VK4hxWT45xBPsSrsRTtRg82OYpPzGDpPDeSTABHWyBc=; b=oYXJtkHAiHGPpg/Y8j6tZgeiWxjlQNo7u3FD3CHFhAGh9lx6UPTHYJ+1BqFjNoqQszt0Rqut9GLiuD+a68PcuZP7IAKMYTzI7q0PvX572lwQheByTXVUQtqeIpqT+E79hH4Q22tAl/gDWwkuW/yn0d+Y+pGg/aPP9dfQvFVXZM4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DM6PR13MB4432.namprd13.prod.outlook.com (2603:10b6:5:1b8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Thu, 8 Jun 2023 03:20:25 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::d2cb:a650:e1ce:2174]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::d2cb:a650:e1ce:2174%3]) with mapi id 15.20.6455.030; Thu, 8 Jun 2023 03:20:24 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH 2/4] net/nfp: fix TOS of IPv6 VXLAN encap flow action Date: Thu, 8 Jun 2023 11:19:54 +0800 Message-Id: <20230608031956.814684-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230608031956.814684-1-chaoyong.he@corigine.com> References: <20230608031956.814684-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SI2PR02CA0038.apcprd02.prod.outlook.com (2603:1096:4:196::22) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|DM6PR13MB4432:EE_ X-MS-Office365-Filtering-Correlation-Id: ea528873-f473-4ed3-d6f8-08db67cf4cb3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NFwASPfTffXxuVFwdFOC4WTbRIpzuGPIIzGGMQBLuL53oFats6DeVdZ2JkJ2Za1nOEitnIMbLI99/JZLBxwLxFv/Y5Y6miYs9RYZ9RxvTpCaqu56F0kDEhXXw2aIc0i7aiwoTY0Joz3iU8bL6ZJVVKbAaKzLJcScDv76kzNItcLqqGkXTiASJw6RW20WceNC120u/gfWZDADei/qncTkYQ6TumK+BRfgyUJzH8Wk0hGH28cjPeX3F1c4Z9oSimUQKEaYLhua1nw9isEvsTZGY+Wp7GBSOxtK9LHyAS+Cb8CH2iaaZ2vJZU2uwo3AhHJE733pRFm1DAOa9ts872IQhzPXdtMccWWeGveaE7oXiCFwD3kn71bRlLiTIjGPdpEm3L2+YxV7hEdYqOPIgE80F8UTNwpKafhPE9wvruAklFUXzH+1H4aYj7wwQFuOqK0BH7+femja+OboPVmwJQD/hB0jVBZIJMbAW70Gyox1REKHBgFMj13OMz7arxwIWNJa4mIULDFriKxKRpxiUuBnOIEFMWWBbkdg3RZ7G5Nj/bilglw6X2BweOMndbUNV8BhVvWs0BFiPeHELvg/uSMySHYDh+oA2ACEy5dW+H4+tuIu8EgM8OOthzptalgJ7DRu X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39840400004)(366004)(136003)(346002)(376002)(396003)(451199021)(478600001)(2906002)(2616005)(83380400001)(6506007)(1076003)(26005)(186003)(6512007)(86362001)(38100700002)(38350700002)(52116002)(6486002)(36756003)(6666004)(5660300002)(450100002)(8936002)(8676002)(41300700001)(66476007)(6916009)(4326008)(66946007)(66556008)(316002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Ih89Z85mzjtJfdLHcMzNFz2f9SbF?= =?utf-8?q?zgJ9M7wQ+9s72X68JQotdElF3J8qBD3ppwZoFmO1D2Pl34hpPpXC12PjJNucdF+9B?= =?utf-8?q?GYqP7KdHKwjsP8OTNW1YIYjQ7v0rztOHhOveEHBJupc20h1gSNwzITnBYriqJTGjX?= =?utf-8?q?7rAL2vL7/LltIlM0NMlQpDlTj0RH1LDrqGPO5APZNyyO8KCNKHNpU/dfpGsn5F5zG?= =?utf-8?q?kucW9v9d35WP9pjZgCbr0A5ib/3B2n8teHd7oVk8RYQZPRyiNhex3feJ2vRBVNUaP?= =?utf-8?q?sgAqOz6w63JIk15C03LpLDmcfenBipX1bvpCo2PMiZUlHgxyR52NfdhXcdc/4xRYi?= =?utf-8?q?f9AvTpzIkf2YqMbqLCi1AI9YF9zdG77NCax84kenQS8UhZvjvvvfWpcTh5bqjMAgz?= =?utf-8?q?RNPVq0WO1/oeCYTQqqFvMVIg3VZqFvc142B0CBi+Fh/Cssctjm4vId5idGSHCC0bC?= =?utf-8?q?ECvTmWu1SYmLOZloe4rWvSwqeEr3vsbl9PjY0jDhF88DPRhx7jYoR3Hrm2blE0dFP?= =?utf-8?q?AGWVymkTLEbe/A+avp9ENQcyQXPQOjx4Oy+MLpYWbUX87zrBSryplSUvIT7Oc9Uvd?= =?utf-8?q?oYfoDvPm3K3sV0jweZrx12KRnkhDn7c8ZTXUL1DRQqWf4uncuXQOv4Fwe67/zxKJG?= =?utf-8?q?4mNKrYPX0o28rB5WiDRnlcivhWZkkALE20fY2Y9Sm4aTNAooLiAyKTK4MDLn7DMHE?= =?utf-8?q?lM68rcJq+xu3G3OzTkTI1h4//Oo9mj34IcCDqQbgIMWrnvZvaQyqen9VMdTnAHrbj?= =?utf-8?q?x7BIkoRo6UwJiMtmLiDmchHf9SZCkekLUDdp5Zecub8wPeNHQqQBAHnFhNXriomEP?= =?utf-8?q?ju3G9ONcyKJN+BL9FMTUPUVR3432rW9QYNRebnxomy4FIGY2rDck3i88An3gSm7AF?= =?utf-8?q?LI0uYdPmCYhFA7kEtAkMm3RsYMFa1yoUrr24ZTYPDcZBBvdxzD9L+3DCkPYZyF8jK?= =?utf-8?q?jRpbcfAOOhH8lTblFhZwge4eJPIDY4rPtRavPpmYs4f8uQjXagO8TTZIOuhZaVR2e?= =?utf-8?q?zU/prwUipjK4y971WrzQil/1mgvc2RLc+8V6QDNK4IVEG7YvEfOy/mzpWuNG2na6i?= =?utf-8?q?/eG3T7ykp1fW2eURLp4DckWmIQuyXsOxKALa5yh3ORpDloFRdDC1hCeUm/WynDG9K?= =?utf-8?q?X7+LUGuw0vTO0FpSQINIGXrpIvw2SGG/F4rUjPZVVvZzjs9x6mbEq7McB15eLob0L?= =?utf-8?q?xYHAV+8wHJ1ECO0HUhnilEff+J01HNK1THDpzxd3BFmDAHsapLqvjizbsHRet/+ck?= =?utf-8?q?bwd1kB+2lCW9nuzB2QbXl63xx6g7yXFmySmIJ2JDXbSfJdhDuZOhI4hIYjiwNZAn/?= =?utf-8?q?UPqSa9x51fNE8Ff5fMRC/ogcKHO4pgHS886lCJ+F4GZfZE+9p6FvH3UxqSQqajMa6?= =?utf-8?q?A0zWKDty1AQHSZlaV4SQt8tOCd05qBSMO+XH0auDaX3XBlWirj13vkEGd5gcN9NuG?= =?utf-8?q?MA8HFMZZQy9kPS/V42GFym0u+vZMznyaTD6bhnaZZ5AYU32S/JZ0/tkNi61Koj1kQ?= =?utf-8?q?pD3cylHhSuYtSVaLfUeTcR2vd1cq77yfBQ=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea528873-f473-4ed3-d6f8-08db67cf4cb3 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 03:20:24.8014 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CCNcQYKh9zbdiD58EbkwMpqDLJK9VRCfKMy21LB8SE2ZlK6GO5iaGKiPCmQU1z9eSbhDbK4LylWTNzP27N1EFue+LbIqilhkGw7KpAlahIk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB4432 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic directly do shift operation on big endian data, fix it by convert the big endian data into CPU endian firstly. Fixes: c3b7254093c2 ("net/nfp: support IPv6 VXLAN encap flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 937fb390df..914afb85e3 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2743,6 +2743,7 @@ nfp_flow_action_vxlan_encap_v6(struct nfp_app_fw_flower *app_fw_flower, struct nfp_fl_rule_metadata *nfp_flow_meta, struct nfp_fl_tun *tun) { + uint8_t tos; uint64_t tun_id; struct nfp_fl_act_pre_tun *pre_tun; struct nfp_fl_act_set_tun *set_tun; @@ -2763,9 +2764,9 @@ nfp_flow_action_vxlan_encap_v6(struct nfp_app_fw_flower *app_fw_flower, set_tun = (struct nfp_fl_act_set_tun *)(act_data + act_pre_size); memset(set_tun, 0, act_set_size); tun_id = rte_be_to_cpu_32(vxlan->hdr.vx_vni); + tos = rte_be_to_cpu_32(ipv6->hdr.vtc_flow) >> RTE_IPV6_HDR_TC_SHIFT; nfp_flow_set_tun_process(set_tun, NFP_FL_TUN_VXLAN, tun_id, - ipv6->hdr.hop_limits, - (ipv6->hdr.vtc_flow >> RTE_IPV6_HDR_TC_SHIFT) & 0xff); + ipv6->hdr.hop_limits, tos); set_tun->tun_flags = vxlan->hdr.vx_flags; /* Send the tunnel neighbor cmsg to fw */