From patchwork Tue May 30 11:53:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srujana Challa X-Patchwork-Id: 127726 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD84F42BE2; Tue, 30 May 2023 13:53:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 853EB40A82; Tue, 30 May 2023 13:53:08 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 725F8406BC for ; Tue, 30 May 2023 13:53:07 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34UBLK2u009167 for ; Tue, 30 May 2023 04:53:06 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=WuaoUyDMuJeXqvAeaDLhZNKF/nSU21uzcoeQXsPRhCs=; b=Q4sXNY2WViVumFDs627QgZpORTzqDMVyURA3fMGYXKhCmnWTMYuIYALhGSuqdOvgV2Gr SZscOOyHlmXwiPpHKjOEZ+08o0LluDOf8CqHiNolJwqofRF7ppO8uaYGDEF4Lme1RFhw MG+E8haLHiHp0Zouvk7LjgM3IYSU7QMaO+00ICSEKJWVHGNhqmi+vz5ZvgADCweeFIcT uOf9DsMGgKULc8GBn4xcINps0LETXdW+BcuBjHrP22pLQe+eZuB87haIaHGVLBLx2eNI qeEQpFE9S+6SVopO3D9HHdg5JASUu4S/D4+5hQ8ZuiaTiZMpnBvD5Jips4cPL+PAWib+ wA== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3quhcm83ej-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 30 May 2023 04:53:06 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 30 May 2023 04:53:04 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 30 May 2023 04:53:04 -0700 Received: from localhost.localdomain (unknown [10.28.36.175]) by maili.marvell.com (Postfix) with ESMTP id 608DF3F70B1; Tue, 30 May 2023 04:53:02 -0700 (PDT) From: Srujana Challa To: , , , CC: , , Subject: [PATCH] event/cnxk: add wmb after steorl for event mode Date: Tue, 30 May 2023 17:23:01 +0530 Message-ID: <20230530115301.3472521-1-schalla@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Proofpoint-GUID: yqHp7xcKnQ0VmgAleX9q7glgLYsPEDE6 X-Proofpoint-ORIG-GUID: yqHp7xcKnQ0VmgAleX9q7glgLYsPEDE6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-30_08,2023-05-30_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org LMTST area can be overwritten before read by HW between to consecutive steorl operations. Hence, add wmb() after steorl op to make sure the lmtst operation is complete. Signed-off-by: Srujana Challa --- drivers/event/cnxk/cn10k_tx_worker.h | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/event/cnxk/cn10k_tx_worker.h b/drivers/event/cnxk/cn10k_tx_worker.h index c18786a14c..81fe31c4b9 100644 --- a/drivers/event/cnxk/cn10k_tx_worker.h +++ b/drivers/event/cnxk/cn10k_tx_worker.h @@ -43,7 +43,6 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct rte_mbuf *m, uint64_t *cmd, const uint64_t *txq_data, const uint32_t flags) { uint8_t lnum = 0, loff = 0, shft = 0; - uint16_t ref_cnt = m->refcnt; struct cn10k_eth_txq *txq; uintptr_t laddr; uint16_t segdw; @@ -98,10 +97,9 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct rte_mbuf *m, uint64_t *cmd, roc_lmt_submit_steorl(lmt_id, pa); - if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) { - if (ref_cnt > 1) - rte_io_wmb(); - } + /* Memory barrier to make sure lmtst store completes */ + rte_io_wmb(); + return 1; }