diff mbox series

[09/11] net/hns3: make code more clean

Message ID	20230529130940.1501-10-liudongdong3@huawei.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Ferruh Yigit
Headers	From: Dongdong Liu <liudongdong3@huawei.com> To: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>, <andrew.rybchenko@oktetlabs.ru>, <fengchengwen@huawei.com> CC: <stable@dpdk.org>, <lihuisong@huawei.com>, <liudongdong3@huawei.com>, <yisen.zhuang@huawei.com>, <huangdengdui@huawei.com> Subject: [PATCH 09/11] net/hns3: make code more clean Date: Mon, 29 May 2023 21:09:38 +0800 Message-ID: <20230529130940.1501-10-liudongdong3@huawei.com> In-Reply-To: <20230529130940.1501-1-liudongdong3@huawei.com> References: <20230529130940.1501-1-liudongdong3@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	net/hns3: add some bugfixes for hns3 \| [00/11] net/hns3: add some bugfixes for hns3 [01/11] net/hns3: fix uninitialized RTC time [02/11] net/hns3: fix unenabled RTC time after reset [03/11] net/hns3: add the uninitialization process of PTP [04/11] net/hns3: extract a PTP header file [05/11] net/hns3: fix mbuf leak when start rxq in resetting [06/11] net/hns3: fix mbuf leak when start rxq after resetting [07/11] net/hns3: fix no errcode returned when failed to init queue [08/11] net/hns3: fix uninitialized variable [09/11] net/hns3: make code more clean [10/11] net/hns3: fix inaccurate log [11/11] net/hns3: remove log redundant line break

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Dongdong Liu May 29, 2023, 1:09 p.m. UTC

  From: Dengdui Huang <huangdengdui@huawei.com>

This patch modify the code that violates the coding standards.

Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
---
 drivers/net/hns3/hns3_regs.c |  3 +--
 drivers/net/hns3/hns3_rxtx.c | 10 +++-------
 2 files changed, 4 insertions(+), 9 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/hns3/hns3_regs.c
index 5d6f92e4bb..be1be6a89c 100644
--- a/drivers/net/hns3/hns3_regs.c
+++ b/drivers/net/hns3/hns3_regs.c
@@ -385,10 +385,9 @@  hns3_dfx_reg_cmd_send(struct hns3_hw *hw, struct hns3_cmd_desc *desc,
 	hns3_cmd_setup_basic_desc(&desc[i], opcode, true);
 
 	ret = hns3_cmd_send(hw, desc, bd_num);
-	if (ret) {
+	if (ret)
 		hns3_err(hw, "fail to query dfx registers, opcode = 0x%04X, "
 			 "ret = %d.\n", opcode, ret);
-	}
 
 	return ret;
 }
diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c
index 2493748683..cf04dc857e 100644
--- a/drivers/net/hns3/hns3_rxtx.c
+++ b/drivers/net/hns3/hns3_rxtx.c
@@ -751,7 +751,7 @@  hns3pf_reset_all_tqps(struct hns3_hw *hw)
 		for (i = 0; i < hw->cfg_max_queues; i++) {
 			ret = hns3pf_reset_tqp(hw, i);
 			if (ret) {
-				hns3_err(hw, "fail to reset tqp, queue_id = %d, ret = %d.",
+				hns3_err(hw, "fail to reset tqp, queue_id = %u, ret = %d.",
 					 i, ret);
 				return ret;
 			}
@@ -829,15 +829,13 @@  hns3_send_reset_queue_cmd(struct hns3_hw *hw, uint16_t queue_id,
 {
 	struct hns3_reset_tqp_queue_cmd *req;
 	struct hns3_cmd_desc desc;
-	int queue_direction;
 	int ret;
 
 	hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_RESET_TQP_QUEUE_INDEP, false);
 
 	req = (struct hns3_reset_tqp_queue_cmd *)desc.data;
 	req->tqp_id = rte_cpu_to_le_16(queue_id);
-	queue_direction = queue_type == HNS3_RING_TYPE_TX ? 0 : 1;
-	req->queue_direction = rte_cpu_to_le_16(queue_direction);
+	req->queue_direction = queue_type == HNS3_RING_TYPE_TX ? 0 : 1;
 	hns3_set_bit(req->reset_req, HNS3_TQP_RESET_B, enable ? 1 : 0);
 
 	ret = hns3_cmd_send(hw, &desc, 1);
@@ -855,15 +853,13 @@  hns3_get_queue_reset_status(struct hns3_hw *hw, uint16_t queue_id,
 {
 	struct hns3_reset_tqp_queue_cmd *req;
 	struct hns3_cmd_desc desc;
-	int queue_direction;
 	int ret;
 
 	hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_RESET_TQP_QUEUE_INDEP, true);
 
 	req = (struct hns3_reset_tqp_queue_cmd *)desc.data;
 	req->tqp_id = rte_cpu_to_le_16(queue_id);
-	queue_direction = queue_type == HNS3_RING_TYPE_TX ? 0 : 1;
-	req->queue_direction = rte_cpu_to_le_16(queue_direction);
+	req->queue_direction = queue_type == HNS3_RING_TYPE_TX ? 0 : 1;
 
 	ret = hns3_cmd_send(hw, &desc, 1);
 	if (ret) {