[2/2] build: fix warning when running external command
Checks
Commit Message
Meson gives warnings on calls to run_command when there is
a missing "check" parameter. Most of the occurrences has been fixed.
Fixed the remaining one in this change.
Fixes: ecb904cc4596 ("build: fix warnings when running external commands")
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
config/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, May 29, 2023 at 01:57:51PM +0800, Ruifeng Wang wrote:
> Meson gives warnings on calls to run_command when there is
> a missing "check" parameter. Most of the occurrences has been fixed.
> Fixed the remaining one in this change.
>
> Fixes: ecb904cc4596 ("build: fix warnings when running external commands")
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
@@ -366,7 +366,7 @@ if max_numa_nodes == 'detect'
error('Discovery of max_numa_nodes not supported for cross-compilation.')
endif
# overwrite the default value with discovered values
- max_numa_nodes = run_command(get_numa_count_cmd).stdout().to_int()
+ max_numa_nodes = run_command(get_numa_count_cmd, check: true).stdout().to_int()
message('Found @0@ numa nodes'.format(max_numa_nodes))
dpdk_conf.set('RTE_MAX_NUMA_NODES', max_numa_nodes)
elif max_numa_nodes != 'default'