From patchwork Mon May 22 08:04:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 127143 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 348F942B6F; Mon, 22 May 2023 10:05:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 267A742D42; Mon, 22 May 2023 10:05:37 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2096.outbound.protection.outlook.com [40.107.100.96]) by mails.dpdk.org (Postfix) with ESMTP id 647A042D48 for ; Mon, 22 May 2023 10:05:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oBNZ8HP91oRarB7Ahf/gAf4nMll02dbWxmmgafK9rqkdd3cWI/AcNmqgO6jfc2KExHlWTAnfDIADzNrMq55dlIrz4D2z3R2dNokQ9CCRPhCb8lnlaechJHwOBu15/C4G2Z21JoYOYs9AZwydfgydmI6jDU1t/MpEf1PO0SO06I/aFWFGI5FGVLMYkP0Ptzv/UBLeBhHEB46NIjc6VLAA0svSknUPnNZxaBca0Sk8bgiivdzarK2SthifddVIyySzyp6fDkT6tAYExBpulFlj1BE80Nyn8Woe0LwUcoIC7IpCrsAch0OiboRTYrbycGZGC41qWRkMG0JeQiCrqxrngg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sHbrdda/Eyq00Apsxq5vUbxpMN772dEHwNBoLl8NBvo=; b=k6jgXweKdq0fWX1tGHRVos0aPkTcLB6q9Av1N8ID7t5UhuXlWTqnaX1bYeSbGUH2I9XMeJopY7nacImuRZOd1fctFP7M695QAvNYmiTm8ECoeJG6bzUK2atTuwmEO6/ZJx00txZwPqnNrbwtN4FcVrnwDVWzpLZo45czhg0PcQ6XDGgTQsRQoIxGikYdIn66LADiTGAd6zDpk4OKIwVmElaxn4u5kcnxhn8GIHxriYSIWif+EblF4WoKnIOl6sVG/nBNM9UlDag2GYry0N7VXs03W2BqQ5veZFklRf3/nzdU9yxIXo2v0ySgWPCCeFTiFd7LIf1yKdnU7EWrmhmGmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sHbrdda/Eyq00Apsxq5vUbxpMN772dEHwNBoLl8NBvo=; b=N2pCEKWBWz8fG4d9gwmtj0JOOYEKhQz7l9RD34a/C0zjsA3c9dvTDmADq/2wYBZVTPVVm4w+daDkDew28VXOnGavlzUz1w/AL+S943GWNTjULWMchnYVADU14wk8c+1j4eVHVPkdjOa8sUeS7En4hv0P0I1UOex+6+/Ma2hCeTQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SA1PR13MB6543.namprd13.prod.outlook.com (2603:10b6:806:3a3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.13; Mon, 22 May 2023 08:05:33 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ac2e:52b6:82ec:4994]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ac2e:52b6:82ec:4994%3]) with mapi id 15.20.6411.027; Mon, 22 May 2023 08:05:33 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Qin Ke , Chaoyong He Subject: [PATCH 4/5] net/nfp: remove logic of reporting packet type by hash type Date: Mon, 22 May 2023 16:04:59 +0800 Message-Id: <20230522080500.2014001-5-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230522080500.2014001-1-chaoyong.he@corigine.com> References: <20230522080500.2014001-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SG2PR03CA0109.apcprd03.prod.outlook.com (2603:1096:4:91::13) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SA1PR13MB6543:EE_ X-MS-Office365-Filtering-Correlation-Id: c8a84131-c871-4781-c705-08db5a9b512d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MG6+DzQ9QG/1egnJ3vtzJ2Hy2aH5E6GKsyiAcLefvx+ntdnlZuOWeZUwXtx0wFy1pKibMJNJvTIBhM7FduPyxsZ7FiqYr7XXo2LffDA2o9QhPAMUxlKrLo4lEGrrwAYlhzrLXSsBnEY2NwbT7ALzlunf1TkYcA7uR+Vj3n0489bN+U4kKL/gZe6Hp8g+lF/rGoB/byDsWIJnppsqEBYISaZHPbAk/7ed49TbrrCq6evEgrNpemzvaVYPcy8DzzUcg0OvbFjNwyFv7h8i4KGlB3NvFUx0GZEZV8zJ9mbn9fi7je0YuO6JyI0O3GwONBO0QLYkFPvNIzx8+GkONbioDSPQRBlBHAm10kBZSgNX109s6650cAKCzTjooHTMLIpNLHc2DHmNYFF1dKhTMY1cS73Af6qRxdiWu6uu8M8JJI56xvuq2XA0CBoUKLW8SMyzi4RJqpLj+To+Ji29TpJ9Uao9b0igYyoMI7PSPFFQ+VAr4yDDkbe2gw7AidQgIcPvSAUK6bPbiPb31SSpgJknuJ8HohKKcWQq1MvuPlaYpMCoX4L/JIKhpUhA+zv8wBX34CiY/zTZT+ynSHoTP3PfnO+hY8/KmWTPkB44Zmt0w4MvR80T2kLbCNrdo1ZFxiYD X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(396003)(136003)(346002)(39830400003)(376002)(451199021)(8676002)(8936002)(5660300002)(44832011)(83380400001)(186003)(26005)(1076003)(6512007)(6506007)(2616005)(86362001)(107886003)(38100700002)(38350700002)(41300700001)(6666004)(6486002)(52116002)(66476007)(66556008)(66946007)(316002)(6916009)(4326008)(36756003)(478600001)(54906003)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?V3da9sfyd9BBDUPJQaax75RSvA7u?= =?utf-8?q?mu6RqRX2pTZ/6eQ+eEzNRHdculzdCTZ/pTrDMHhOepphxTtAcqpNuHp5fT+53lU6+?= =?utf-8?q?L0gDIerUuK4sAFCoAnqVgnVA0Yo1iP/au7h4y39od4EKcvItN5mkS5Z5pqdJbSqur?= =?utf-8?q?qjnYaAChrAEYQMYPJpU94KV5SAA2wXQIzkwxxEkTKpXz3PeC6TDZPDj8eNq70efhD?= =?utf-8?q?L35+D2/8N4fsT5PRdaVy3K0AcA5LOecN+AdUp4poWyFO4cvWjVbTuZHuLgjQrX1ew?= =?utf-8?q?f4QhB98b7zWtD8lAZDck6sLtiFaz21k8jWWQFgqt3qXbstFejMAUVdxPeAikNvFH+?= =?utf-8?q?LlylmcUWBeNASnK118bChSNp9JVsYLnnU0WdptK1dvLjId7vFaP1T4QBJNge4W++N?= =?utf-8?q?l785xdhn4wYkAbii9Pj+5ZGSVuEqNpHC88y+Ort0cbQxOn62HlXQJsTyGD3uVLyhE?= =?utf-8?q?Gm2T6za82xioJAlM+wMiZ7LkaCeEfWbk2kuh6zyejrJPVbSdudKwaeu4zGHL+oV/I?= =?utf-8?q?gK8YmQ6EarfFTg5k50MWKUmnh7bEv4I9Z+KCYMR3o3xkocGOtf6Fbeu4elMnPE8D8?= =?utf-8?q?5bHW3yflhqCAxAoMGFE60otRV3PqiVneRlDLPprz+aUPA8jcu6LxE3jl6NkdC7VJ+?= =?utf-8?q?hMSvD/I5ave/oa7gEnRm4Is8gpioIxpNguAxhU2jQjlC05h8Ey1RFA3nGeR0OISAU?= =?utf-8?q?/rym/5e6d0M1vCtfUAqy2omy10leQZez1Yxrynu0SPOEOp1NmkUHqh8f6bloYi1oy?= =?utf-8?q?UcxwH2rRIWWz8OczvjX1eOm4NSwrXsBSTc2euW3JNj5dwScmJ8h+oCAMUhdvu0wyk?= =?utf-8?q?/+wf59I0FGc5A7/mAZoIqPw5hlhiqle8rJV55CwsqYwX6JHToaEcbB2NZMWS9HO2K?= =?utf-8?q?otlD/mtW/Ax6m6h58KsZcjjfZ/Bq3rlDn8ET6Zgl9Z9gptsoMVX034Nuo+INf+xRz?= =?utf-8?q?G+NT4ghcmPxjjLoVF0tBJCZdlBIY6jIodi5cCOg65lH4AwbwdE8jm6qDq9BLEEF8m?= =?utf-8?q?vf0aAFI7oTpwkECIJTVI7mbDl36YUQ8vc6BI+QunhJ67xl0lOMzRDB34MsRIZxiaV?= =?utf-8?q?BzLNnx6D8QWYfk4u11kjYpT5JLk5zKLt9Cdf6CTRo+NyW5nwPuNnmtifWPJRKA3th?= =?utf-8?q?3EIaT2KBaW0+SizNfJQCgcYk9WHZy/TpP9pJVLYBXLacHyVaehQIGbiDHs45+m1TV?= =?utf-8?q?NbsulBRPF8LOmTqqw+RRjh0KrnCZ4I5SwwXoy01/OTDYZCGKtyyaNoQodc92W4hIh?= =?utf-8?q?4DpMm7ygr5f8VWGnl3np9H+/KqWaw9yViV/bitaHzQfEF26kKk2dZ3Y6iTjsPO29R?= =?utf-8?q?ecjimzb39G46l8/NO1FAinGGYKk8mZbR3XmwfraSEJnLbN7168dgrmnMRHIbSZMWf?= =?utf-8?q?2AxIYK53x6kty7xpdemLHsLSasFPcNxRvatYIhmTFsDNKseCWEYIa3vxUc2HXswjD?= =?utf-8?q?ZiPjgj1FxiDPK59ycAvMpwtDv8MT6O6OVssoPmd5IK35riaTIL5xNjrX0EkOAlIXS?= =?utf-8?q?RNvADVJGZZdYm3U9xV5Ac/M4r8WJ6LafSA=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8a84131-c871-4781-c705-08db5a9b512d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 08:05:33.3238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4JAldeiiSwY8RGKZoL2/e7Cr/z/bAUIDfdDaGOx5unQmujF4iHXGHXVcENAcqboipFqnNID9+AMNfeWqcrrlABke9sqKIPxFM8UIz57zhnI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB6543 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Qin Ke Firstly, the hash type is originally used as the keyword to calculate rss hash value, not packet type itself. Secondly, there are some issues in the existing logic and it is conflict with packet type offload which to do next. Removes the logic of reporting packet type by hash type. Signed-off-by: Qin Ke Reviewed-by: Niklas Söderlund Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_rxtx.c | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index 2f7369315d..26bf1543ac 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -167,32 +167,6 @@ nfp_net_parse_meta_hash(const struct nfp_meta_parsed *meta, mbuf->hash.rss = meta->hash; mbuf->ol_flags |= RTE_MBUF_F_RX_RSS_HASH; - - switch (meta->hash_type) { - case NFP_NET_RSS_IPV4: - mbuf->packet_type |= RTE_PTYPE_INNER_L3_IPV4; - break; - case NFP_NET_RSS_IPV6: - mbuf->packet_type |= RTE_PTYPE_INNER_L3_IPV6; - break; - case NFP_NET_RSS_IPV6_EX: - mbuf->packet_type |= RTE_PTYPE_INNER_L3_IPV6_EXT; - break; - case NFP_NET_RSS_IPV4_TCP: - mbuf->packet_type |= RTE_PTYPE_INNER_L3_IPV6_EXT; - break; - case NFP_NET_RSS_IPV6_TCP: - mbuf->packet_type |= RTE_PTYPE_INNER_L3_IPV6_EXT; - break; - case NFP_NET_RSS_IPV4_UDP: - mbuf->packet_type |= RTE_PTYPE_INNER_L3_IPV6_EXT; - break; - case NFP_NET_RSS_IPV6_UDP: - mbuf->packet_type |= RTE_PTYPE_INNER_L3_IPV6_EXT; - break; - default: - mbuf->packet_type |= RTE_PTYPE_INNER_L4_MASK; - } } /*