From patchwork Fri May 12 14:21:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 126838 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D91842AE6; Fri, 12 May 2023 16:21:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 439B942FA0; Fri, 12 May 2023 16:21:58 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 1FB9042D3E for ; Fri, 12 May 2023 16:21:56 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34C90j3q021725; Fri, 12 May 2023 07:21:56 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=y10ORc5P1TFKtFpxbXGDgrE0JP9Yp7C1B4QZBKUn5E0=; b=NM0LwR8OlXq44hUEkrjexbHjriWNca5d6/3x9a4kZUDPEamiMfciUpmhprUEICmQ3hjH 4FS7W/GJOyqQ/1PBnyzgkEOAf1q0BJkGotzwcsFRxgG1lW1Qr586Ttv3Uvsqt8FFB7JI J1ke2+/oag+LeOvB2loUjCPiTzRvtoFXuB1Ah10cmzle4Ov7TzgmUUCxW/GtRufV1YHB QxGU5a1D8RhNNdxuqHY8wKglVWblX4xaqdazUjk8csEB+X1HVW8odkf7UPvct9t4/ucx 6aYAzx0Db4hLUP/UT1gYH/hBwvNcuGziTjIV+SSGabc0zUE0Vlpwe7u7g9/rb+LM9t4f Ig== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3qh9tk2yd0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 12 May 2023 07:21:56 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Fri, 12 May 2023 07:21:54 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Fri, 12 May 2023 07:21:54 -0700 Received: from BG-LT92004.corp.innovium.com (unknown [10.193.65.175]) by maili.marvell.com (Postfix) with ESMTP id C09673F7097; Fri, 12 May 2023 07:21:49 -0700 (PDT) From: Anoob Joseph To: Akhil Goyal , Fan Zhang , Ciara Power CC: Hemant Agrawal , Gagandeep Singh , Jerin Jacob , Tejasree Kondoj , Subject: [PATCH] test/crypto: remove redundant code Date: Fri, 12 May 2023 19:51:48 +0530 Message-ID: <20230512142148.262-1-anoobj@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Proofpoint-GUID: ogkdUlBDg9bqWkIhH67cnMtYL0z62oyO X-Proofpoint-ORIG-GUID: ogkdUlBDg9bqWkIhH67cnMtYL0z62oyO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-12_08,2023-05-05_01,2023-02-09_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Code for registering raw API tests for various PMDs are repeated. Add common routine to avoid duplication of code. Signed-off-by: Anoob Joseph Acked-by: Akhil Goyal Acked-by: Ciara Power --- app/test/test_cryptodev.c | 40 ++++++++++----------------------------- 1 file changed, 10 insertions(+), 30 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index d212e71ba6..f44e8b3101 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -17462,13 +17462,11 @@ test_cryptodev_bcmfs(void) } static int -test_cryptodev_qat_raw_api(void) +run_cryptodev_raw_testsuite(const char *pmd_name) { - static const char *pmd_name = RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD); int ret; - ret = require_feature_flag(pmd_name, RTE_CRYPTODEV_FF_SYM_RAW_DP, - "RAW API"); + ret = require_feature_flag(pmd_name, RTE_CRYPTODEV_FF_SYM_RAW_DP, "RAW API"); if (ret) return ret; @@ -17479,6 +17477,12 @@ test_cryptodev_qat_raw_api(void) return ret; } +static int +test_cryptodev_qat_raw_api(void) +{ + return run_cryptodev_raw_testsuite(RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD)); +} + static int test_cryptodev_cn9k(void) { @@ -17494,37 +17498,13 @@ test_cryptodev_cn10k(void) static int test_cryptodev_dpaa2_sec_raw_api(void) { - static const char *pmd_name = RTE_STR(CRYPTODEV_NAME_DPAA2_SEC_PMD); - int ret; - - ret = require_feature_flag(pmd_name, RTE_CRYPTODEV_FF_SYM_RAW_DP, - "RAW API"); - if (ret) - return ret; - - global_api_test_type = CRYPTODEV_RAW_API_TEST; - ret = run_cryptodev_testsuite(pmd_name); - global_api_test_type = CRYPTODEV_API_TEST; - - return ret; + return run_cryptodev_raw_testsuite(RTE_STR(CRYPTODEV_NAME_DPAA2_SEC_PMD)); } static int test_cryptodev_dpaa_sec_raw_api(void) { - static const char *pmd_name = RTE_STR(CRYPTODEV_NAME_DPAA_SEC_PMD); - int ret; - - ret = require_feature_flag(pmd_name, RTE_CRYPTODEV_FF_SYM_RAW_DP, - "RAW API"); - if (ret) - return ret; - - global_api_test_type = CRYPTODEV_RAW_API_TEST; - ret = run_cryptodev_testsuite(pmd_name); - global_api_test_type = CRYPTODEV_API_TEST; - - return ret; + return run_cryptodev_raw_testsuite(RTE_STR(CRYPTODEV_NAME_DPAA_SEC_PMD)); } REGISTER_TEST_COMMAND(cryptodev_dpaa2_sec_raw_api_autotest,