diff mbox series

net/dpaa2: change threshold value

Message ID 20230508104133.3566-1-laitianli@tom.com (mailing list archive)
State Rejected, archived
Delegated to: Ferruh Yigit
Headers
Series net/dpaa2: change threshold value |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/intel-Testing success Testing PASS

Commit Message

Tianli Lai May 8, 2023, 10:41 a.m. UTC 
  this threshold value can be changed with function argument nb_rx_desc.

Signed-off-by: Tianli Lai <laitianli@tom.com>
---
 drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sachin Saxena (OSS) May 15, 2023, 8:16 a.m. UTC | #1 
On 5/8/2023 4:11 PM, Tianli Lai wrote:
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
> 
> 
> this threshold value can be changed with function argument nb_rx_desc.
> 
> Signed-off-by: Tianli Lai <laitianli@tom.com>
> ---
>   drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
> index 679f33ae1a..ad892ded4a 100644
> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
> @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
>                                                  dpaa2_q->cgid, &taildrop);
>                  } else {
>                          /*enabling per rx queue congestion control */
> -                       taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q;
> +                       taildrop.threshold = nb_rx_desc * 1024;
>                          taildrop.units = DPNI_CONGESTION_UNIT_BYTES;
>                          taildrop.oal = CONG_RX_OAL;
>                          DPAA2_PMD_DEBUG("Enabling Byte based Drop on queue= %d",
> --
> 2.27.0
> 
Hi Tianli,

The number of bytes based tail drop threshold value 
"CONG_THRESHOLD_RX_BYTES_Q" is an optimized value for dpaa2 platform. we 
concluded this value after multiple benchmark experiments in past. 
Although, number of frame based threshold value is "nb_rx_desc" based only.
We will further review this suggestion and get back.
Ferruh Yigit June 9, 2023, 2:20 p.m. UTC | #2 
On 5/15/2023 9:16 AM, Sachin Saxena (OSS) wrote:
> On 5/8/2023 4:11 PM, Tianli Lai wrote:
>> Caution: This is an external email. Please take care when clicking
>> links or opening attachments. When in doubt, report the message using
>> the 'Report this email' button
>>
>>
>> this threshold value can be changed with function argument nb_rx_desc.
>>
>> Signed-off-by: Tianli Lai <laitianli@tom.com>
>> ---
>>   drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c
>> b/drivers/net/dpaa2/dpaa2_ethdev.c
>> index 679f33ae1a..ad892ded4a 100644
>> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
>> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
>> @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
>>                                                  dpaa2_q->cgid,
>> &taildrop);
>>                  } else {
>>                          /*enabling per rx queue congestion control */
>> -                       taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q;
>> +                       taildrop.threshold = nb_rx_desc * 1024;
>>                          taildrop.units = DPNI_CONGESTION_UNIT_BYTES;
>>                          taildrop.oal = CONG_RX_OAL;
>>                          DPAA2_PMD_DEBUG("Enabling Byte based Drop on
>> queue= %d",
>> -- 
>> 2.27.0
>>
> Hi Tianli,
> 
> The number of bytes based tail drop threshold value
> "CONG_THRESHOLD_RX_BYTES_Q" is an optimized value for dpaa2 platform. we
> concluded this value after multiple benchmark experiments in past.
> Although, number of frame based threshold value is "nb_rx_desc" based only.
> We will further review this suggestion and get back.
> 

Hi Sachin, What is the status of this patch?
Ferruh Yigit Sept. 29, 2023, 1:50 p.m. UTC | #3 
On 6/9/2023 3:20 PM, Ferruh Yigit wrote:
> On 5/15/2023 9:16 AM, Sachin Saxena (OSS) wrote:
>> On 5/8/2023 4:11 PM, Tianli Lai wrote:
>>> Caution: This is an external email. Please take care when clicking
>>> links or opening attachments. When in doubt, report the message using
>>> the 'Report this email' button
>>>
>>>
>>> this threshold value can be changed with function argument nb_rx_desc.
>>>
>>> Signed-off-by: Tianli Lai <laitianli@tom.com>
>>> ---
>>>   drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c
>>> b/drivers/net/dpaa2/dpaa2_ethdev.c
>>> index 679f33ae1a..ad892ded4a 100644
>>> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
>>> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
>>> @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
>>>                                                  dpaa2_q->cgid,
>>> &taildrop);
>>>                  } else {
>>>                          /*enabling per rx queue congestion control */
>>> -                       taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q;
>>> +                       taildrop.threshold = nb_rx_desc * 1024;
>>>                          taildrop.units = DPNI_CONGESTION_UNIT_BYTES;
>>>                          taildrop.oal = CONG_RX_OAL;
>>>                          DPAA2_PMD_DEBUG("Enabling Byte based Drop on
>>> queue= %d",
>>> -- 
>>> 2.27.0
>>>
>> Hi Tianli,
>>
>> The number of bytes based tail drop threshold value
>> "CONG_THRESHOLD_RX_BYTES_Q" is an optimized value for dpaa2 platform. we
>> concluded this value after multiple benchmark experiments in past.
>> Although, number of frame based threshold value is "nb_rx_desc" based only.
>> We will further review this suggestion and get back.
>>
> 
> Hi Sachin, What is the status of this patch?
> 

Ping
Ferruh Yigit Nov. 2, 2023, 9:06 p.m. UTC | #4 
On 9/29/2023 2:50 PM, Ferruh Yigit wrote:
> On 6/9/2023 3:20 PM, Ferruh Yigit wrote:
>> On 5/15/2023 9:16 AM, Sachin Saxena (OSS) wrote:
>>> On 5/8/2023 4:11 PM, Tianli Lai wrote:
>>>> Caution: This is an external email. Please take care when clicking
>>>> links or opening attachments. When in doubt, report the message using
>>>> the 'Report this email' button
>>>>
>>>>
>>>> this threshold value can be changed with function argument nb_rx_desc.
>>>>
>>>> Signed-off-by: Tianli Lai <laitianli@tom.com>
>>>> ---
>>>>   drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c
>>>> b/drivers/net/dpaa2/dpaa2_ethdev.c
>>>> index 679f33ae1a..ad892ded4a 100644
>>>> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
>>>> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
>>>> @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
>>>>                                                  dpaa2_q->cgid,
>>>> &taildrop);
>>>>                  } else {
>>>>                          /*enabling per rx queue congestion control */
>>>> -                       taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q;
>>>> +                       taildrop.threshold = nb_rx_desc * 1024;
>>>>                          taildrop.units = DPNI_CONGESTION_UNIT_BYTES;
>>>>                          taildrop.oal = CONG_RX_OAL;
>>>>                          DPAA2_PMD_DEBUG("Enabling Byte based Drop on
>>>> queue= %d",
>>>> -- 
>>>> 2.27.0
>>>>
>>> Hi Tianli,
>>>
>>> The number of bytes based tail drop threshold value
>>> "CONG_THRESHOLD_RX_BYTES_Q" is an optimized value for dpaa2 platform. we
>>> concluded this value after multiple benchmark experiments in past.
>>> Although, number of frame based threshold value is "nb_rx_desc" based only.
>>> We will further review this suggestion and get back.
>>>
>>
>> Hi Sachin, What is the status of this patch?
>>
> 
> Ping
>

Hi Sachin, Hemant,

If you believe current threshold value is more optimized value, please
reject this patch, instead of letting it stuck around.

Or @Tianli if you have more arguments to prove this is better value, can
you please share them to help maintainers?
Hemant Agrawal Nov. 3, 2023, 3:58 p.m. UTC | #5 
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Friday, November 3, 2023 2:36 AM
> To: Sachin Saxena (OSS) <sachin.saxena@oss.nxp.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@nxp.com>
> Cc: dev@dpdk.org; Tianli Lai <laitianli@tom.com>
> Subject: Re: [PATCH] net/dpaa2: change threshold value
> Importance: High
> 
> On 9/29/2023 2:50 PM, Ferruh Yigit wrote:
> > On 6/9/2023 3:20 PM, Ferruh Yigit wrote:
> >> On 5/15/2023 9:16 AM, Sachin Saxena (OSS) wrote:
> >>> On 5/8/2023 4:11 PM, Tianli Lai wrote:
> >>>> Caution: This is an external email. Please take care when clicking
> >>>> links or opening attachments. When in doubt, report the message
> >>>> using the 'Report this email' button
> >>>>
> >>>>
> >>>> this threshold value can be changed with function argument
> nb_rx_desc.
> >>>>
> >>>> Signed-off-by: Tianli Lai <laitianli@tom.com>
> >>>> ---
> >>>>   drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
> >>>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c
> >>>> b/drivers/net/dpaa2/dpaa2_ethdev.c
> >>>> index 679f33ae1a..ad892ded4a 100644
> >>>> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
> >>>> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
> >>>> @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct
> rte_eth_dev
> >>>> *dev,
> >>>>                                                  dpaa2_q->cgid,
> >>>> &taildrop);
> >>>>                  } else {
> >>>>                          /*enabling per rx queue congestion control
> >>>> */
> >>>> -                       taildrop.threshold =
> >>>> CONG_THRESHOLD_RX_BYTES_Q;
> >>>> +                       taildrop.threshold = nb_rx_desc * 1024;
> >>>>                          taildrop.units =
> >>>> DPNI_CONGESTION_UNIT_BYTES;
> >>>>                          taildrop.oal = CONG_RX_OAL;
> >>>>                          DPAA2_PMD_DEBUG("Enabling Byte based Drop
> >>>> on queue= %d",
> >>>> --
> >>>> 2.27.0
> >>>>
> >>> Hi Tianli,
> >>>
> >>> The number of bytes based tail drop threshold value
> >>> "CONG_THRESHOLD_RX_BYTES_Q" is an optimized value for dpaa2
> >>> platform. we concluded this value after multiple benchmark
> experiments in past.
> >>> Although, number of frame based threshold value is "nb_rx_desc"
> based only.
> >>> We will further review this suggestion and get back.
> >>>
> >>
> >> Hi Sachin, What is the status of this patch?
> >>
> >
> > Ping
> >
> 
> Hi Sachin, Hemant,
> 
> If you believe current threshold value is more optimized value, please reject
> this patch, instead of letting it stuck around.

[Hemant] Yes, NACK for us for now.
 
> Or @Tianli if you have more arguments to prove this is better value, can you
> please share them to help maintainers?
diff mbox series

Patch

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 679f33ae1a..ad892ded4a 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -829,7 +829,7 @@  dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
 						dpaa2_q->cgid, &taildrop);
 		} else {
 			/*enabling per rx queue congestion control */
-			taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q;
+			taildrop.threshold = nb_rx_desc * 1024;
 			taildrop.units = DPNI_CONGESTION_UNIT_BYTES;
 			taildrop.oal = CONG_RX_OAL;
 			DPAA2_PMD_DEBUG("Enabling Byte based Drop on queue= %d",