diff mbox series

[v3,1/3] net/gve: switch license from MIT to BSD-3

Message ID 20230328094512.1796648-2-junfeng.guo@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series update license and copyright holders |

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

Junfeng Guo March 28, 2023, 9:45 a.m. UTC 
  Switch license from MIT to BSD-3 for GVE base code.
In the meantime, remove MIT license exception for GVE driver.

Signed-off-by: Rushil Gupta <rushilg@google.com>
Signed-off-by: Joshua Washington <joshwash@google.com>
Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
Signed-off-by: Jeroen de Borst <jeroendb@google.com>
---
 .mailmap                            | 1 +
 drivers/net/gve/base/gve.h          | 5 ++---
 drivers/net/gve/base/gve_adminq.c   | 5 ++---
 drivers/net/gve/base/gve_adminq.h   | 5 ++---
 drivers/net/gve/base/gve_desc.h     | 5 ++---
 drivers/net/gve/base/gve_desc_dqo.h | 5 ++---
 drivers/net/gve/base/gve_osdep.h    | 2 +-
 drivers/net/gve/base/gve_register.h | 5 ++---
 license/exceptions.txt              | 1 -
 9 files changed, 14 insertions(+), 20 deletions(-)

Comments

Ferruh Yigit March 28, 2023, 10:36 a.m. UTC | #1 
On 3/28/2023 10:45 AM, Junfeng Guo wrote:
> diff --git a/drivers/net/gve/base/gve_osdep.h b/drivers/net/gve/base/gve_osdep.h
> index 7cb73002f4..f7d87fec16 100644
> --- a/drivers/net/gve/base/gve_osdep.h
> +++ b/drivers/net/gve/base/gve_osdep.h
> @@ -1,5 +1,5 @@
>  /* SPDX-License-Identifier: BSD-3-Clause
> - * Copyright(C) 2022 Intel Corporation
> + * Copyright (c) 2022-2023 Google LLC
>   */

Is this intentional to move Copyright from Intel to Google?
Junfeng Guo March 29, 2023, 2:35 a.m. UTC | #2 
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Tuesday, March 28, 2023 18:36
> To: Guo, Junfeng <junfeng.guo@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Rushil Gupta <rushilg@google.com>; Joshua
> Washington <joshwash@google.com>; Jeroen de Borst
> <jeroendb@google.com>
> Subject: Re: [PATCH v3 1/3] net/gve: switch license from MIT to BSD-3
> 
> On 3/28/2023 10:45 AM, Junfeng Guo wrote:
> > diff --git a/drivers/net/gve/base/gve_osdep.h
> b/drivers/net/gve/base/gve_osdep.h
> > index 7cb73002f4..f7d87fec16 100644
> > --- a/drivers/net/gve/base/gve_osdep.h
> > +++ b/drivers/net/gve/base/gve_osdep.h
> > @@ -1,5 +1,5 @@
> >  /* SPDX-License-Identifier: BSD-3-Clause
> > - * Copyright(C) 2022 Intel Corporation
> > + * Copyright (c) 2022-2023 Google LLC
> >   */
> 
> Is this intentional to move Copyright from Intel to Google?

Oh, sorry! This is updated by mistake. 

In tradition, the osdep.h file is in Intel's copyright with 
BSD-3 License. So it should not be included in the patch 
as no License update for this file.
I'll fix this and put this change into 2nd one of patch set.

Thanks for the careful review!
diff mbox series

Patch

diff --git a/.mailmap b/.mailmap
index dc30369117..9d66fa727c 100644
--- a/.mailmap
+++ b/.mailmap
@@ -588,6 +588,7 @@  Jens Freimann <jfreimann@redhat.com> <jfreiman@redhat.com>
 Jeremy Plsek <jplsek@iol.unh.edu>
 Jeremy Spewock <jspewock@iol.unh.edu>
 Jerin Jacob <jerinj@marvell.com> <jerin.jacob@caviumnetworks.com> <jerinjacobk@gmail.com>
+Jeroen de Borst <jeroendb@google.com>
 Jerome Jutteau <jerome.jutteau@outscale.com>
 Jerry Hao OS <jerryhao@os.amperecomputing.com>
 Jerry Lilijun <jerry.lilijun@huawei.com>
diff --git a/drivers/net/gve/base/gve.h b/drivers/net/gve/base/gve.h
index 2dc4507acb..55b7c2688e 100644
--- a/drivers/net/gve/base/gve.h
+++ b/drivers/net/gve/base/gve.h
@@ -1,6 +1,5 @@ 
-/* SPDX-License-Identifier: MIT
- * Google Virtual Ethernet (gve) driver
- * Copyright (C) 2015-2022 Google, Inc.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2022-2023 Google LLC
  */
 
 #ifndef _GVE_H_
diff --git a/drivers/net/gve/base/gve_adminq.c b/drivers/net/gve/base/gve_adminq.c
index e745b709b2..3519a2217f 100644
--- a/drivers/net/gve/base/gve_adminq.c
+++ b/drivers/net/gve/base/gve_adminq.c
@@ -1,6 +1,5 @@ 
-/* SPDX-License-Identifier: MIT
- * Google Virtual Ethernet (gve) driver
- * Copyright (C) 2015-2022 Google, Inc.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2022-2023 Google LLC
  */
 
 #include "../gve_ethdev.h"
diff --git a/drivers/net/gve/base/gve_adminq.h b/drivers/net/gve/base/gve_adminq.h
index 05550119de..e6907fc16f 100644
--- a/drivers/net/gve/base/gve_adminq.h
+++ b/drivers/net/gve/base/gve_adminq.h
@@ -1,6 +1,5 @@ 
-/* SPDX-License-Identifier: MIT
- * Google Virtual Ethernet (gve) driver
- * Copyright (C) 2015-2022 Google, Inc.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2022-2023 Google LLC
  */
 
 #ifndef _GVE_ADMINQ_H
diff --git a/drivers/net/gve/base/gve_desc.h b/drivers/net/gve/base/gve_desc.h
index 006b36442f..c62563f754 100644
--- a/drivers/net/gve/base/gve_desc.h
+++ b/drivers/net/gve/base/gve_desc.h
@@ -1,6 +1,5 @@ 
-/* SPDX-License-Identifier: MIT
- * Google Virtual Ethernet (gve) driver
- * Copyright (C) 2015-2022 Google, Inc.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2022-2023 Google LLC
  */
 
 /* GVE Transmit Descriptor formats */
diff --git a/drivers/net/gve/base/gve_desc_dqo.h b/drivers/net/gve/base/gve_desc_dqo.h
index ee1afdecb8..d0887778d3 100644
--- a/drivers/net/gve/base/gve_desc_dqo.h
+++ b/drivers/net/gve/base/gve_desc_dqo.h
@@ -1,6 +1,5 @@ 
-/* SPDX-License-Identifier: MIT
- * Google Virtual Ethernet (gve) driver
- * Copyright (C) 2015-2022 Google, Inc.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2022-2023 Google LLC
  */
 
 /* GVE DQO Descriptor formats */
diff --git a/drivers/net/gve/base/gve_osdep.h b/drivers/net/gve/base/gve_osdep.h
index 7cb73002f4..f7d87fec16 100644
--- a/drivers/net/gve/base/gve_osdep.h
+++ b/drivers/net/gve/base/gve_osdep.h
@@ -1,5 +1,5 @@ 
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(C) 2022 Intel Corporation
+ * Copyright (c) 2022-2023 Google LLC
  */
 
 #ifndef _GVE_OSDEP_H_
diff --git a/drivers/net/gve/base/gve_register.h b/drivers/net/gve/base/gve_register.h
index c674167f31..615ceffc88 100644
--- a/drivers/net/gve/base/gve_register.h
+++ b/drivers/net/gve/base/gve_register.h
@@ -1,6 +1,5 @@ 
-/* SPDX-License-Identifier: MIT
- * Google Virtual Ethernet (gve) driver
- * Copyright (C) 2015-2022 Google, Inc.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2022-2023 Google LLC
  */
 
 #ifndef _GVE_REGISTER_H_
diff --git a/license/exceptions.txt b/license/exceptions.txt
index 1ded290eee..1bd4dbf8f7 100644
--- a/license/exceptions.txt
+++ b/license/exceptions.txt
@@ -16,5 +16,4 @@  SPDX Identifier     TB Approval Date  GB Approval Date  File name
 2.BSD-2-Clause      10/23/2019        12/18/2019        lib/eal/windows/include/getopt.h
 3.ISC AND
   BSD-2-Clause      10/23/2019        12/18/2019        lib/eal/windows/getopt.c
-4. MIT              10/19/2022        10/18/2022        drivers/net/gve/base/*
 ---------------------------------------------------------------------------------------------------