diff mbox series

acl: fix autotest failures on ppc64le with gcc 11

Message ID 20230322172933.461482-1-drc@linux.vnet.ibm.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series acl: fix autotest failures on ppc64le with gcc 11 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-unit-testing success Testing PASS

Commit Message

David Christensen March 22, 2023, 5:29 p.m. UTC 
  Original acl implementation of Altivec optimized code included an
explicit -O2 optimization level for a particular inlined function.
When DPDK is built with the default -O3 optimization level on gcc
11.x or later, the resulting code may generate a segmentation
fault as observed in acl_autotest.

Since there is no explicit reason given for the local function
optimization level in the original commit, and testing with gcc
versions 8.x through 12.x results in working code at all -O
optimization settings, the local optimization is removed.

Bugzilla ID: 1197
Cc: stable@dpdk.org

Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
Tested-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
---
 lib/acl/acl_run_altivec.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon March 28, 2023, 4:29 p.m. UTC | #1 
22/03/2023 18:29, David Christensen:
> Original acl implementation of Altivec optimized code included an
> explicit -O2 optimization level for a particular inlined function.
> When DPDK is built with the default -O3 optimization level on gcc
> 11.x or later, the resulting code may generate a segmentation
> fault as observed in acl_autotest.
> 
> Since there is no explicit reason given for the local function
> optimization level in the original commit, and testing with gcc
> versions 8.x through 12.x results in working code at all -O
> optimization settings, the local optimization is removed.
> 
> Bugzilla ID: 1197
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> Tested-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/lib/acl/acl_run_altivec.h b/lib/acl/acl_run_altivec.h
index 4dfe7a14b4..4556e1503b 100644
--- a/lib/acl/acl_run_altivec.h
+++ b/lib/acl/acl_run_altivec.h
@@ -102,7 +102,7 @@  acl_match_check_x4(int slot, const struct rte_acl_ctx *ctx, struct parms *parms,
 /*
  * Process 4 transitions (in 2 XMM registers) in parallel
  */
-static inline __attribute__((optimize("O2"))) xmm_t
+static __rte_always_inline xmm_t
 transition4(xmm_t next_input, const uint64_t *trans,
 	xmm_t *indices1, xmm_t *indices2)
 {