[0/5] fix race-condition of proactive error handling mode
Message ID | 20230301030610.49468-1-fengchengwen@huawei.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EA2E41DA4; Wed, 1 Mar 2023 04:12:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C225541611; Wed, 1 Mar 2023 04:12:43 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id EC05840A8A for <dev@dpdk.org>; Wed, 1 Mar 2023 04:12:40 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PRK5q6JBGzrSQ4; Wed, 1 Mar 2023 11:11:59 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 1 Mar 2023 11:12:38 +0800 From: Chengwen Feng <fengchengwen@huawei.com> To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>, <konstantin.ananyev@huawei.com> CC: <dev@dpdk.org> Subject: [PATCH 0/5] fix race-condition of proactive error handling mode Date: Wed, 1 Mar 2023 03:06:05 +0000 Message-ID: <20230301030610.49468-1-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Message
fengchengwen
March 1, 2023, 3:06 a.m. UTC
This patch fixes race-condition of proactive error handling mode, the discussion thread [1]. [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/ Chengwen Feng (5): ethdev: fix race-condition of proactive error handling mode net/hns3: replace fp ops config function net/bnxt: fix race-condition when report error recovery net/bnxt: use fp ops setup function app/testpmd: add error recovery usage demo app/test-pmd/testpmd.c | 80 +++++++++++++++++++++++++ app/test-pmd/testpmd.h | 4 +- doc/guides/prog_guide/poll_mode_drv.rst | 20 +++---- drivers/net/bnxt/bnxt_cpr.c | 18 +++--- drivers/net/bnxt/bnxt_ethdev.c | 9 +-- drivers/net/hns3/hns3_rxtx.c | 21 +------ lib/ethdev/ethdev_driver.c | 8 +++ lib/ethdev/ethdev_driver.h | 10 ++++ lib/ethdev/rte_ethdev.h | 32 ++++++---- lib/ethdev/version.map | 1 + 10 files changed, 143 insertions(+), 60 deletions(-)
Comments
On 3/1/2023 3:06 AM, Chengwen Feng wrote: > This patch fixes race-condition of proactive error handling mode, the > discussion thread [1]. > > [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/ > > Chengwen Feng (5): > ethdev: fix race-condition of proactive error handling mode > net/hns3: replace fp ops config function > net/bnxt: fix race-condition when report error recovery > net/bnxt: use fp ops setup function > app/testpmd: add error recovery usage demo > Hi Chengwen, This patch is old and as discussion get longer it became hard to follow/manage. If the issue is valid, can you please refresh the patchset? Sorry for the inconvenience.
Hi Ferruh, Thanks for the reminder. I will send a new version as soon as possible. Thanks. On 2023/9/21 19:12, Ferruh Yigit wrote: > On 3/1/2023 3:06 AM, Chengwen Feng wrote: >> This patch fixes race-condition of proactive error handling mode, the >> discussion thread [1]. >> >> [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/ >> >> Chengwen Feng (5): >> ethdev: fix race-condition of proactive error handling mode >> net/hns3: replace fp ops config function >> net/bnxt: fix race-condition when report error recovery >> net/bnxt: use fp ops setup function >> app/testpmd: add error recovery usage demo >> > > Hi Chengwen, > > This patch is old and as discussion get longer it became hard to > follow/manage. > > If the issue is valid, can you please refresh the patchset? > Sorry for the inconvenience. > > . >
Friendly ping. On 2023/10/20 18:07, Chengwen Feng wrote: > This patch fixes race-condition of proactive error handling mode, the > discussion thread [1]. > > [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/ > > Chengwen Feng (7): > ethdev: fix race-condition of proactive error handling mode > net/hns3: replace fp ops config function > net/bnxt: fix race-condition when report error recovery > net/bnxt: use fp ops setup function > app/testpmd: add error recovery usage demo > app/testpmd: extract event handling to event.c > doc: testpmd support event handling section > > --- > v2: > - extract event handling to event.c and document it, which address > Ferruh's comment. > - add ack-by from Konstantin Ananyev and Dongdong Liu. > > app/test-pmd/event.c | 390 +++++++++++++++++++ > app/test-pmd/meson.build | 1 + > app/test-pmd/parameters.c | 36 +- > app/test-pmd/testpmd.c | 247 +----------- > app/test-pmd/testpmd.h | 10 +- > doc/guides/prog_guide/poll_mode_drv.rst | 20 +- > doc/guides/testpmd_app_ug/event_handling.rst | 80 ++++ > doc/guides/testpmd_app_ug/index.rst | 1 + > drivers/net/bnxt/bnxt_cpr.c | 18 +- > drivers/net/bnxt/bnxt_ethdev.c | 9 +- > drivers/net/hns3/hns3_rxtx.c | 21 +- > lib/ethdev/ethdev_driver.c | 8 + > lib/ethdev/ethdev_driver.h | 10 + > lib/ethdev/rte_ethdev.h | 32 +- > lib/ethdev/version.map | 1 + > 15 files changed, 551 insertions(+), 333 deletions(-) > create mode 100644 app/test-pmd/event.c > create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst >
Hi Ferruh, I notice this patchset was delegated to you, so could you take a view? Thanks. On 2023/11/6 21:11, Chengwen Feng wrote: > This patch fixes race-condition of proactive error handling mode, the > discussion thread [1]. > > [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/ > > Chengwen Feng (7): > ethdev: fix race-condition of proactive error handling mode > net/hns3: replace fp ops config function > net/bnxt: fix race-condition when report error recovery > net/bnxt: use fp ops setup function > app/testpmd: add error recovery usage demo > app/testpmd: extract event handling to event.c > doc: testpmd support event handling section > > --- > v3: > - adjust the usage of RTE_ETH_EVENT_QUEUE_STATE in 7/7 commit. > - add ack-by from Konstantin Ananyev, Ajit Khaparde and Huisong Li. > v2: > - extract event handling to event.c and document it, which address > Ferruh's comment. > - add ack-by from Konstantin Ananyev and Dongdong Liu. > > app/test-pmd/event.c | 390 +++++++++++++++++++ > app/test-pmd/meson.build | 1 + > app/test-pmd/parameters.c | 36 +- > app/test-pmd/testpmd.c | 247 +----------- > app/test-pmd/testpmd.h | 10 +- > doc/guides/prog_guide/poll_mode_drv.rst | 20 +- > doc/guides/testpmd_app_ug/event_handling.rst | 81 ++++ > doc/guides/testpmd_app_ug/index.rst | 1 + > drivers/net/bnxt/bnxt_cpr.c | 18 +- > drivers/net/bnxt/bnxt_ethdev.c | 9 +- > drivers/net/hns3/hns3_rxtx.c | 21 +- > lib/ethdev/ethdev_driver.c | 8 + > lib/ethdev/ethdev_driver.h | 10 + > lib/ethdev/rte_ethdev.h | 32 +- > lib/ethdev/version.map | 1 + > 15 files changed, 552 insertions(+), 333 deletions(-) > create mode 100644 app/test-pmd/event.c > create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst >
Kindly ping. On 2023/12/5 10:30, fengchengwen wrote: > Hi Ferruh, > > I notice this patchset was delegated to you, so could you take a view? > > Thanks. > > On 2023/11/6 21:11, Chengwen Feng wrote: >> This patch fixes race-condition of proactive error handling mode, the >> discussion thread [1]. >> >> [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/ >> >> Chengwen Feng (7): >> ethdev: fix race-condition of proactive error handling mode >> net/hns3: replace fp ops config function >> net/bnxt: fix race-condition when report error recovery >> net/bnxt: use fp ops setup function >> app/testpmd: add error recovery usage demo >> app/testpmd: extract event handling to event.c >> doc: testpmd support event handling section >> >> --- >> v3: >> - adjust the usage of RTE_ETH_EVENT_QUEUE_STATE in 7/7 commit. >> - add ack-by from Konstantin Ananyev, Ajit Khaparde and Huisong Li. >> v2: >> - extract event handling to event.c and document it, which address >> Ferruh's comment. >> - add ack-by from Konstantin Ananyev and Dongdong Liu. >> >> app/test-pmd/event.c | 390 +++++++++++++++++++ >> app/test-pmd/meson.build | 1 + >> app/test-pmd/parameters.c | 36 +- >> app/test-pmd/testpmd.c | 247 +----------- >> app/test-pmd/testpmd.h | 10 +- >> doc/guides/prog_guide/poll_mode_drv.rst | 20 +- >> doc/guides/testpmd_app_ug/event_handling.rst | 81 ++++ >> doc/guides/testpmd_app_ug/index.rst | 1 + >> drivers/net/bnxt/bnxt_cpr.c | 18 +- >> drivers/net/bnxt/bnxt_ethdev.c | 9 +- >> drivers/net/hns3/hns3_rxtx.c | 21 +- >> lib/ethdev/ethdev_driver.c | 8 + >> lib/ethdev/ethdev_driver.h | 10 + >> lib/ethdev/rte_ethdev.h | 32 +- >> lib/ethdev/version.map | 1 + >> 15 files changed, 552 insertions(+), 333 deletions(-) >> create mode 100644 app/test-pmd/event.c >> create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst >> > . >
Hi Ferruh, Kindly ping for review. Thanks On 2024/1/15 9:44, fengchengwen wrote: > Kindly ping. > > On 2023/12/5 10:30, fengchengwen wrote: >> Hi Ferruh, >> >> I notice this patchset was delegated to you, so could you take a view? >> >> Thanks. >> >> On 2023/11/6 21:11, Chengwen Feng wrote: >>> This patch fixes race-condition of proactive error handling mode, the >>> discussion thread [1]. >>> >>> [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/ >>> >>> Chengwen Feng (7): >>> ethdev: fix race-condition of proactive error handling mode >>> net/hns3: replace fp ops config function >>> net/bnxt: fix race-condition when report error recovery >>> net/bnxt: use fp ops setup function >>> app/testpmd: add error recovery usage demo >>> app/testpmd: extract event handling to event.c >>> doc: testpmd support event handling section >>> >>> --- >>> v3: >>> - adjust the usage of RTE_ETH_EVENT_QUEUE_STATE in 7/7 commit. >>> - add ack-by from Konstantin Ananyev, Ajit Khaparde and Huisong Li. >>> v2: >>> - extract event handling to event.c and document it, which address >>> Ferruh's comment. >>> - add ack-by from Konstantin Ananyev and Dongdong Liu. >>> >>> app/test-pmd/event.c | 390 +++++++++++++++++++ >>> app/test-pmd/meson.build | 1 + >>> app/test-pmd/parameters.c | 36 +- >>> app/test-pmd/testpmd.c | 247 +----------- >>> app/test-pmd/testpmd.h | 10 +- >>> doc/guides/prog_guide/poll_mode_drv.rst | 20 +- >>> doc/guides/testpmd_app_ug/event_handling.rst | 81 ++++ >>> doc/guides/testpmd_app_ug/index.rst | 1 + >>> drivers/net/bnxt/bnxt_cpr.c | 18 +- >>> drivers/net/bnxt/bnxt_ethdev.c | 9 +- >>> drivers/net/hns3/hns3_rxtx.c | 21 +- >>> lib/ethdev/ethdev_driver.c | 8 + >>> lib/ethdev/ethdev_driver.h | 10 + >>> lib/ethdev/rte_ethdev.h | 32 +- >>> lib/ethdev/version.map | 1 + >>> 15 files changed, 552 insertions(+), 333 deletions(-) >>> create mode 100644 app/test-pmd/event.c >>> create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst >>> >> . >> > . >
Hi Ferruh, This patchset will modify lib/ethdev/, Could you help review it before RC1? Thanks On 2024/1/29 9:16, fengchengwen wrote: > Hi Ferruh, > > Kindly ping for review. > > Thanks > > On 2024/1/15 9:44, fengchengwen wrote: >> Kindly ping. >> >> On 2023/12/5 10:30, fengchengwen wrote: >>> Hi Ferruh, >>> >>> I notice this patchset was delegated to you, so could you take a view? >>> >>> Thanks. >>> >>> On 2023/11/6 21:11, Chengwen Feng wrote: >>>> This patch fixes race-condition of proactive error handling mode, the >>>> discussion thread [1]. >>>> >>>> [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/ >>>> >>>> Chengwen Feng (7): >>>> ethdev: fix race-condition of proactive error handling mode >>>> net/hns3: replace fp ops config function >>>> net/bnxt: fix race-condition when report error recovery >>>> net/bnxt: use fp ops setup function >>>> app/testpmd: add error recovery usage demo >>>> app/testpmd: extract event handling to event.c >>>> doc: testpmd support event handling section >>>> >>>> --- >>>> v3: >>>> - adjust the usage of RTE_ETH_EVENT_QUEUE_STATE in 7/7 commit. >>>> - add ack-by from Konstantin Ananyev, Ajit Khaparde and Huisong Li. >>>> v2: >>>> - extract event handling to event.c and document it, which address >>>> Ferruh's comment. >>>> - add ack-by from Konstantin Ananyev and Dongdong Liu. >>>> >>>> app/test-pmd/event.c | 390 +++++++++++++++++++ >>>> app/test-pmd/meson.build | 1 + >>>> app/test-pmd/parameters.c | 36 +- >>>> app/test-pmd/testpmd.c | 247 +----------- >>>> app/test-pmd/testpmd.h | 10 +- >>>> doc/guides/prog_guide/poll_mode_drv.rst | 20 +- >>>> doc/guides/testpmd_app_ug/event_handling.rst | 81 ++++ >>>> doc/guides/testpmd_app_ug/index.rst | 1 + >>>> drivers/net/bnxt/bnxt_cpr.c | 18 +- >>>> drivers/net/bnxt/bnxt_ethdev.c | 9 +- >>>> drivers/net/hns3/hns3_rxtx.c | 21 +- >>>> lib/ethdev/ethdev_driver.c | 8 + >>>> lib/ethdev/ethdev_driver.h | 10 + >>>> lib/ethdev/rte_ethdev.h | 32 +- >>>> lib/ethdev/version.map | 1 + >>>> 15 files changed, 552 insertions(+), 333 deletions(-) >>>> create mode 100644 app/test-pmd/event.c >>>> create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst >>>> >>> . >>> >> . >> > . >
Hi Ferruh, This patchset fixes potentially race-condition, could you help review and merge? Thanks On 2024/2/18 11:41, fengchengwen wrote: > Hi Ferruh, > > This patchset will modify lib/ethdev/, Could you help review it before RC1? > > Thanks > > On 2024/1/29 9:16, fengchengwen wrote: >> Hi Ferruh, >> >> Kindly ping for review. >> >> Thanks >> >> On 2024/1/15 9:44, fengchengwen wrote: >>> Kindly ping. >>> >>> On 2023/12/5 10:30, fengchengwen wrote: >>>> Hi Ferruh, >>>> >>>> I notice this patchset was delegated to you, so could you take a view? >>>> >>>> Thanks. >>>> >>>> On 2023/11/6 21:11, Chengwen Feng wrote: >>>>> This patch fixes race-condition of proactive error handling mode, the >>>>> discussion thread [1]. >>>>> >>>>> [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/ >>>>> >>>>> Chengwen Feng (7): >>>>> ethdev: fix race-condition of proactive error handling mode >>>>> net/hns3: replace fp ops config function >>>>> net/bnxt: fix race-condition when report error recovery >>>>> net/bnxt: use fp ops setup function >>>>> app/testpmd: add error recovery usage demo >>>>> app/testpmd: extract event handling to event.c >>>>> doc: testpmd support event handling section >>>>> >>>>> --- >>>>> v3: >>>>> - adjust the usage of RTE_ETH_EVENT_QUEUE_STATE in 7/7 commit. >>>>> - add ack-by from Konstantin Ananyev, Ajit Khaparde and Huisong Li. >>>>> v2: >>>>> - extract event handling to event.c and document it, which address >>>>> Ferruh's comment. >>>>> - add ack-by from Konstantin Ananyev and Dongdong Liu. >>>>> >>>>> app/test-pmd/event.c | 390 +++++++++++++++++++ >>>>> app/test-pmd/meson.build | 1 + >>>>> app/test-pmd/parameters.c | 36 +- >>>>> app/test-pmd/testpmd.c | 247 +----------- >>>>> app/test-pmd/testpmd.h | 10 +- >>>>> doc/guides/prog_guide/poll_mode_drv.rst | 20 +- >>>>> doc/guides/testpmd_app_ug/event_handling.rst | 81 ++++ >>>>> doc/guides/testpmd_app_ug/index.rst | 1 + >>>>> drivers/net/bnxt/bnxt_cpr.c | 18 +- >>>>> drivers/net/bnxt/bnxt_ethdev.c | 9 +- >>>>> drivers/net/hns3/hns3_rxtx.c | 21 +- >>>>> lib/ethdev/ethdev_driver.c | 8 + >>>>> lib/ethdev/ethdev_driver.h | 10 + >>>>> lib/ethdev/rte_ethdev.h | 32 +- >>>>> lib/ethdev/version.map | 1 + >>>>> 15 files changed, 552 insertions(+), 333 deletions(-) >>>>> create mode 100644 app/test-pmd/event.c >>>>> create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst >>>>> >>>> . >>>> >>> . >>> >> . >> > . >