diff mbox series

[v2] app/testpmd: fix flex item compilation error

Message ID 20230221100201.361765-1-rongweil@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v2] app/testpmd: fix flex item compilation error |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance fail Performance Testing issues
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Rongwei Liu Feb. 21, 2023, 10:02 a.m. UTC 
  When configuring meson with option "--optimization=1", gcc
complains "maybe-uninitialized" warning and it was treated as
error since Werror is enabled.

Assign fp to NULL at declaration can avoid this.

Bugzilla ID: 1163
Fixes: c8e25fbf1440 ("ethdev: add flow flex modify")
Cc: stable@dpdk.org

Reported-by: gaodaxue <daxuex.gao@intel.com>
Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Feb. 21, 2023, 8:09 p.m. UTC | #1 
21/02/2023 11:02, Rongwei Liu:
> When configuring meson with option "--optimization=1", gcc
> complains "maybe-uninitialized" warning and it was treated as
> error since Werror is enabled.
> 
> Assign fp to NULL at declaration can avoid this.

That's probably a false positive,
but I'm OK to workaround it this way, especially in a test application.

> Bugzilla ID: 1163
> Fixes: c8e25fbf1440 ("ethdev: add flow flex modify")
> Cc: stable@dpdk.org
> 
> Reported-by: gaodaxue <daxuex.gao@intel.com>
> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
> ---
> -	struct flex_item *fp;
> +	struct flex_item *fp = NULL;

Applied, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index f1991a5a9a..9309607f11 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -8992,7 +8992,7 @@  parse_vc_modify_field_level(struct context *ctx, const struct token *token,
 			 unsigned int size)
 {
 	struct rte_flow_action_modify_field *action;
-	struct flex_item *fp;
+	struct flex_item *fp = NULL;
 	uint32_t val;
 	struct buffer *out = buf;
 	char *end;