[1/2] net/gve: change offloading capability

  Google Virtual NIC is not doing IPv4 checksummimg.
Removed that capability from PMD.

Signed-off-by: Levend Sayar <levendsayar@gmail.com>
---
 drivers/net/gve/gve_ethdev.c | 1 -
 1 file changed, 1 deletion(-)
  

Makes sense. The virtual device only does L4 checksum.

Acked-by: Rushil Gupta <rushilg@google.com>

On Thu, Feb 16, 2023 at 10:58 AM Levend Sayar <levendsayar@gmail.com> wrote:

> Google Virtual NIC is not doing IPv4 checksummimg.
> Removed that capability from PMD.
>
> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
> ---
>  drivers/net/gve/gve_ethdev.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
> index 06d1b796c8..fef2458a16 100644
> --- a/drivers/net/gve/gve_ethdev.c
> +++ b/drivers/net/gve/gve_ethdev.c
> @@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
>         dev_info->rx_offload_capa = 0;
>         dev_info->tx_offload_capa =
>                 RTE_ETH_TX_OFFLOAD_MULTI_SEGS   |
> -               RTE_ETH_TX_OFFLOAD_IPV4_CKSUM   |
>                 RTE_ETH_TX_OFFLOAD_UDP_CKSUM    |
>                 RTE_ETH_TX_OFFLOAD_TCP_CKSUM    |
>                 RTE_ETH_TX_OFFLOAD_SCTP_CKSUM   |
> --
> 2.37.1 (Apple Git-137.1)
>
>
  

Thanks Rushil for acknowledging.

Best,
Levend


> On 16 Feb 2023, at 23:14, Rushil Gupta <rushilg@google.com> wrote:
> 
> Makes sense. The virtual device only does L4 checksum.
> 
> Acked-by: Rushil Gupta <rushilg@google.com <mailto:rushilg@google.com>>
> 
> On Thu, Feb 16, 2023 at 10:58 AM Levend Sayar <levendsayar@gmail.com <mailto:levendsayar@gmail.com>> wrote:
>> Google Virtual NIC is not doing IPv4 checksummimg.
>> Removed that capability from PMD.
>> 
>> Signed-off-by: Levend Sayar <levendsayar@gmail.com <mailto:levendsayar@gmail.com>>
>> ---
>>  drivers/net/gve/gve_ethdev.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
>> index 06d1b796c8..fef2458a16 100644
>> --- a/drivers/net/gve/gve_ethdev.c
>> +++ b/drivers/net/gve/gve_ethdev.c
>> @@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>>         dev_info->rx_offload_capa = 0;
>>         dev_info->tx_offload_capa =
>>                 RTE_ETH_TX_OFFLOAD_MULTI_SEGS   |
>> -               RTE_ETH_TX_OFFLOAD_IPV4_CKSUM   |
>>                 RTE_ETH_TX_OFFLOAD_UDP_CKSUM    |
>>                 RTE_ETH_TX_OFFLOAD_TCP_CKSUM    |
>>                 RTE_ETH_TX_OFFLOAD_SCTP_CKSUM   |
>> -- 
>> 2.37.1 (Apple Git-137.1)
>>
  

> -----Original Message-----
> From: Levend Sayar <levendsayar@gmail.com>
> Sent: Friday, February 17, 2023 02:58
> To: Guo, Junfeng <junfeng.guo@intel.com>
> Cc: dev@dpdk.org; Levend Sayar <levendsayar@gmail.com>
> Subject: [PATCH 1/2] net/gve: change offloading capability
> 
> Google Virtual NIC is not doing IPv4 checksummimg.
> Removed that capability from PMD.
> 
> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
> ---

Acked-by: Junfeng Guo <junfeng.guo@intel.com>

Regards,
Junfeng Guo
  

Thanks Junfeng for acknowledging.

Best,
Levend

> On 17 Feb 2023, at 12:11, Guo, Junfeng <junfeng.guo@intel.com> wrote:
> 
> 
> 
>> -----Original Message-----
>> From: Levend Sayar <levendsayar@gmail.com>
>> Sent: Friday, February 17, 2023 02:58
>> To: Guo, Junfeng <junfeng.guo@intel.com>
>> Cc: dev@dpdk.org; Levend Sayar <levendsayar@gmail.com>
>> Subject: [PATCH 1/2] net/gve: change offloading capability
>> 
>> Google Virtual NIC is not doing IPv4 checksummimg.
>> Removed that capability from PMD.
>> 
>> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
>> ---
> 
> Acked-by: Junfeng Guo <junfeng.guo@intel.com <mailto:junfeng.guo@intel.com>>
> 
> Regards,
> Junfeng Guo
  

On 2/17/2023 9:11 AM, Guo, Junfeng wrote:
> 
> 
>> -----Original Message-----
>> From: Levend Sayar <levendsayar@gmail.com>
>> Sent: Friday, February 17, 2023 02:58
>> To: Guo, Junfeng <junfeng.guo@intel.com>
>> Cc: dev@dpdk.org; Levend Sayar <levendsayar@gmail.com>
>> Subject: [PATCH 1/2] net/gve: change offloading capability
>>
>> Google Virtual NIC is not doing IPv4 checksummimg.
>> Removed that capability from PMD.
>>
>> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
>> ---
> 
> Acked-by: Junfeng Guo <junfeng.guo@intel.com>
> 
> Acked-by: Rushil Gupta <rushilg@google.com>
>


    Fixes: a46583cf43c8 ("net/gve: support Rx/Tx")
    Cc: stable@dpdk.org


Added Rushil's name to .mailmap while merging.

Patch 2/2 is not merged and it can progress independently.


Applied to dpdk-next-net/main, thanks.