From patchwork Thu Feb 16 18:10:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Levend Sayar X-Patchwork-Id: 124093 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE3A341CB3; Thu, 16 Feb 2023 19:11:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC74442F8C; Thu, 16 Feb 2023 19:11:08 +0100 (CET) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mails.dpdk.org (Postfix) with ESMTP id 3E36B42F8A for ; Thu, 16 Feb 2023 19:11:07 +0100 (CET) Received: by mail-wr1-f42.google.com with SMTP id o15so2671883wrc.9 for ; Thu, 16 Feb 2023 10:11:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Oppuw8KotV7UBXPe8HyebM/9M7japcec//WQbunru3k=; b=hdfDS5wI1lIGeZgDncdoSYmpx3ww7A6FJmTHHO7Ug+cdpV5RbMQfdGo2BorHdVUnH7 lJaFW1m4zSYF9COda6w6ogksr88P5v4iPfJzQzsPMoyfSsqn46gWC4povK3Hq8dWN+d2 uiN2sRnMAv3kHOHVRhZSmibaIGcNgyGhMhVauA09xIbYQzIj6W0PvRKGc4buzqkRehr/ 6OHGr1+dGzDmdUSHQT+dPXigSHcDN0DFTWE39HwOVEpsQ8OZ5vgkJz6ca8RK4sJ34kwQ 73AXTR5KVuyU/2HpKiMBCgWXi70lmHzXqTCR21TIeG4YaCy4FyUpGR1ZxMgIH10mkjC/ jzTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Oppuw8KotV7UBXPe8HyebM/9M7japcec//WQbunru3k=; b=6KDxUcZL+XX3YD9ww05jkQ4BI3dayVMrggal3MO58L5D0IBEK59Yu9KzB3oJsRzg7i C43ems8wieBmziX7706gL4mZeen5QCG8dQ3WflutoxrxMZO2WWcBTBAOIU4xIJVDsWuK feqz4sEMKQeAjkS4W5zT5+CoOu1/+K8oq3G3fgrRdukxZRqOd7AVzS+CJDugub4zZnoV 5/b1DIA0cdQVP/18mhczD7Pb5+o8VB5F1VWrfBn3KdKS5Ko5F8WevRkoJNJQMvmvXWCL S2YVzmD1R/4a5JxKcYQ7b3yXCgiOYli+1YrzfvTSy/0Q0l9dClVG49cADkHHRU4Vxu8h sKLA== X-Gm-Message-State: AO0yUKVkX7IG2eTwMuRNBKl6SJyfoPWqzU+TujhJPIjAtySl7MIXGxuw w3/ouzaaE+VTAGBnZmc29Z8= X-Google-Smtp-Source: AK7set/htZeCjFEBgggVXYuH1ZWZgB+c36NBaNxe5kLezke0JEWE3h+Eb8r3aR5KhvCXEHKf3HoI5A== X-Received: by 2002:a5d:6b8e:0:b0:2c5:6277:d4fe with SMTP id n14-20020a5d6b8e000000b002c56277d4femr5091317wrx.27.1676571066983; Thu, 16 Feb 2023 10:11:06 -0800 (PST) Received: from localhost.localdomain ([176.41.28.141]) by smtp.gmail.com with ESMTPSA id x16-20020adfdcd0000000b002c54d97b1ecsm1989679wrm.72.2023.02.16.10.11.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 16 Feb 2023 10:11:06 -0800 (PST) From: Levend Sayar To: junfeng.guo@intel.com Cc: dev@dpdk.org, Levend Sayar Subject: [PATCH v2 4/4] net/gve: add standard and extended statistics Date: Thu, 16 Feb 2023 21:10:25 +0300 Message-Id: <20230216181025.23485-4-levendsayar@gmail.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) In-Reply-To: <20230216181025.23485-1-levendsayar@gmail.com> References: <20230216181025.23485-1-levendsayar@gmail.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org NIC statistics are enhanced with rx/tx queue errors. Signed-off-by: Levend Sayar --- drivers/net/gve/gve_ethdev.c | 49 +++++++++++++++++++++++++++++++----- 1 file changed, 43 insertions(+), 6 deletions(-) diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c index 735847ede7..88adec7253 100644 --- a/drivers/net/gve/gve_ethdev.c +++ b/drivers/net/gve/gve_ethdev.c @@ -417,6 +417,18 @@ gve_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats, unsigned i if (--requested == 0) return n; xstat++; + + xstat->id = indx++; + xstat->value = rxq->errors; + if (--requested == 0) + return n; + xstat++; + + xstat->id = indx++; + xstat->value = rxq->no_mbufs; + if (--requested == 0) + return n; + xstat++; } for (i = 0; i < dev->data->nb_tx_queues; i++) { @@ -432,10 +444,16 @@ gve_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats, unsigned i if (--requested == 0) return n; xstat++; + + xstat->id = indx++; + xstat->value = txq->errors; + if (--requested == 0) + return n; + xstat++; } } - return (dev->data->nb_tx_queues + dev->data->nb_rx_queues) * 2; + return (dev->data->nb_rx_queues * 4) + (dev->data->nb_tx_queues * 3); } static int @@ -454,29 +472,48 @@ gve_xstats_get_names(struct rte_eth_dev *dev, struct rte_eth_xstat_name *xstats_ uint16_t i; for (i = 0; i < dev->data->nb_rx_queues; i++) { - snprintf(xstats_name->name, sizeof(xstats_name->name), "rx_q%d_packets", i); + snprintf(xstats_name->name, sizeof(xstats_name->name), + "rx_q%d_packets", i); + if (--requested == 0) + return n; + xstats_name++; + snprintf(xstats_name->name, sizeof(xstats_name->name), + "rx_q%d_bytes", i); if (--requested == 0) return n; xstats_name++; - snprintf(xstats_name->name, sizeof(xstats_name->name), "rx_q%d_bytes", i); + snprintf(xstats_name->name, sizeof(xstats_name->name), + "rx_q%d_errors", i); + if (--requested == 0) + return n; + xstats_name++; + snprintf(xstats_name->name, sizeof(xstats_name->name), + "rx_q%d_no_mbufs", i); if (--requested == 0) return n; xstats_name++; } for (i = 0; i < dev->data->nb_tx_queues; i++) { - snprintf(xstats_name->name, sizeof(xstats_name->name), "tx_q%d_packets", i); + snprintf(xstats_name->name, sizeof(xstats_name->name), + "tx_q%d_packets", i); + if (--requested == 0) + return n; + xstats_name++; + snprintf(xstats_name->name, sizeof(xstats_name->name), + "tx_q%d_bytes", i); if (--requested == 0) return n; xstats_name++; - snprintf(xstats_name->name, sizeof(xstats_name->name), "tx_q%d_bytes", i); + snprintf(xstats_name->name, sizeof(xstats_name->name), + "tx_q%d_errors", i); if (--requested == 0) return n; xstats_name++; } } - return (dev->data->nb_tx_queues + dev->data->nb_rx_queues) * 2; + return (dev->data->nb_rx_queues * 4) + (dev->data->nb_tx_queues * 3); } static const struct eth_dev_ops gve_eth_dev_ops = {