From patchwork Tue Feb 7 16:07:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srikanth Yalavarthi X-Patchwork-Id: 123350 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEDED41C30; Tue, 7 Feb 2023 17:11:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9ACF42FE6; Tue, 7 Feb 2023 17:08:04 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 32A0342D4A for ; Tue, 7 Feb 2023 17:07:36 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 317BL2vr005847 for ; Tue, 7 Feb 2023 08:07:35 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=D4y33g2oviPLrfjSR9zcfXXMI8zlhLDX2QjNNJ+dCxg=; b=kRQKe7jPHAbBfMJzXopqf9nMvRU4pk04xBtqfv4E0vTqlHANb/R9uixiqk2uw4hL6cM7 EEFXFi+PZx0PrqXj/ClJQFbX/N+okVKp3Ct90J+6ZB0Si47DKXQcVSLDxnxCO0jUdI9S KOjmQDOdwIQOJyk71MRJirGyKr4n4/TYauvorw7VLxC4bDA38xsZMnnE2Xqnhqogr4Wr G0WckU2Qq48FcLls8NtXVL5wHO5tht+0p6IRy4Ps8AptdPzTxUGmJQN7A8wcWpo1bX7x HJKO2YMH8Pb6eAMjgchPxU5QJIvUyK+pJXq47Zzq6K2VvbR4PcyBTjxchAOF8yfYVZFq bg== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3nhqrtmsnd-14 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 07 Feb 2023 08:07:35 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 7 Feb 2023 08:07:30 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend Transport; Tue, 7 Feb 2023 08:07:30 -0800 Received: from ml-host-33.caveonetworks.com (unknown [10.110.143.233]) by maili.marvell.com (Postfix) with ESMTP id 376B03F708D; Tue, 7 Feb 2023 08:07:30 -0800 (PST) From: Srikanth Yalavarthi To: Srikanth Yalavarthi CC: , , , , , Subject: [PATCH v5 30/39] ml/cnxk: add support to get and reset device stats Date: Tue, 7 Feb 2023 08:07:10 -0800 Message-ID: <20230207160719.1307-31-syalavarthi@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230207160719.1307-1-syalavarthi@marvell.com> References: <20221208200220.20267-1-syalavarthi@marvell.com> <20230207160719.1307-1-syalavarthi@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: CO6YMdtuCSsLm95WhWqFTq71fHlb7eCF X-Proofpoint-ORIG-GUID: CO6YMdtuCSsLm95WhWqFTq71fHlb7eCF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-07_07,2023-02-06_03,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Enabled support to get and reset ML device stats. Device stats include number of requests enqueued/dequeued and error count. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 55 ++++++++++++++++++++++++++++++++-- drivers/ml/cnxk/cn10k_ml_ops.h | 3 ++ 2 files changed, 55 insertions(+), 3 deletions(-) diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c index 23a9ca4ff2..c38f018a50 100644 --- a/drivers/ml/cnxk/cn10k_ml_ops.c +++ b/drivers/ml/cnxk/cn10k_ml_ops.c @@ -159,6 +159,10 @@ cn10k_ml_qp_create(const struct rte_ml_dev *dev, uint16_t qp_id, uint32_t nb_des qp->queue.tail = 0; qp->queue.wait_cycles = ML_CN10K_CMD_TIMEOUT * plt_tsc_hz(); qp->nb_desc = nb_desc; + qp->stats.enqueued_count = 0; + qp->stats.dequeued_count = 0; + qp->stats.enqueue_err_count = 0; + qp->stats.dequeue_err_count = 0; /* Initialize job command */ for (i = 0; i < qp->nb_desc; i++) { @@ -678,6 +682,38 @@ cn10k_ml_dev_queue_pair_setup(struct rte_ml_dev *dev, uint16_t queue_pair_id, return 0; } +static int +cn10k_ml_dev_stats_get(struct rte_ml_dev *dev, struct rte_ml_dev_stats *stats) +{ + struct cn10k_ml_qp *qp; + int qp_id; + + for (qp_id = 0; qp_id < dev->data->nb_queue_pairs; qp_id++) { + qp = dev->data->queue_pairs[qp_id]; + stats->enqueued_count += qp->stats.enqueued_count; + stats->dequeued_count += qp->stats.dequeued_count; + stats->enqueue_err_count += qp->stats.enqueue_err_count; + stats->dequeue_err_count += qp->stats.dequeue_err_count; + } + + return 0; +} + +static void +cn10k_ml_dev_stats_reset(struct rte_ml_dev *dev) +{ + struct cn10k_ml_qp *qp; + int qp_id; + + for (qp_id = 0; qp_id < dev->data->nb_queue_pairs; qp_id++) { + qp = dev->data->queue_pairs[qp_id]; + qp->stats.enqueued_count = 0; + qp->stats.dequeued_count = 0; + qp->stats.enqueue_err_count = 0; + qp->stats.dequeue_err_count = 0; + } +} + static int cn10k_ml_dev_dump(struct rte_ml_dev *dev, FILE *fp) { @@ -1467,15 +1503,23 @@ static __rte_always_inline void cn10k_ml_result_update(struct rte_ml_dev *dev, int qp_id, struct cn10k_ml_result *result, struct rte_ml_op *op) { - PLT_SET_USED(dev); - PLT_SET_USED(qp_id); - struct cn10k_ml_dev *mldev; + struct cn10k_ml_qp *qp; if (likely(result->error_code.u64 == 0)) { + if (likely(qp_id >= 0)) { + qp = dev->data->queue_pairs[qp_id]; + qp->stats.dequeued_count++; + } + op->impl_opaque = result->error_code.u64; op->status = RTE_ML_OP_STATUS_SUCCESS; } else { + if (likely(qp_id >= 0)) { + qp = dev->data->queue_pairs[qp_id]; + qp->stats.dequeue_err_count++; + } + /* Handle driver error */ if (result->error_code.s.etype == ML_ETYPE_DRIVER) { mldev = dev->data->dev_private; @@ -1549,6 +1593,7 @@ cn10k_ml_enqueue_burst(struct rte_ml_dev *dev, uint16_t qp_id, struct rte_ml_op jcmdq_full: queue->head = head; + qp->stats.enqueued_count += count; return count; } @@ -1697,6 +1742,10 @@ struct rte_ml_dev_ops cn10k_ml_ops = { .dev_queue_pair_setup = cn10k_ml_dev_queue_pair_setup, .dev_queue_pair_release = cn10k_ml_dev_queue_pair_release, + /* Stats ops */ + .dev_stats_get = cn10k_ml_dev_stats_get, + .dev_stats_reset = cn10k_ml_dev_stats_reset, + /* Model ops */ .model_load = cn10k_ml_model_load, .model_unload = cn10k_ml_model_unload, diff --git a/drivers/ml/cnxk/cn10k_ml_ops.h b/drivers/ml/cnxk/cn10k_ml_ops.h index 1784900cff..65ae8b44f3 100644 --- a/drivers/ml/cnxk/cn10k_ml_ops.h +++ b/drivers/ml/cnxk/cn10k_ml_ops.h @@ -58,6 +58,9 @@ struct cn10k_ml_qp { /* Request queue */ struct cn10k_ml_queue queue; + + /* Statistics per queue-pair */ + struct rte_ml_dev_stats stats; }; /* Device ops */