diff mbox series

doc: rebuild all Sphinx guides

Message ID 20230207084352.3325416-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series doc: rebuild all Sphinx guides |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Thomas Monjalon Feb. 7, 2023, 8:43 a.m. UTC 
  On some systems, Sphinx is lazy enough to not recompile an RST file,
even if it contains a link pointing to a file which has been removed.

In order to detect such broken links,
the option "-a" is used to always rebuild all.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Marchand Feb. 7, 2023, 8:54 a.m. UTC | #1 
On Tue, Feb 7, 2023 at 9:44 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> On some systems, Sphinx is lazy enough to not recompile an RST file,
> even if it contains a link pointing to a file which has been removed.
>
> In order to detect such broken links,
> the option "-a" is used to always rebuild all.

I can't reproduce such behavior, but the principle looks ok to me and
I did not notice a difference in terms of time spending generating the
documentation.

>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

We have no guide describing Sphinx, I'd rather update this patch title
like "doc: rebuild all guides with Sphinx".
Reviewed-by: David Marchand <david.marchand@redhat.com>
Thomas Monjalon Feb. 7, 2023, 9:09 a.m. UTC | #2 
07/02/2023 09:54, David Marchand:
> On Tue, Feb 7, 2023 at 9:44 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > On some systems, Sphinx is lazy enough to not recompile an RST file,
> > even if it contains a link pointing to a file which has been removed.
> >
> > In order to detect such broken links,
> > the option "-a" is used to always rebuild all.
> 
> I can't reproduce such behavior, but the principle looks ok to me and
> I did not notice a difference in terms of time spending generating the
> documentation.

I think your system behaves with -a option forced somewhere.

> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> We have no guide describing Sphinx, I'd rather update this patch title
> like "doc: rebuild all guides with Sphinx".

Yes

> Reviewed-by: David Marchand <david.marchand@redhat.com>
Thomas Monjalon Feb. 14, 2023, 11:31 a.m. UTC | #3 
07/02/2023 10:09, Thomas Monjalon:
> 07/02/2023 09:54, David Marchand:
> > On Tue, Feb 7, 2023 at 9:44 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > On some systems, Sphinx is lazy enough to not recompile an RST file,
> > > even if it contains a link pointing to a file which has been removed.
> > >
> > > In order to detect such broken links,
> > > the option "-a" is used to always rebuild all.
> > 
> > I can't reproduce such behavior, but the principle looks ok to me and
> > I did not notice a difference in terms of time spending generating the
> > documentation.
> 
> I think your system behaves with -a option forced somewhere.
> 
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > 
> > We have no guide describing Sphinx, I'd rather update this patch title
> > like "doc: rebuild all guides with Sphinx".
> 
> Yes
> 
> > Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied
diff mbox series

Patch

diff --git a/doc/guides/meson.build b/doc/guides/meson.build
index 03b8bee567..51f81da2e3 100644
--- a/doc/guides/meson.build
+++ b/doc/guides/meson.build
@@ -7,7 +7,7 @@  if not sphinx.found()
     subdir_done()
 endif
 
-extra_sphinx_args = []
+extra_sphinx_args = ['-a']
 if get_option('werror')
     extra_sphinx_args += '-W'
 endif