diff mbox series

[1/7] member: replace zero length array with flex array

Message ID 20230113215205.125767-2-stephen@networkplumber.org (mailing list archive)
State Rejected, archived
Delegated to: Thomas Monjalon
Headers
Series replace zero length arrays |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Jan. 13, 2023, 9:51 p.m. UTC 
  Zero length arrays are GNU extension. Replace with
standard flex array.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/member/rte_member_heap.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tyler Retzlaff Jan. 14, 2023, 12:19 a.m. UTC | #1 
On Fri, Jan 13, 2023 at 01:51:59PM -0800, Stephen Hemminger wrote:
> Zero length arrays are GNU extension. Replace with
> standard flex array.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/member/rte_member_heap.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/member/rte_member_heap.h b/lib/member/rte_member_heap.h
> index 9c4a01aebe95..ab6319bc2de4 100644
> --- a/lib/member/rte_member_heap.h
> +++ b/lib/member/rte_member_heap.h
> @@ -26,7 +26,7 @@ struct hash {
>  	uint16_t bkt_cnt;
>  	uint16_t num_item;
>  	uint32_t seed;
> -	struct hash_bkt buckets[0];
> +	struct hash_bkt buckets[];
>  };
>  
>  struct node {
> -- 

i suppose arguably this series depends on the series Bruce is putting
up defaulting the minimum C standard to C99 since technically that's the
minimum needed for the flexible array members.

Series-acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Stephen Hemminger Jan. 14, 2023, 12:36 a.m. UTC | #2 
On Fri, 13 Jan 2023 16:19:21 -0800
Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:

> On Fri, Jan 13, 2023 at 01:51:59PM -0800, Stephen Hemminger wrote:
> > Zero length arrays are GNU extension. Replace with
> > standard flex array.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  lib/member/rte_member_heap.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/member/rte_member_heap.h b/lib/member/rte_member_heap.h
> > index 9c4a01aebe95..ab6319bc2de4 100644
> > --- a/lib/member/rte_member_heap.h
> > +++ b/lib/member/rte_member_heap.h
> > @@ -26,7 +26,7 @@ struct hash {
> >  	uint16_t bkt_cnt;
> >  	uint16_t num_item;
> >  	uint32_t seed;
> > -	struct hash_bkt buckets[0];
> > +	struct hash_bkt buckets[];
> >  };
> >  
> >  struct node {
> > --   
> 
> i suppose arguably this series depends on the series Bruce is putting
> up defaulting the minimum C standard to C99 since technically that's the
> minimum needed for the flexible array members.
> 
> Series-acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> 

There is already flex array usage in several places in DPDK.
Therefore this won't be raising the requirements.
Tyler Retzlaff Jan. 14, 2023, 12:42 a.m. UTC | #3 
On Fri, Jan 13, 2023 at 04:36:10PM -0800, Stephen Hemminger wrote:
> On Fri, 13 Jan 2023 16:19:21 -0800
> Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
> 
> > On Fri, Jan 13, 2023 at 01:51:59PM -0800, Stephen Hemminger wrote:
> > > Zero length arrays are GNU extension. Replace with
> > > standard flex array.
> > > 
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > ---
> > >  lib/member/rte_member_heap.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/lib/member/rte_member_heap.h b/lib/member/rte_member_heap.h
> > > index 9c4a01aebe95..ab6319bc2de4 100644
> > > --- a/lib/member/rte_member_heap.h
> > > +++ b/lib/member/rte_member_heap.h
> > > @@ -26,7 +26,7 @@ struct hash {
> > >  	uint16_t bkt_cnt;
> > >  	uint16_t num_item;
> > >  	uint32_t seed;
> > > -	struct hash_bkt buckets[0];
> > > +	struct hash_bkt buckets[];
> > >  };
> > >  
> > >  struct node {
> > > --   
> > 
> > i suppose arguably this series depends on the series Bruce is putting
> > up defaulting the minimum C standard to C99 since technically that's the
> > minimum needed for the flexible array members.
> > 
> > Series-acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > 
> 
> There is already flex array usage in several places in DPDK.
> Therefore this won't be raising the requirements.

agreed.
diff mbox series

Patch

diff --git a/lib/member/rte_member_heap.h b/lib/member/rte_member_heap.h
index 9c4a01aebe95..ab6319bc2de4 100644
--- a/lib/member/rte_member_heap.h
+++ b/lib/member/rte_member_heap.h
@@ -26,7 +26,7 @@  struct hash {
 	uint16_t bkt_cnt;
 	uint16_t num_item;
 	uint32_t seed;
-	struct hash_bkt buckets[0];
+	struct hash_bkt buckets[];
 };
 
 struct node {