From patchwork Wed Jan 11 19:49:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Vesker X-Patchwork-Id: 121839 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59D05423AF; Wed, 11 Jan 2023 20:49:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02F6340A7D; Wed, 11 Jan 2023 20:49:37 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2073.outbound.protection.outlook.com [40.107.223.73]) by mails.dpdk.org (Postfix) with ESMTP id 45AB540693 for ; Wed, 11 Jan 2023 20:49:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fiJzAhxN05sdHWlSnH4JM1ZhFC7YKZaG9dYJBznkX45AXeiaxKC51JkxSt2OfwT/hOVLr1MWNnQz7FZHYWSI3Wh5Q4ROh5JkAEmN4FK/EVu2LXV/WJh0SxC3+4nCcIFGm0EFDQp1SBAx/ksOZnOzviWfDKKLIoDhCQhFg74djseMGUi+jAHLlDVJPlf5ZjaGWa2AeFCTzof7RzXdMRyo/JWtV1ornUdsTYLoFpFcpHsEasLOWH2FcGmCtdoCNUrUCyLTmbiOCEnJpn8su3P8lkrow3QZxHVWu+0CocUblVwqBUdr233e3Nw7/5aFoGT4SjNM+/LHzkIvRu3EVITtXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v+mPbFx1Dw7kpOdZdYyKlyHhsfJjOOaIufdrOxkq/JU=; b=iVETa++O7QA3DPJzN+gOlYIYir2XtoTqgI/Y7YD/aaIFu2pahqzUk41ohzZze7uozyIpiNx/n6jLq6Yvde/JhJRvpQag6FACpJzn7JA7HHWRh/4XXj+UGeAMKl61ioACEombvE1JNrzOedEqcqftYSRd4Osbdj+4DiI8ShzQFx/HeUjx3lMsByiFl7ATMZKO4STuAq1YILb1UdrX9Iz6jlPYeLfTncVZgdqvjvfyeKFph8IohYGP+sNCkwxaUAtlb2cA0R1K5cuVg+uXlxBo8jIMSTEwZm3MHqlKg91Pom5SAfV5CrUq7qDoU01gPEkHtnmK6DdUvSG7y6kYoQYb+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v+mPbFx1Dw7kpOdZdYyKlyHhsfJjOOaIufdrOxkq/JU=; b=sl1Vns1ck3dbXUz5KJINqsSdrWUUqL+0CjCuYT3BSZyN6oQYqITMogri2An0U61xbUKPliJcSySy/7wPLCJy7VHz51q0dwcwp6He91Y1llcCs0+p3DFpqrJWcdH8ttymCpY2SquYCsDURkgbImqycL0S8fckeJsGg2IyyBvWX0jABRlcT96HtVat/ikoBqgtceMG++pztnhPqkj6vBVpRWqDzR5wvS8YFr0vCdr/Wzahtyz0gRwpFqkqhwVbX32mioyPZg+4khTa66tTcGPxnjGPoRQoo9xSDHXzS37+r/AdfU4FX8+4zp69Xdiz00WQkm1W/vWk7shrAuAGeVdg5Q== Received: from MW4PR04CA0326.namprd04.prod.outlook.com (2603:10b6:303:82::31) by MW4PR12MB7214.namprd12.prod.outlook.com (2603:10b6:303:229::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 19:49:33 +0000 Received: from CO1NAM11FT033.eop-nam11.prod.protection.outlook.com (2603:10b6:303:82:cafe::5f) by MW4PR04CA0326.outlook.office365.com (2603:10b6:303:82::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Wed, 11 Jan 2023 19:49:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT033.mail.protection.outlook.com (10.13.174.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Wed, 11 Jan 2023 19:49:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 11 Jan 2023 11:49:23 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 11 Jan 2023 11:49:21 -0800 From: Alex Vesker To: , , , , Matan Azrad CC: , Subject: [PATCH] net/mlx5/hws: fix memory leak on general pool db init Date: Wed, 11 Jan 2023 21:49:03 +0200 Message-ID: <20230111194903.27180-1-valex@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT033:EE_|MW4PR12MB7214:EE_ X-MS-Office365-Filtering-Correlation-Id: 230343b8-1cde-4836-7a9c-08daf40cf656 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4QulAxDprdP5+njRtPehc8NDQFlH5d6kSxOZlt6aSsCNDdf4EJeTkP0B1A+jtrXBEsmdjJ3yqx7//faEyzI9J7wqSxLaa+B2a5vHr8tFSFCNGOTovSoV9KtBMDwjlvDejExWcp9LemzDFdJjR1jTGgacDK1CAjaXYXv6oWGRrmHi0cB6NBsQxsZGoNZq/qVcquvJEbB2Jm1SiFWy34JDX+Vj0NS03irnCEuh8Rm6Ot1zJObIUvNFiF7RvAqlfFGLMn6GrYy+fUP6tfV/rOveko7qSPy40J1ZHC+1PGK9zSq+mZc+QAfxD7eMDcQM8ZYjhgQkXCI9Xt8c6BGtctW81YKrYlxgIAPjtfElAvP3ZMwlmXmGaGNxZPubfZ4A4wSTZFveuiQerP4A2yAS6ygJ+GrIhyeih4yMwjNOHppmY3LjSNYR62KKXkm6YVNozd3ERU4bAFYayLiLaCLFY0vaBwFSwytDD26UE//7Qs0KZFDsiBm8GZRfQ/PP4Ndo23yYbJb0q7YmAFoANCnod0e8Ln6ot66iZFTQ61qaUDfBrYISPnMJQu9lBQLbqNfrlBd81O74fVFl7P6syZIIjP0ftYIK4LNNHXz2uPar0SKnuovIF67mxD7f5WckRXfkPnoUoXXBn8KBEl1eVIQa5fkHtnw5KSZTOGiJn26B5DDOaXdUoGriKVXgNdBUrWUPjPUmniZ8z3tghf2algjgi8N9BA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199015)(46966006)(36840700001)(40470700004)(41300700001)(40460700003)(110136005)(47076005)(70206006)(426003)(4326008)(36756003)(336012)(55016003)(54906003)(8676002)(2616005)(70586007)(1076003)(86362001)(36860700001)(82310400005)(356005)(7636003)(40480700001)(82740400003)(8936002)(6636002)(83380400001)(5660300002)(316002)(2906002)(7696005)(186003)(26005)(6666004)(107886003)(478600001)(6286002)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 19:49:33.4431 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 230343b8-1cde-4836-7a9c-08daf40cf656 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT033.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7214 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On elemend db init we allocated the element_manager which was unused and not freed. Fixes: b4dd7bcb0dcbe ("net/mlx5/hws: add pool and buddy") Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_pool.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_pool.c b/drivers/net/mlx5/hws/mlx5dr_pool.c index fdbd3d438d..af6a5c743b 100644 --- a/drivers/net/mlx5/hws/mlx5dr_pool.c +++ b/drivers/net/mlx5/hws/mlx5dr_pool.c @@ -464,13 +464,6 @@ static void mlx5dr_pool_general_element_db_uninit(struct mlx5dr_pool *pool) */ static int mlx5dr_pool_general_element_db_init(struct mlx5dr_pool *pool) { - pool->db.element_manager = simple_calloc(1, sizeof(*pool->db.element_manager)); - if (!pool->db.element_manager) { - DR_LOG(ERR, "No mem for general elemnt_manager"); - rte_errno = ENOMEM; - return rte_errno; - } - pool->p_db_uninit = &mlx5dr_pool_general_element_db_uninit; pool->p_get_chunk = &mlx5dr_pool_general_element_db_get_chunk; pool->p_put_chunk = &mlx5dr_pool_general_element_db_put_chunk;