From patchwork Mon Jan 2 11:46:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 121503 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7322A00C2; Mon, 2 Jan 2023 12:47:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DB1942D1D; Mon, 2 Jan 2023 12:47:09 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 01BB742BC9 for ; Mon, 2 Jan 2023 12:47:07 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3026uiC5005113; Mon, 2 Jan 2023 03:47:07 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=I7tcyxpuq3y3x2lYKYvkimGpAftWEZFtkjeAH6jFDKs=; b=CC9RfDFlcBWR7o/aG/xNbFGaLDtwWYob2yqju+pYLoBNDHD1NTVp0eQsxq38253xGIX/ /A57x8htpWsVR/GQDJS1d7Hhd2KTcX0lxQ4VmWNH4eSQHaIsnaNyRWYWx4VDCrrtr4HE UECZKbjRdIKCoBgSsWHzPVuG1G677HQIykdyv77b75XEAF9PmkU31W7QB6U1qCw8xqBs sQCmunkWH1NMT4BYQe8NqNWDxP/52YjW6KgNR+ex6YtFsLHwD2ZS9xokvp8m9ICuxUsH Xz4JXKUKU36bYjClIUXC7jbMveZ99K/kziUM4oani1kfBR4KrfsFhLTjjay4WoJEAT5e 7g== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3mtkauu20t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 02 Jan 2023 03:47:06 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 2 Jan 2023 03:47:05 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.42 via Frontend Transport; Mon, 2 Jan 2023 03:47:05 -0800 Received: from BG-LT92004.corp.innovium.com (unknown [10.193.74.65]) by maili.marvell.com (Postfix) with ESMTP id 7C0E53F7085; Mon, 2 Jan 2023 03:47:01 -0800 (PST) From: Anoob Joseph To: Ciara Power , Akhil Goyal CC: Gagandeep Singh , Hemant Agrawal , Jerin Jacob , Tejasree Kondoj , Subject: [PATCH 2/3] app/crypto-perf: fix invalid SPI Date: Mon, 2 Jan 2023 17:16:54 +0530 Message-ID: <20230102114655.300-2-anoobj@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230102114655.300-1-anoobj@marvell.com> References: <20230102114655.300-1-anoobj@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: ec_xf-U1qJ6ejNegPh_RdjrbS9jqarmx X-Proofpoint-ORIG-GUID: ec_xf-U1qJ6ejNegPh_RdjrbS9jqarmx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-02_06,2022-12-30_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org As per IPsec specification (RFC 4303) SPI zero is reserved. Using lcore_id directly would mean SPI 0 would also be attempted. This may lead to failure on an otherwise compliant implementation. Fixes: 28dde5da503e ("app/crypto-perf: support lookaside IPsec") Signed-off-by: Anoob Joseph --- app/test-crypto-perf/cperf_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cperf_ops.c index 61a3967697..4a1c9feb1c 100644 --- a/app/test-crypto-perf/cperf_ops.c +++ b/app/test-crypto-perf/cperf_ops.c @@ -722,7 +722,7 @@ create_ipsec_session(struct rte_mempool *sess_mp, .action_type = RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL, .protocol = RTE_SECURITY_PROTOCOL_IPSEC, {.ipsec = { - .spi = rte_lcore_id(), + .spi = rte_lcore_id() + 1, /**< For testing sake, lcore_id is taken as SPI so that * for every core a different session is created. */