diff mbox series

[v1,1/2] net/i40e: fix unsupported flow rule transfer attribute

Message ID 20221226003715.615278-2-stevex.yang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series fix unsupported flow rule transfer attribute |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Steve Yang Dec. 26, 2022, 12:37 a.m. UTC 
  i40e doesn't support transfer attribute of flow rule,
ignore it when validating rule attributes.

Fixes: 86eb05d6350b ("net/i40e: add flow validate function")

Signed-off-by: Steve Yang <stevex.yang@intel.com>
---
 drivers/net/i40e/i40e_flow.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Qi Zhang Jan. 17, 2023, 1:26 a.m. UTC | #1 
> -----Original Message-----
> From: Yang, SteveX <stevex.yang@intel.com>
> Sent: Monday, December 26, 2022 8:37 AM
> To: dev@dpdk.org
> Cc: Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi
> Z <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>
> Subject: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer attribute
> 
> i40e doesn't support transfer attribute of flow rule, ignore it when validating
> rule attributes.
> 
> Fixes: 86eb05d6350b ("net/i40e: add flow validate function")

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
Qi Zhang Jan. 17, 2023, 1:26 a.m. UTC | #2 
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Tuesday, January 17, 2023 9:27 AM
> To: 'Yang, SteveX' <stevex.yang@intel.com>; dev@dpdk.org
> Cc: Zhang, Yuying <Yuying.Zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Yang, Qiming <qiming.yang@intel.com>
> Subject: RE: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer
> attribute
> 
> 
> 
> > -----Original Message-----
> > From: Yang, SteveX <stevex.yang@intel.com>
> > Sent: Monday, December 26, 2022 8:37 AM
> > To: dev@dpdk.org
> > Cc: Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang,
> > Qi Z <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>
> > Subject: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer
> > attribute
> >
> > i40e doesn't support transfer attribute of flow rule, ignore it when
> > validating rule attributes.
> >
> > Fixes: 86eb05d6350b ("net/i40e: add flow validate function")

Also added Cc stable.
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> Applied to dpdk-next-net-intel.
> 
> Thanks
> Qi
diff mbox series

Patch

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index 65a826d51c..67df77890a 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -1236,6 +1236,14 @@  i40e_flow_parse_attr(const struct rte_flow_attr *attr,
 		return -rte_errno;
 	}
 
+	/* Not supported */
+	if (attr->transfer) {
+		rte_flow_error_set(error, EINVAL,
+				   RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,
+				   attr, "Not support transfer.");
+		return -rte_errno;
+	}
+
 	/* Not supported */
 	if (attr->priority) {
 		rte_flow_error_set(error, EINVAL,