net/nfp: store counter reset before zeroing flow query
Checks
Commit Message
The reset flag in the query structure are cleared by mistake, cause
the flow count never be reset, so the query API will always has count
value even the flow has stopped, and this will cause the flow never
been aged.
Fixes: 30ecce522732 ("net/nfp: support flow API")
Cc: chaoyong.he@corigine.com
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
drivers/net/nfp/nfp_flow.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
@@ -3809,6 +3809,7 @@ nfp_flow_stats_get(struct rte_eth_dev *dev,
struct rte_flow *nfp_flow,
void *data)
{
+ bool reset;
uint32_t ctx_id;
struct rte_flow *flow;
struct nfp_flow_priv *priv;
@@ -3823,6 +3824,7 @@ nfp_flow_stats_get(struct rte_eth_dev *dev,
}
query = (struct rte_flow_query_count *)data;
+ reset = query->reset;
memset(query, 0, sizeof(*query));
ctx_id = rte_be_to_cpu_32(nfp_flow->payload.meta->host_ctx_id);
@@ -3834,7 +3836,7 @@ nfp_flow_stats_get(struct rte_eth_dev *dev,
query->bytes = stats->bytes;
query->hits_set = 1;
query->bytes_set = 1;
- if (query->reset != 0) {
+ if (reset != 0) {
stats->pkts = 0;
stats->bytes = 0;
}