From patchwork Tue Dec 6 15:02:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 120496 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18F83A054A; Tue, 6 Dec 2022 16:03:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B661D40687; Tue, 6 Dec 2022 16:03:18 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 85C774021D for ; Tue, 6 Dec 2022 16:03:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670338996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LXJrJ6j1mwSqI0OKR2aqFWsSOd92jQP2WyZxY3J5Tf0=; b=Qrt4G0qnqXaOa+VxKnXvlgmevA74xrh6fwT9+HVjcYgxonmVwkrYNxq+gdMaQiLNpru1U7 L9lmcr16yPqwo+CL3u+5GqWyW1z5olVMUkulQ/L/MOvd9q0Cu8ozGo5yg7K0Ccrd1zUmtj 9RKn/6+0yAMlnuTPtV9GixhKNRepLCI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-177-XlSki8aUNI2zCsT7we626A-1; Tue, 06 Dec 2022 10:03:12 -0500 X-MC-Unique: XlSki8aUNI2zCsT7we626A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8054D833B00; Tue, 6 Dec 2022 15:03:05 +0000 (UTC) Received: from max-t490s.redhat.com (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 57F3C1121315; Tue, 6 Dec 2022 15:03:03 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, chenbo.xia@intel.com, ktraynor@redhat.com, david.marchand@redhat.com Cc: Maxime Coquelin , stable@dpdk.org Subject: [PATCH] vhost: decrease log level for unimplemented request Date: Tue, 6 Dec 2022 16:02:57 +0100 Message-Id: <20221206150257.70926-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch changes VHOST_USER_SET_VRING_ERR "not implemented" log level from INFO to DEBUG. Indeed, it is not required to support this message type, and since version 7.1, QEMU sends this message for every queue. It could confuse the end-user, thinking there is an issue where there are not. Implementing it could be an option, but it does nothing special on QEMU side but displaying an error message. Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions") Cc: stable@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/vhost_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index 9902ae9944..371d6304d6 100644 --- a/lib/vhost/vhost_user.c +++ b/lib/vhost/vhost_user.c @@ -1809,7 +1809,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev, if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK)) close(ctx->fds[0]); - VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n"); + VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n"); return RTE_VHOST_MSG_RESULT_OK; }