diff mbox series

build: fix missing crypto vec limits in version

Message ID 20221206092329.2250774-1-vfialko@marvell.com (mailing list archive)
State Changes Requested, archived
Delegated to: Jerin Jacob
Headers
Series build: fix missing crypto vec limits in version |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS

Commit Message

Volodymyr Fialko Dec. 6, 2022, 9:23 a.m. UTC 
  Add missing function `rte_event_crypto_adapter_vector_limits_get` to
version.map.

Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")

Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
---
 lib/eventdev/version.map | 1 +
 1 file changed, 1 insertion(+)

Comments

Zhang, Fan Dec. 6, 2022, 9:28 a.m. UTC | #1 
On 12/6/2022 9:23 AM, Volodymyr Fialko wrote:
> Add missing function `rte_event_crypto_adapter_vector_limits_get` to
> version.map.
>
> Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")
>
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> ---
>   lib/eventdev/version.map | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> index dd63ec6f68..1a7fffd17f 100644
> --- a/lib/eventdev/version.map
> +++ b/lib/eventdev/version.map
> @@ -20,6 +20,7 @@ DPDK_23 {
>   	rte_event_crypto_adapter_stats_get;
>   	rte_event_crypto_adapter_stats_reset;
>   	rte_event_crypto_adapter_stop;
> +	rte_event_crypto_adapter_vector_limits_get;
>   	rte_event_dequeue_timeout_ticks;
>   	rte_event_dev_attr_get;
>   	rte_event_dev_close;
Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
Jerin Jacob Jan. 17, 2023, 4:25 p.m. UTC | #2 
On Tue, Dec 6, 2022 at 2:58 PM Zhang, Fan <fanzhang.oss@gmail.com> wrote:
>
> On 12/6/2022 9:23 AM, Volodymyr Fialko wrote:
> > Add missing function `rte_event_crypto_adapter_vector_limits_get` to
> > version.map.
> >
> > Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")
> >
> > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> > ---
> >   lib/eventdev/version.map | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> > index dd63ec6f68..1a7fffd17f 100644
> > --- a/lib/eventdev/version.map
> > +++ b/lib/eventdev/version.map
> > @@ -20,6 +20,7 @@ DPDK_23 {
> >       rte_event_crypto_adapter_stats_get;
> >       rte_event_crypto_adapter_stats_reset;
> >       rte_event_crypto_adapter_stop;
> > +     rte_event_crypto_adapter_vector_limits_get;
> >       rte_event_dequeue_timeout_ticks;
> >       rte_event_dev_attr_get;
> >       rte_event_dev_close;
> Acked-by: Fan Zhang <fanzhang.oss@gmail.com>

+ @Thomas Monjalon  @David Marchand

1) Sanity is failing as follows
### [PATCH] build: fix missing crypto vec limits in version

ERROR: symbol rte_event_crypto_adapter_vector_limits_get is added in
the DPDK_23 section, but is expected to be added in the EXPERIMENTAL
section of the version map

This patch is added in 22.07. New patches should be experimental.
Right? If so, Please change to __rte_experimental and move
EXPERIMENTAL section. If  I am not missing anything.

[1]
[for-main]dell[dpdk-next-eventdev] $ git describe c1749bc5ee1
v22.07-473-gc1749bc5ee

2) Change git log as eventdev/crypto: .....
Thomas Monjalon Jan. 17, 2023, 9:10 p.m. UTC | #3 
17/01/2023 17:25, Jerin Jacob:
> On Tue, Dec 6, 2022 at 2:58 PM Zhang, Fan <fanzhang.oss@gmail.com> wrote:
> >
> > On 12/6/2022 9:23 AM, Volodymyr Fialko wrote:
> > > Add missing function `rte_event_crypto_adapter_vector_limits_get` to
> > > version.map.
> > >
> > > Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")
> > >
> > > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> > > ---
> > >   lib/eventdev/version.map | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> > > index dd63ec6f68..1a7fffd17f 100644
> > > --- a/lib/eventdev/version.map
> > > +++ b/lib/eventdev/version.map
> > > @@ -20,6 +20,7 @@ DPDK_23 {
> > >       rte_event_crypto_adapter_stats_get;
> > >       rte_event_crypto_adapter_stats_reset;
> > >       rte_event_crypto_adapter_stop;
> > > +     rte_event_crypto_adapter_vector_limits_get;
> > >       rte_event_dequeue_timeout_ticks;
> > >       rte_event_dev_attr_get;
> > >       rte_event_dev_close;
> > Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
> 
> + @Thomas Monjalon  @David Marchand
> 
> 1) Sanity is failing as follows
> ### [PATCH] build: fix missing crypto vec limits in version
> 
> ERROR: symbol rte_event_crypto_adapter_vector_limits_get is added in
> the DPDK_23 section, but is expected to be added in the EXPERIMENTAL
> section of the version map
> 
> This patch is added in 22.07. New patches should be experimental.
> Right? If so, Please change to __rte_experimental and move
> EXPERIMENTAL section. If  I am not missing anything.

Yes new functions should be experimental.
You need to add a comment in the .h
and the attribute __rte_experimental.

Such issue would have been seen earlier if the new function
was used in a unit test or a test application.
diff mbox series

Patch

diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
index dd63ec6f68..1a7fffd17f 100644
--- a/lib/eventdev/version.map
+++ b/lib/eventdev/version.map
@@ -20,6 +20,7 @@  DPDK_23 {
 	rte_event_crypto_adapter_stats_get;
 	rte_event_crypto_adapter_stats_reset;
 	rte_event_crypto_adapter_stop;
+	rte_event_crypto_adapter_vector_limits_get;
 	rte_event_dequeue_timeout_ticks;
 	rte_event_dev_attr_get;
 	rte_event_dev_close;