diff mbox series

[02/11] vhost: fix build with clang 15

Message ID 20221118085313.2118977-3-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series Fixes for clang 15 |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

David Marchand Nov. 18, 2022, 8:53 a.m. UTC 
  This variable is not used.

Fixes: abeb86525577 ("vhost: remove copy threshold for async path")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/vhost/virtio_net.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Maxime Coquelin Nov. 18, 2022, 10:23 a.m. UTC | #1 
On 11/18/22 09:53, David Marchand wrote:
> This variable is not used.
> 
> Fixes: abeb86525577 ("vhost: remove copy threshold for async path")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   lib/vhost/virtio_net.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
> index 4358899718..9abf752f30 100644
> --- a/lib/vhost/virtio_net.c
> +++ b/lib/vhost/virtio_net.c
> @@ -1877,7 +1877,6 @@ virtio_dev_rx_async_submit_packed(struct virtio_net *dev, struct vhost_virtqueue
>   	struct rte_mbuf **pkts, uint32_t count, int16_t dma_id, uint16_t vchan_id)
>   {
>   	uint32_t pkt_idx = 0;
> -	uint32_t remained = count;
>   	uint16_t n_xfer;
>   	uint16_t num_buffers;
>   	uint16_t num_descs;
> @@ -1903,7 +1902,6 @@ virtio_dev_rx_async_submit_packed(struct virtio_net *dev, struct vhost_virtqueue
>   		pkts_info[slot_idx].mbuf = pkts[pkt_idx];
>   
>   		pkt_idx++;
> -		remained--;
>   		vq_inc_last_avail_packed(vq, num_descs);
>   	} while (pkt_idx < count);
>   

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
diff mbox series

Patch

diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
index 4358899718..9abf752f30 100644
--- a/lib/vhost/virtio_net.c
+++ b/lib/vhost/virtio_net.c
@@ -1877,7 +1877,6 @@  virtio_dev_rx_async_submit_packed(struct virtio_net *dev, struct vhost_virtqueue
 	struct rte_mbuf **pkts, uint32_t count, int16_t dma_id, uint16_t vchan_id)
 {
 	uint32_t pkt_idx = 0;
-	uint32_t remained = count;
 	uint16_t n_xfer;
 	uint16_t num_buffers;
 	uint16_t num_descs;
@@ -1903,7 +1902,6 @@  virtio_dev_rx_async_submit_packed(struct virtio_net *dev, struct vhost_virtqueue
 		pkts_info[slot_idx].mbuf = pkts[pkt_idx];
 
 		pkt_idx++;
-		remained--;
 		vq_inc_last_avail_packed(vq, num_descs);
 	} while (pkt_idx < count);