[2/2] doc: update MLX5 LRO limitation
Checks
Commit Message
Maximal LRO message size must be multiply of 256.
Otherwise, TCP payload may not fit into a single WQE.
Cc: stable@dpdk.org
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
doc/guides/nics/mlx5.rst | 3 +++
1 file changed, 3 insertions(+)
Comments
17/11/2022 15:39, Gregory Etelson:
> Maximal LRO message size must be multiply of 256.
> Otherwise, TCP payload may not fit into a single WQE.
>
> Cc: stable@dpdk.org
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Why the doc update is not in the same patch as the code change?
> @@ -278,6 +278,9 @@ Limitations
> - No Tx metadata go to the E-Switch steering domain for the Flow group 0.
> The flows within group 0 and set metadata action are rejected by hardware.
>
> +- The driver rounds down the ``max_lro_pkt_size`` value in the port
> + configuration to a multiple of 256 due to HW limitation.
> +
> .. note::
>
> MAC addresses not already present in the bridge table of the associated
If you would like to read the doc, I guess you'd prefer to find this info
in the section dedicated to LRO, not in a random place.
Hello Thomas,
> > .. note::
> >
> > MAC addresses not already present in the bridge table of the
> associated
>
> If you would like to read the doc, I guess you'd prefer to find this info
> in the section dedicated to LRO, not in a random place.
>
I moved the patch location in v2
Regards,
Gregory
22/11/2022 06:17, Gregory Etelson:
> Hello Thomas,
>
> > > .. note::
> > >
> > > MAC addresses not already present in the bridge table of the
> > associated
> >
> > If you would like to read the doc, I guess you'd prefer to find this info
> > in the section dedicated to LRO, not in a random place.
> >
> I moved the patch location in v2
I've fixed v1 and merged yesterday. No need for v2.
@@ -278,6 +278,9 @@ Limitations
- No Tx metadata go to the E-Switch steering domain for the Flow group 0.
The flows within group 0 and set metadata action are rejected by hardware.
+- The driver rounds down the ``max_lro_pkt_size`` value in the port
+ configuration to a multiple of 256 due to HW limitation.
+
.. note::
MAC addresses not already present in the bridge table of the associated