[v3,2/2] test/hash: fix coverity warning
Checks
Commit Message
Check return value after bulk lookup
Coverity issue: 357746
Fixes: 14b8ab576235 ("hash: add bulk lookup with signatures array")
Cc: stable@dpdk.org
Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
app/test/test_hash_perf.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
Comments
On Thu, Nov 10, 2022 at 03:13:34PM +0000, Vladimir Medvedkin wrote:
> Check return value after bulk lookup
>
> Coverity issue: 357746
> Fixes: 14b8ab576235 ("hash: add bulk lookup with signatures array")
> Cc: stable@dpdk.org
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
@@ -475,6 +475,10 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data,
(const void **)keys_burst,
&signatures[j * BURST_SIZE],
BURST_SIZE, positions_burst);
+ if (ret != 0) {
+ printf("rte_hash_lookup_with_hash_bulk failed with %d\n", ret);
+ return -1;
+ }
for (k = 0; k < BURST_SIZE; k++) {
if (positions_burst[k] !=
positions[j *
@@ -487,10 +491,14 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data,
}
}
} else {
- rte_hash_lookup_bulk(h[table_index],
+ ret = rte_hash_lookup_bulk(h[table_index],
(const void **) keys_burst,
BURST_SIZE,
positions_burst);
+ if (ret != 0) {
+ printf("rte_hash_lookup_bulk failed with %d\n", ret);
+ return -1;
+ }
for (k = 0; k < BURST_SIZE; k++) {
if (positions_burst[k] != positions[j * BURST_SIZE + k]) {
printf("Key looked up in %d, should be in %d\n",