From patchwork Wed Nov 9 09:54:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariusz Sosnowski X-Patchwork-Id: 119611 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4492A00C4; Wed, 9 Nov 2022 10:55:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53DBE41133; Wed, 9 Nov 2022 10:55:43 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2050.outbound.protection.outlook.com [40.107.93.50]) by mails.dpdk.org (Postfix) with ESMTP id 386D0410EF for ; Wed, 9 Nov 2022 10:55:42 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lZnfHaidQUGDGnOaisdjHNWGm4UosVmMC4z4EAalbYt6Sp0akM0z1/6vzmaK+sr3Cd+xs+LrP8oOJ0FkSgNYzrxs+pWQm/KYd7PkKzehR4nHr9LmJF6oF6hBqTyQBM9C30m2Mr3kmG//g0IWvjd9FmmM+rYHEClfvY0YRv02llERsoZrzJnE9tw+/hVpKZAgPNAKbc8QomqOxRll0Xtt9DDa3jQxu8Ao347i/OOHJFXO+mJDhse9MNeROCVX49YNnsaAId2o1oDnt6ecwnUOhJH2zQ1yT/pp1p8HUe7XWTTyVHQmTwTb0ZdJOEriH0ZWxbXG2VdUdN/fnnfYGfNQZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=enOFy4hQK2UCMUUtOqO47xfyksbGMBX1Y5tfnAVLEb0=; b=FIQcntHbvzNx+WpinraIvyRsQFenI22yrq94veSpIlyWN947Pt3ALp7JhNVWMbiQafE6/M8RInOZNqBtC5qmsFaTcaxVFEe3z/w5Sz+v/VVN3pO+1d/eod4uhWM3uO4LEWKP8AB4QOyTDd/q+9B+Iqs4cSWjGMhJkA2uQYL1V503KdQKsl3v1B6rfNHeegK/FBoC+4hhW9Ib9Wjlz5hspN/MPrmpy2nczFXIrov0DgHu6YtEy8A/zzngQOWGOC62vGjlxV1hE0wbX3avkMe+/CVxLKnPJtzuXw8lcXAZaC33a3W2umrerxtZx54dayAiqgV6at++X02638ft4AtBdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=enOFy4hQK2UCMUUtOqO47xfyksbGMBX1Y5tfnAVLEb0=; b=PWMhrXrov7H9qRLTk1vY8g0uVxNqpu2lEIAjhDeX7i86zIflo2812njCVdTTBxZ9vbdWaup+q2Ccb5/yV3YsMlL/+RHoah2tbxScfMz6/2KS1rR0BbHdIX/oZ/MxiFCDpd02mHJE6jd8woQQKsq/O0YZLVHUm9CaFAhEqEOIZYiCX2kydxNyNfc19rcAmGDua5r0kspWCy5eIVnRp6+kB8SWnm7n4sX/FYYZtQymaEshxbSHGdgYn756eQWY0hjy5FYQtiGe95tUiADMvGZC7HEbQdZgHeVwF/NTTcuRp7s52ngPEc97yjNXaxPThYCD2WxhRJ1Yxaq+Q/N3hoacmw== Received: from DM6PR10CA0036.namprd10.prod.outlook.com (2603:10b6:5:60::49) by CH3PR12MB7668.namprd12.prod.outlook.com (2603:10b6:610:14d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 09:55:40 +0000 Received: from CY4PEPF0000B8EA.namprd05.prod.outlook.com (2603:10b6:5:60:cafe::25) by DM6PR10CA0036.outlook.office365.com (2603:10b6:5:60::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 09:55:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000B8EA.mail.protection.outlook.com (10.167.241.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11 via Frontend Transport; Wed, 9 Nov 2022 09:55:40 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Wed, 9 Nov 2022 01:55:23 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 9 Nov 2022 01:55:21 -0800 From: Dariusz Sosnowski To: Matan Azrad , Viacheslav Ovsiienko , Alex Vesker , Erez Shitrit CC: , Raslan Darawsheh Subject: [PATCH 1/2] net/mlx5/hws: fix order of destroying default tables Date: Wed, 9 Nov 2022 09:54:30 +0000 Message-ID: <20221109095431.668926-2-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221109095431.668926-1-dsosnowski@nvidia.com> References: <20221109095431.668926-1-dsosnowski@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EA:EE_|CH3PR12MB7668:EE_ X-MS-Office365-Filtering-Correlation-Id: 25c8e1b0-7675-4982-2c6e-08dac2388f53 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0ydnUEf1Go+ppFGphikgujxVrpampb61FzMmqXe7ZUgPzp0n2qcrRLFeFhZFNIFdqHu3fOVeYmi2rmJa1CN2ptTrFjKy0kLHsLTTBqdnbMWozEU8bZeF+hwbNbLPUEeKlGxy2PZCq4OTn5JkgrzitZkgWfo5TPA0QD26r1l4D+TFaYFmNF+AVrvsZZYoI52Cm06K8/LiNa3ljVN4phoBuRRuTGfSsY9OogbHz6++sKMig+drPsaPC2CIEzFG7jZ4/6nlu0vMQGq9JGhBjNOnbdlv58J5DSHY6ZTDuDh0sZBPNo176VbhO0HR0cxytz4+3aZk3ozCnJrNqooKmNdsTqS4IzR5N+uCHF8tBBgmAO5kfIv/jBcqYh+vBY4fHpsHuQjT265+4LKx5J9tsewEu2sxV0G+NukIBgXr/CW1UPYS52Yv1tW5iSCXHMzrNiyy6D2Jz9qXv5K1IY8DTgYROAmvXi+ervyED4lfbMQnmqQeLMV07zRq66XBLKjWzOnpQFhmXr7Jankz08gLId2pIZTU6Gn6p5m0hdyvmViNGLcY8p/5+hg9w4jrOE50LhPiCsHmmRYNWibMIoKQzeDfG1cq8++wJQa7t94quf+GrHZTTbVqHuCYJ7eSjqtHBnufpqqGn04YZEqeH+oI2Lj5q0V3QwYQl9FrPWG4QUsawAWFpBjg+VJa0YRBkHRGWBo8sNcOc+Hl7hcn26bsGV1tmIZidk4iYIbAErodJtkY8jC6NVCBsJGUK3a5eACmU1fTXEaN0EFPV2F6twbvp4xsmA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199015)(40470700004)(36840700001)(46966006)(86362001)(426003)(2906002)(82310400005)(40460700003)(356005)(7636003)(4326008)(6666004)(107886003)(2616005)(26005)(7696005)(6286002)(110136005)(6636002)(316002)(8676002)(70206006)(478600001)(55016003)(40480700001)(54906003)(8936002)(70586007)(36860700001)(186003)(16526019)(47076005)(1076003)(5660300002)(36756003)(336012)(83380400001)(41300700001)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 09:55:40.2865 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25c8e1b0-7675-4982-2c6e-08dac2388f53 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000B8EA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7668 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Erez Shitrit This patch fixes the order dereferencing default FDB miss table and destroying the flow table object. Flow table should be destroyed before the dereference. Fixes: 394cc7ba4033 ("net/mlx5/hws: add table object") Cc: valex@nvidia.com Signed-off-by: Erez Shitrit Signed-off-by: Dariusz Sosnowski Reviewed-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_table.c b/drivers/net/mlx5/hws/mlx5dr_table.c index d3f77e4780..33052abce8 100644 --- a/drivers/net/mlx5/hws/mlx5dr_table.c +++ b/drivers/net/mlx5/hws/mlx5dr_table.c @@ -131,8 +131,8 @@ mlx5dr_table_create_default_ft(struct mlx5dr_table *tbl) void mlx5dr_table_destroy_default_ft(struct mlx5dr_table *tbl, struct mlx5dr_devx_obj *ft_obj) { - mlx5dr_table_down_default_fdb_miss_tbl(tbl); mlx5dr_cmd_destroy_obj(ft_obj); + mlx5dr_table_down_default_fdb_miss_tbl(tbl); } static int mlx5dr_table_init(struct mlx5dr_table *tbl)