diff mbox series

net/idpf: fix memory leak

Message ID 20221109062913.18622-1-beilei.xing@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series net/idpf: fix memory leak |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance fail Performance Testing issues

Commit Message

Xing, Beilei Nov. 9, 2022, 6:29 a.m. UTC 
  From: Beilei Xing <beilei.xing@intel.com>

This patch fixes memory leak during Tx split queue release.

Fixes: 19b58dba9dc3 ("net/idpf: support queue release")

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 drivers/net/idpf/idpf_rxtx.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Peng, Yuan Nov. 9, 2022, 7:19 a.m. UTC | #1 
Tested-by: Peng, Yuan <yuan.peng@intel.com>

> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Wednesday, November 9, 2022 2:29 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Peng, Yuan <yuan.peng@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: [PATCH] net/idpf: fix memory leak
> 
> From: Beilei Xing <beilei.xing@intel.com>
> 
> This patch fixes memory leak during Tx split queue release.
> 
> Fixes: 19b58dba9dc3 ("net/idpf: support queue release")
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Qi Zhang Nov. 9, 2022, 7:25 a.m. UTC | #2 
> -----Original Message-----
> From: Peng, Yuan <yuan.peng@intel.com>
> Sent: Wednesday, November 9, 2022 3:19 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] net/idpf: fix memory leak
> 
> Tested-by: Peng, Yuan <yuan.peng@intel.com>
> 
> > -----Original Message-----
> > From: Xing, Beilei <beilei.xing@intel.com>
> > Sent: Wednesday, November 9, 2022 2:29 PM
> > To: Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; Peng, Yuan <yuan.peng@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>
> > Subject: [PATCH] net/idpf: fix memory leak
> >
> > From: Beilei Xing <beilei.xing@intel.com>
> >
> > This patch fixes memory leak during Tx split queue release.
> >
> > Fixes: 19b58dba9dc3 ("net/idpf: support queue release")
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
diff mbox series

Patch

diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c
index b338a67de7..ef2fdb317d 100644
--- a/drivers/net/idpf/idpf_rxtx.c
+++ b/drivers/net/idpf/idpf_rxtx.c
@@ -213,7 +213,11 @@  idpf_tx_queue_release(void *txq)
 	if (q == NULL)
 		return;
 
-	rte_free(q->complq);
+	if (q->complq) {
+		rte_memzone_free(q->complq->mz);
+		rte_free(q->complq);
+	}
+
 	q->ops->release_mbufs(q);
 	rte_free(q->sw_ring);
 	rte_memzone_free(q->mz);