diff mbox series

[v2] net/mlx5/hws: fix capability check to allow HWS on non esw-mngr

Message ID 20221107110643.20611-1-valex@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series [v2] net/mlx5/hws: fix capability check to allow HWS on non esw-mngr |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-x86_64-compile-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Alex Vesker Nov. 7, 2022, 11:06 a.m. UTC 
  On context initialization the reparse capability support
for NIC and FDB tables was required for allowing HWS. This
caused a problem for devices that only want to run NIC
steering and are not the esw-manager fow which  FDB reparse
is disabled. Modified the check to require FDB reparse only for
esw-manager.

Fixes: b0290e5 ("net/mlx5/hws: add context object")
Signed-off-by: Alex Vesker <valex@nvidia.com>
Reviewed-by: Erez Shitrit <erezsh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 drivers/net/mlx5/hws/mlx5dr_context.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Raslan Darawsheh Nov. 8, 2022, 9:01 a.m. UTC | #1 
Hi,

> -----Original Message-----
> From: Alex Vesker <valex@nvidia.com>
> Sent: Monday, November 7, 2022 1:07 PM
> To: Alex Vesker <valex@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>; Suanming Mou <suanmingm@nvidia.com>;
> Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; Ori Kam <orika@nvidia.com>
> Subject: [PATCH v2] net/mlx5/hws: fix capability check to allow HWS on non
> esw-mngr
> 
changed commit title a bit, 
> On context initialization the reparse capability support
> for NIC and FDB tables was required for allowing HWS. This
> caused a problem for devices that only want to run NIC
> steering and are not the esw-manager fow which  FDB reparse
> is disabled. Modified the check to require FDB reparse only for
> esw-manager.
> 
> Fixes: b0290e5 ("net/mlx5/hws: add context object")
added missing empty line
> Signed-off-by: Alex Vesker <valex@nvidia.com>
> Reviewed-by: Erez Shitrit <erezsh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx5/hws/mlx5dr_context.c b/drivers/net/mlx5/hws/mlx5dr_context.c
index ae86694a51..76ada7bb7f 100644
--- a/drivers/net/mlx5/hws/mlx5dr_context.c
+++ b/drivers/net/mlx5/hws/mlx5dr_context.c
@@ -108,7 +108,8 @@  static void mlx5dr_context_check_hws_supp(struct mlx5dr_context *ctx)
 	}
 
 	/* Current solution requires all rules to set reparse bit */
-	if ((!caps->nic_ft.reparse || !caps->fdb_ft.reparse) ||
+	if ((!caps->nic_ft.reparse ||
+	     (!caps->fdb_ft.reparse && caps->eswitch_manager)) ||
 	    !IS_BIT_SET(caps->rtc_reparse_mode, MLX5_IFC_RTC_REPARSE_ALWAYS)) {
 		DR_LOG(INFO, "Required HWS reparse cap not supported");
 		return;